Repository navigation
Should Html.PrimeCache be named Html.PrimeCacheAsync? #246
Description
Activity
Yes, I think you're right! Will add that as a new overload and will mark the old one as obsolete.
While you're at it, maybe the new overload should return
Task<IHtmlContent>instead ofTask<HtmlString>(likeHtml.PartialAsync), which would allow the results to be written to aTextWriterinstead of having to concatenate/format/allocate a (potentially large) string to return withHtmlString?HtmlStringitself implementsIHtmlContentso the existing implementation could remain as-is for now; returningTask<IHtmlContent>leaves the door open to perf improvements in the future.Implemented. As per your suggestion, also changed the return type to
Task<IHtmlContent>. Currently it's still usingHtmlStringbut could change to a custom less-allocatey alternative like your prototype in the future.Reacted by Justin Van Patten- added a commit that references this issue
on Aug 17, 2016
MVC APIs that return
Task/Task<T>have theAsyncsuffix, e.g.Html.PartialAsync.For consistency with MVC APIs and as an indicator to developers that they should
@awaitthe result, shouldn'tHtml.PrimeCachebe namedHtml.PrimeCacheAsync?