Don't force Node to be on the PATH #20

Activity

1. SteveSandersonMS commented on Dec 9, 2015

   

   SteveSandersonMS

   on Dec 9, 2015

   Member

   More actions

   Good idea. This config option could be added to the services.AddNodeServices(config) API, with the default being to continue assuming Node is on the system path.

   Pull requests are welcome :)
2. SteveSandersonMS

   added

   enhancement

   core

   P2

   on Dec 9, 2015
3. thunder7553

   added a commit that references this issue on Jul 13, 2016

   Added OnBeforeStartExternalProcess callback which to NodeServicesOpti…

   ...

   This issue will close once commit 122f78f is merged into the 'dev' branch.

   122f78f
4. SteveSandersonMS

   closed this as completedin 7119815on Jul 18, 2016
5. SteveSandersonMS commented on Jul 18, 2016

   

   SteveSandersonMS

   on Jul 18, 2016

   Last edited by SteveSandersonMS

   Member

   More actions

   For anyone wondering how to override the path where the node executable is found, you can do it like this:

   public class MyHttpNodeInstance : HttpNodeInstance
   {
       protected override ProcessStartInfo PrepareNodeProcessStartInfo(string entryPointFilename, string projectPath, string commandLineArguments)
       {
           var startInfo = base.PrepareNodeProcessStartInfo(entryPointFilename, projectPath, commandLineArguments);
   
           // Here you can modify 'startInfo' to specify where the Node executable should be found
   
           return startInfo;
       }
   }

   ... and then set MyHttpNodeInstance as the active Node instance type, as per the docs at https://github.com/aspnet/JavaScriptServices/tree/dev/src/Microsoft.AspNetCore.NodeServices#custom-hosting-models.