Repository navigation
Generate service : providers registered in the wrong place if { provide } is present #7061
Description
Bug Report or Feature Request (mark with an x)
- [x] bug report -> please search issues before submitting
- [ ] feature request
Versions.
cli 1.2.1
Repro steps.
ng new test
cd test
ng g service hello
Then in AppModule, provide it like this :
@NgModule({
declarations: [
AppComponent
],
imports: [
BrowserModule
],
providers: [{ provide: HelloService, useClass: HelloService}],
bootstrap: [AppComponent]
})Now, if you generate new services, with module registering option :
ng g service world --module=app
It produces :
@NgModule({
declarations: [
AppComponent
],
imports: [
BrowserModule
],
providers: [{provide: HelloService, useClass: HelloService, providers: [WorldService]}],
bootstrap: [AppComponent]
})
Activity
cyrilletuzi commentedon Jul 28, 2017
The problem may be coming from this function, but didn't find yet why :
angular-cli/packages/@angular/cli/lib/ast-tools/ast-utils.ts
Line 192 in d1e13ac
cyrilletuzi commentedon Aug 18, 2017
@hansl Still there with the schematics
denniske commentedon Sep 20, 2017
Created pull request with fix. Can somebody review?
cyrilletuzi commentedon Dec 8, 2017
@filipesilva @Brocco This issue has been marked as a regression and is 4 months old, and has a PR waiting which is 2 months old. Can someone take care of it ?
cyrilletuzi commentedon Jan 13, 2018
@hansl @filipesilva @Brocco This issue has been marked as a regression and is 5 months old, and has a PR waiting which is 3 months old. Can someone take care of it ?
cyrilletuzi commentedon Feb 8, 2018
Happy to see someone is caring for this issue, but quite disagree with the new severity level : it's not just "inconvenient", it produces code that break compilation. So it should at least be "severity3: broken".
cyrilletuzi commentedon Mar 23, 2018
Will this be fixed in v6 ?
cyrilletuzi commentedon Apr 25, 2018
As in v6 services are not provided in the NgModule anymore, the issue is gone.
angular-automatic-lock-bot commentedon Sep 8, 2019
This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.
Read more about our automatic conversation locking policy.
This action has been performed automatically by a bot.