Repository navigation
"ng test" does not bail on type definition errors #3424
Description
OS
Mac OSX - EL Capitan
Versions.
angular-cli: 1.0.0-beta.19-3
node: 6.4.0
os: darwin x64
Repro steps.
- Have a default angular-cli setup in place (by running "ng new <project_name>")
- Then there should be
AppComponentand its spec file created by default. - Add a new method in
app.component.ts:
public static returnAorB(character: 'A' | 'B') {
return character;
}And add following line anywhere in app.component.spec.ts:
expect(AppComponent.returnAorB('C')).toEqual('C');- Run "ng test --watch=false"
It will generate an error complaining Argument of type '"C"' is not assignable to parameter of type '"A" | "B"'. But the command did not exit.
The log given by the failure.
....
ERROR in [default] <path>/src/app/app.component.spec.ts:16:35
Argument of type '"C"' is not assignable to parameter of type '"A" | "B"'.
.....
(Completes and Exits with successful code)
Activity
hansl commentedon Dec 6, 2016
Right, we don't check for build errors on test. That's a bug, thanks! Will fix.
JohannesRudolph commentedon Dec 8, 2016
I think this is a duplicate of #2778 , which is incorrectly flagged as "need: repro steps" right now as @huyph here and @fabian-dev in the linked issue have produced a repro sample.
fix(@angular/cli): fix error handling on test
fix(@angular/cli): fix error handling on test
fix(@angular/cli): fix error handling on test
fix(@angular/cli): fix error handling on test
fix(@angular/cli): fix error handling on test
fix(@angular/cli): fix error handling on test
angular-automatic-lock-bot commentedon Sep 6, 2019
This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.
Read more about our automatic conversation locking policy.
This action has been performed automatically by a bot.
fix(@angular/cli): fix error handling on test