Repository navigation
Missing pipe not caught by production build with AOT #38195
Description
🐞 Bug report
Command (mark with an x)
- new
- build
- serve
- test
- e2e
- generate
- add
- update
- lint
- xi18n
- run
- config
- help
- version
- doc
Description
I have a module with a view that includes a pipe from a library.
The library was not imported into this module and thus the pipe is not included in the module.
IntelliJ correctly flags the missing pipe but the Angular build process (even when AOT is enabled) does not find this problem
The same issue occurs when referencing a pipe that doesn't even exist at all, the builder never shows any warnings or errors
The above image shows the app component including a pipe that does not exist. The pipe is highlighted red as IntelliJ recognizes the pipe has not been imported. The terminal below shows a successful production build of the project including the missing pipe. I would expect the build to fail
The example above and the repo below are both built using Nrwl NX but the same issue can be found with a regular Angular project
🔬 Minimal Reproduction
Check out the following repo: https://github.com/lukebellamy053/angular-pipe-error-example
Build either of the applications, both should fail as the pipe is either not imported or just doesn't exist but the build passes in both cases
🔥 Exception or Error
There isn't one but there should be
Activity
JoostK commentedon Jul 23, 2020
Interesting, thanks for reporting. This should typically be flagged as an error, some investigation is needed to figure out why this doesn't happen here.
lukebellamy053 commentedon Jul 29, 2020
@JoostK Looks like this is also the case with missing components as well
JoostK commentedon Oct 17, 2020
Alright, it turns out that pipes are not reported as missing when
fullTemplateTypeCheckis disabled/not set. I opened #39320 to address that, but it will continue to suffer from #36171.fix(compiler-cli): report missing pipes when `fullTemplateTypeCheck` …
fix(compiler-cli): report missing pipes when `fullTemplateTypeCheck` …
fix(compiler-cli): report missing pipes when `fullTemplateTypeCheck` …
angular-automatic-lock-bot commentedon Dec 1, 2020
This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.
Read more about our automatic conversation locking policy.
This action has been performed automatically by a bot.