Activity

1. skreborn commented on Jan 7, 2019

   

   skreborn

   on Jan 7, 2019

   Contributor

   More actions

   This happens because BrowserViewportScroller.getScrollPosition returns with the values window.scrollX and window.scrollY, neither of which are supported by Internet Explorer.

   This seems to be incorrectly feature-detected earlier in the function by BrowserViewportScroller.supportScrollRestoration, which returns true for IE11, as both window itself and window.scrollTo are defined. This, however, doesn't check for the availability of the scrollX and scrollY properties.
2. kara

   added

   area: commonIssues related to APIs in the @angular/common packageIssues related to APIs in the @angular/common package

   on Jan 7, 2019
3. ngbot

   added this to the needsTriage milestone on Jan 7, 2019
4. benlesh

   added

   type: bug/fix

   severity3: broken

   risk: low

   on Jan 10, 2019
5. enten commented on Feb 28, 2019

   

   enten

   on Feb 28, 2019

   Last edited by enten

   More actions

   Why not update ViewportScroller to get viewport scroll position like material2?

   --

   In-app fix: adding a polyfill in src/polyfills.ts for window.scrollX and window.scrollY can "fix" the issue (for the browser target) with the current ViewportScroller implementation.

   Example for IE11:

   // src/polyfills
   if (!('scrollX' in window)) {
     Object.defineProperty(window, 'scrollX', { get: () => window.pageXOffset });
   }
   
   if (!('scrollY' in window)) {
     Object.defineProperty(window, 'scrollY', { get: () => window.pageYOffset });
   }

   👍React with 👍2Reacted by Thomas Champion and Tautvydas Petkūnas
6. matsko

   added

   freq2: medium

   on Apr 25, 2019
7. ngbot

   modified the milestones: needsTriage, Backlog on Apr 25, 2019
8. petebacondarwin

   added

   browser: ie 11

   on May 28, 2020
9. petebacondarwin commented on May 28, 2020

   

   petebacondarwin

   on May 28, 2020

   Last edited by petebacondarwin

   Contributor

   More actions

   It seems to me that it would be enough to use the this.window.pageXOffset and this.window.pageYOffset properties instead.

   From https://developer.mozilla.org/en-US/docs/Web/API/Window/scrollX#Notes

   The pageXOffset property is an alias for the scrollX property:

   window.pageXOffset == window.scrollX; // always true
   For cross-browser compatibility, use window.pageXOffset instead of window.scrollX.

   These properties are supported by IE9-11: https://developer.mozilla.org/en-US/docs/Web/API/Window/pageXOffset#Browser_compatibility
10. petebacondarwin

    added

    state: confirmed

    triage #1

    on May 28, 2020
11. petebacondarwin

    added

    state: has PR

    on Jul 14, 2020
12. jelbourn

    added

    P3An issue that is relevant to core functions, but does not impede progress. Important, but not urgentAn issue that is relevant to core functions, but does not impede progress. Important, but not urgent

    and removed

    P3An issue that is relevant to core functions, but does not impede progress. Important, but not urgentAn issue that is relevant to core functions, but does not impede progress. Important, but not urgent

    on Oct 1, 2020
13. ngbot

    modified the milestones: Backlog, needsTriage on Oct 1, 2020
14. jelbourn

    added

    P4A relatively minor issue that is not relevant to core functionsA relatively minor issue that is not relevant to core functions

    on Oct 1, 2020
15. ngbot

    modified the milestones: needsTriage, Backlog on Oct 1, 2020
16. jelbourn

    removed

    severity3: broken

    on Oct 1, 2020
17. AndrewKushnir commented on Nov 19, 2020

    

    AndrewKushnir

    on Nov 19, 2020

    Contributor

    More actions

    FYI, the corresponding PR #28262 that contains the fix was merged, so I'm closing this ticket. The fix should be available once the next release (11.0.3) is published. Thank you.
18. AndrewKushnir

    closed this as completedon Nov 19, 2020
19. angular-automatic-lock-bot commented on Dec 20, 2020

    

    angular-automatic-lock-botbot

    on Dec 20, 2020

    More actions

    This issue has been automatically locked due to inactivity.
    Please file a new issue if you are encountering a similar or related problem.

    Read more about our automatic conversation locking policy.

    _{This action has been performed automatically by a bot.}
20. angular-automatic-lock-bot

    locked and limited conversation to collaborators on Dec 20, 2020