Repository navigation
redundant cast to android.view.View #835
Description
Activity
Actually there are warnings in lot of AA generated classes and these can be hard to filter or would overcomplicate the generation code. I think you should not use
-Werrorwith AA. Altought this is only my opinion, @DayS can give you a proper answer.I never understand the need to use
-Werroroption. Sometimes you have to use libraries which contains warnings and you just can't do much about it.
I don't like to have warnings in my project neither, but code generation is complicated enough to write (mostly to read). So, we could make some work to remove all warnings but I think it's overkill.I'm closing this issue but we could continue to debate about it here :)
Then library contains such code it's library author choice, but as a user I still want a freedom, in this case - whenever I should use
-Werroror not - it's my choice.
Take a look at lombok, their code contains tons of warning as well, but they at least suppress it with@SuppressWarnings("all")
I suggest to do the same at least. As long as code with warnings works I don't care about it since I didn't written it by hand and it is there just to reduce boilerplate.
It's not a good idea to use this even on the generated code. The warning can be really serious, in that case the developer should fix the generation mechanism to avoid that warning. If the code uses this annotation, no warning will be raised, ever. Of course he can remove the annotation while developing and add back before committing, but it's a pain in the ass. Of course a deployment script could also do it, bad the whole idea smells bad for me. :)
I see your point here. But people are lazy creatures. Having always lots of warnings makes us lazily ignore them, so its really easy to miss that critical warning you say about, if you always see tons of them. This is why some people use
-Werror- to don't let laziness win, but fix troubles instead of lazy "ok, I'll deal with it later".What IDE are you using? In Eclipse, you can filter warnings from different folders. See this SO answer for details. You can set the
.apt_generatedfolder to be ignored, so you only get the compilation messages for your code.I'm using maven and build my app only using maven, so it does not matter that IDE I'm using. There is no such thing like suppressing warnings from folder for javac afaik.
I see. Then you have too options left: turning off
-Werroror convincing @DayS . :)I'll keep this in mind and check the amount of work to do.
My code looks like this:
Then I compile I getting this warning which leads to compile error due to -Werror