This repository was archived by the owner on Feb 26, 2023. It is now read-only.
Repository navigation
This repository was archived by the owner on Feb 26, 2023. It is now read-only.
SharedPreferencesHelpers, specify key for preference #826
Description
Activity
I'm writing down the details about the feature i proposed.
I would append an
int resKey ()method to the@DefaultXXXannotations, but at least for@DefaultString:public @interface DefaultString { String value() default ResId.DEFAULT_VALUE; int resKey () default ""; }
Let's suppose there is a string resource named
prefKeyand the clientPreferencesinterface is the following:@SharedPref public interface Preferences { @DefaultString(value = "0", resKey = R.string.prefKey) String myPref(); }
The generated
Preferences_class would be something like this:public final class Preferences_ extends SharedPreferencesHelper { private Context context_; public Preferences_(Context context) { super(PreferenceManager.getDefaultSharedPreferences(context)); this.context_ = context; } public Preferences_.PreferencesEditor_ edit() { return new Preferences_.PreferencesEditor_(getSharedPreferences()); } public StringPrefField myPref() { return stringField(context.getString(R.string.prefKey), "0"); } public final static class PreferencesEditor_ extends EditorHelper<Preferences_.PreferencesEditor_> { PreferencesEditor_(SharedPreferences sharedPreferences) { super(sharedPreferences); } public StringPrefEditorField<Preferences_.PreferencesEditor_> myPref() { return stringField(context.getString(R.string.prefKey)); } } }
@DayS, what do you think?
Merged :)
If you declare a preference helper like this:
The generated helper class will use the method name (
searchChoiceDisplayMode) in this case as the key of the preference.But if the application already uses a
PreferenceActivity, these keys are declared as IDs and are in theR.idclass. If the@DefaultXXannotations would accept a second optional argument which defines the pref key, we could safely use the IDs and we did not have to change the method name if the ID changes.