Repository navigation
@OnActivityResult to process Intent extras #796
Description
Activity
Seems interesting. We could add both versions and use the latter one in the implementation of the first.
I'm planning it for 3.1.
👍 for
@Result
On the second approach, how should this IntenBuilder be generated? Based on@Extra?Yes, that was my idea. I don't know if the result Intent should be the same/use the same names/variables as the starting Intent, so maybe it should be completely different, i.e. use a different annotation and different factory class. I have no opinion as to what is best.
I've started implementation of
@Result, but don't expect a patch any time soon (or maybe at all) because it's my first time with codemodel and I'm stuck trying to get Eclipse configured without using a 2nd Eclipse.this can be closed.
Thanks, indeed.
This was implemented.
When receiving a reply back via @OnActivityResult it would be great if you could annotate the result with @Result or something similar and get the variables as the response. E.g.:
@OnActivityResult(OtherActivity.REQUEST_CODE)
void response(int resultCode, @Result(OtherActivity.ID) String id) {
...
}
This is an improvement on #28.
Another solution would be for the IntentBuilder to have get-methods for retrieving the value out of the intent with the correct type. E.g.:
@OnActivityResult(OtherActivity.REQUEST_CODE)
void response(int resultCode, Intent resultIntent) {
String id = OtherActivity_.IntentBuilder.create(resultIntent).getId();
}