Repository navigation
HoloEverywhere support #776
Description
Activity
What if someone still using old version of HoloEveywhere ? In this case we still have to generate ActionBarScherlock's related code.
Maybe we could provide a way to exclude some library related code with annotation processor option. DunnoAs I wrote above I am not familiar with library internals so can't answer what to do. You are right - anyway someone using old versions so need some support for both cases. As quick solution may be remove automatic detection of holoeverywhere and display some message instead about what to do or link to webpage with detailed descirption?
Hmm - look - may be I am wrong - I am not a java guru
But may be codel like this could be usefultry { Class.forName("com.actionbarsherlock.app.SherlockActivity"); return true; } catch(Exception e) { return false; }So we just checking if ActionBarScherlock classes are present in the classpath and in case of HoloEverywhere it mean ActionBarScherlock used (including ActionBarCompat together with ActionBarScherlock caused compile error so this is impossible to have both library in one project)
Suppose such way we can unambiguously know about use ActionBarScherlock or not.
Yes, we could check if ABS is present in classpath (not using this code. we have a helper somewhere to do this :)).
I'll work on this point tomorrow.It should fixed and retro-compatible. Please re-open if not
HoloEveywhere no more depends from ActionBarScherlock libary. It uses ActionBarCompat instead.
So this code in ThirdPartyLibHelper.java is not right anymore
Unfortunately it generates ActionBarScherlock code even if ActionBarScherlock not used in project. At least in my project I got issue with @optionsmenu annotation.
I am not familiar with AndroidAnnotations library code so can't to fix myself and prepare pull request, but at least I can point to problematic place. Hope it can be useful.