Skip to content
This repository was archived by the owner on Feb 26, 2023. It is now read-only.
This repository was archived by the owner on Feb 26, 2023. It is now read-only.

Allow any kind of constructor for abstract @EBean #746

Description

@dodgex

As i'm unhappy with the spring rest template stuff, i decided to go with another solution and therfore i created an abstract @ebean with this public AbstractRest(String server, Class<T> api) constructor.

in my extending classes i have something like this

public RestService() {
        super("http://example.org/api", RestInterface.class);
}

the problem is, that @ebean does only allow classes with 1 constructor that has no parameters or a Context parameter.

while i can understand this for regular @ebean classes, i think for abstract classes it is ok to have any constructors as there will be no AA generated class directly for that bean. And the extending beans are still forced to meet the @ebean constructor rules.

i made a pretty simple patch for this, but i have no idea how to get a PR for that as the branch i created also contains the commits for #736 and i don't know how to remove them...

here is the commit https://github.com/dodgex/androidannotations/commit/48e1b730baefed77c2cbe1a30b57fa94dd2d1fb9

Activity

  1. DayS commented on Oct 4, 2013

    @DayS
    Contributor

    Good point.
    I'll take a look at your other PR. Please make a new PR for this feature after I merged #736

  2. dodgex commented on Oct 4, 2013

    @dodgex
    MemberAuthor

    I'll do that on sunday.

    Damien notifications@github.com schrieb:

    Good point.
    I'll take a look at your other PR. Please make a new PR for this
    feature after I merged #736


    Reply to this email directly or view it on GitHub:
    #746 (comment)

    Diese Nachricht wurde von meinem Mobiltelefon mit Kaiten Mail gesendet.

  3. dodgex commented on Oct 6, 2013

    @dodgex
    MemberAuthor

    added the pull request #755

  4. dodgex commented on Nov 25, 2013

    @dodgex
    MemberAuthor

    any news on this one? :)

  5. DayS commented on Nov 25, 2013

    @DayS
    Contributor

    Nop. I think I'll take a look on this one after 3.0 release :)

  6. dodgex commented on Nov 25, 2013

    @dodgex
    MemberAuthor

    although it would be nice to see this one in 3.0 its your choice to merge it or not :)

    i'm looking forward to get rid of the -SNAPSHOT or in my case the self build -SNAPSHOT, as the SNAPSHOTs already f_ked my app three times, luckily only once in a version that reached playstore :-D

  7. dodgex commented on Dec 21, 2013

    @dodgex
    MemberAuthor

    #822 is an updated PR for this issue with the changes for the merged refactor PR #619

  8. DayS commented on Mar 16, 2014

    @DayS
    Contributor

    Merged. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions