SharedPreferences should allow a default value specified from a resource #536

Activity

1. DayS commented on May 4, 2013

   

   DayS

   on May 4, 2013

   Contributor

   More actions

   I think this is a good idea and it should be quit simple to implement.

   The following example is an improvement of the wiki example :

   @SharedPref
   public interface MyPrefs {
       @DefaultString(R.string.defaultPrefName)
       String resourceName();
   
       @DefaultString("John")
       String name();
   }

   The generated code should be :

   public final class MyPrefs_ extends SharedPreferencesHelper {
       private Context context;
   
       public MyPrefs_(Context context) {
           super(context.getSharedPreferences((getLocalClassName(context)+"_MyPrefs"), 0));
           this.context = context;
       }
   
       public StringPrefField resourceName() {
           return stringField("resourceName", context.getResources().getString(R.string.app_name));
       }
   
       public StringPrefField name() {
           return stringField("name", "John");
       }
   }
2. DayS commented on May 4, 2013

   

   DayS

   on May 4, 2013

   Contributor

   More actions

   The new format of the annotations should be something like that :

   public @interface DefaultString {
       String value() default "";
       String resName() default "";
       int resValue() default ResId.DEFAULT_VALUE;
   }
3. DayS commented on May 5, 2013

   

   DayS

   on May 5, 2013

   Contributor

   More actions

   Ok. I just looked further into the code dealing with Android's resources injection and everything is tied up to the value and resName paired attributes. So, we can't just modify the existing annotations without breaking the API.
   We have to create new a set of annotations @DefaultResString, @DefaultResInteger, etc.. And the implementation should be like this :

   public @interface DefaultResString {
       String value() default ResId.DEFAULT_VALUE;
       String resName() default "";
   }
4. yDelouis commented on Jun 19, 2013

   

   yDelouis

   on Jun 19, 2013

   Contributor

   More actions

   This should be documented and closed.
5. DayS commented on Jun 20, 2013

   

   DayS

   on Jun 20, 2013

   Contributor

   More actions

   Wiki updated
6. DayS

   closed this as completedon Jun 20, 2013