The generated code is wrong when extending activities annotated with @OptionsMenu  #473

Activity

1. mathieuboniface commented on Jan 26, 2013

   

   mathieuboniface

   on Jan 26, 2013

   ContributorAuthor

   More actions

   I've just provided a fix on that issue.

   Now, when multiple @OptionsMenu are processed from the class hierarchy, only one method is created, and this method inflate all the declared menu from super classes annotations.

   Example :

   @EActivity
   @OptionsMenu({R.menu.my_menu, R.menu.my_menu2})
   public class OptionsMenuActivity extends Activity {
   
       // ...
   
   }

   @EActivity
   @OptionsMenu(R.menu.my_menu3)
   public class OptionsMenuSubActivity extends OptionsMenuActivity {
   
       // ...
   
   }

   Will produce the following code :

   public final class OptionsMenuSubActivity_ extends OptionsMenuSubActivity {
   
       // ...
   
       @Override
       public boolean onCreateOptionsMenu(Menu menu) {
           MenuInflater menuInflater = getMenuInflater();
           menuInflater.inflate(org.androidannotations.test15.R.menu.my_menu, menu);
           menuInflater.inflate(org.androidannotations.test15.R.menu.my_menu2, menu);
           menuInflater.inflate(org.androidannotations.test15.R.menu.my_menu3, menu);
           return super.onCreateOptionsMenu(menu);
       }
   
       // ...
   
   }

   @charlie
   To resolve your issue, you can try the latest snapshot from here : https://oss.sonatype.org/content/repositories/snapshots/org/androidannotations/androidannotations-bundle/3.0-SNAPSHOT/

   We could enhance AA flexibility by providing a way to override @OptionsMenu declared from super classes. Any thoughts appreciated !
   Example :

   @EActivity
   @OptionsMenu({R.menu.my_menu, R.menu.my_menu2})
   public class OptionsMenuActivity extends Activity {
   
       // ...
   
   }

   @EActivity
   @OptionsMenu(value=R.menu.my_menu3, override=true)
   public class OptionsMenuSubActivity extends OptionsMenuActivity {
   
       // ...
   
   }

   Should produce the following code :

   public final class OptionsMenuSubActivity_ extends OptionsMenuSubActivity {
   
       // ...
   
       @Override
       public boolean onCreateOptionsMenu(Menu menu) {
           MenuInflater menuInflater = getMenuInflater();
           menuInflater.inflate(org.androidannotations.test15.R.menu.my_menu3, menu);
           return super.onCreateOptionsMenu(menu);
       }
   
       // ...
   
   }
2. odbol commented on Feb 5, 2013

   

   odbol

   on Feb 5, 2013

   More actions

   I am having the same issue, although I can't even inherit my Activity because it's final. On this page, it says "we favor composition over inheritance" and I'd love to know if there's a way to just inject the OptionsMenu functionality into all my Activities.

   I think keeping OptionMenu stuff in a separate EBean class would be cool, because then you could just inject several of them into your Activity and it would combine them for you. This would also make it easy to add a single menu item to the global application menu only on certain activities (for instance, a Share button). Do you think this is possible?
3. odbol commented on Feb 6, 2013

   

   odbol

   on Feb 6, 2013

   More actions

   To expand on your example:

   @EBean
   @OptionsMenu({R.menu.my_menu})
   public class MyOptionsMenu {
   
       // ...
   
   }
   

   And then you would inject it into your Activity like this:

   @EActivity
   public class OptionsMenuActivity extends Activity {
   
      @EBean
      MyOptionsMenu globalOptions;
   
   
      @EBean
      MyShareOptionsMenu shareOptions;
       // ...
   
   }
   
4. mathieuboniface commented on Feb 23, 2013

   

   mathieuboniface

   on Feb 23, 2013

   ContributorAuthor

   More actions

   Hi @odbol,

   Sorry for the late answer, i'm currently switching to a new job...

   Actually, there is now way to define application-wide options menu.

   The main issue I see with your proposal is how to deal with incremental compilation. In fact AA does not keep any state between each compilation, so when OptionsMenuActivity is compiled, nothing is known about MyOptionsMenu and the right code cannot be generated.
5. DayS commented on Jan 20, 2014

   

   DayS

   on Jan 20, 2014

   Contributor

   More actions

   All of this should (but the override option) be fixed now.
6. DayS

   closed this as completedon Jan 20, 2014