Repository navigation
Implement more events, onFocusChange specifically #434
Description
Activity
Feel free to implement this! :) .
Could you first elaborate on what the API would look like (annotations & how you'd use them) and what the generated code would look like ?
I imagine the annotation would follow the current paradigm, by putting an "@Focus" annotation on a method named after a view (or pass it param):
@ViewById View myView; @Focus void myViewFocused(View v, boolean hasFocus){ --- Listener logic! --- }
OR
@ViewById View myView; @Focus(R.id.myView) void clickedAViewFunctionNameThing(View v, boolean hasFocus){ --- Listener logic! --- }
Where the function parameters could probably be optional, but I'd imagine the most common usage using at least the boolean.
Generated code for these would look something like this
View view = findViewById(R.id.myView); view.setOnFocusChangeListener(new OnFocusChangeListener(){ @Override public void onFocusChange(View v, boolean hasFocus) { --- Listener logic! --- } });
This listener basically follows the exact same structure as most of the other listeners in android.
Yep. The annotation should probably be named
@FocusChange, to follow the other AA conventions.
@mathieuboniface what do you think ?Hey, i'm back :)
Yes, I agree with @pyricau, I think that we should use
@FocusChangeThe code spec looks good to me. We just need to see what could be the generated code.
I'm making some refactoring, which can allow usage of this feature.
Good news :) 👍
This should be documented and closed.
Is there a way to contribute to the wiki ?Wiki updated
The only is to have admin role :)
Currently there is no support for one of the most common events, onFocusChange, does not appear to exist at this moment. Is there anything structurally unusual about this call that was reasoned for this not to be included, or has there just not been a demand for this particular feature so far?
If there are not obvious roadblocks I may work on an implementation of this shortly, unless someone more familiar with the project feels up to the task.