Support Gradle incremental annotation processing #2193

Activity

1. WonderCsabo

   added

   Enhancement

   on Feb 15, 2019
2. smaugho commented on Feb 20, 2019

   

   smaugho

   on Feb 20, 2019

   Contributor

   More actions

   @WonderCsabo just checking the code in the PrefHandler I found this:

   Set<? extends Element> sharedPrefElements = getEnvironment().getValidatedElements().getRootAnnotatedElements(SharedPref.class.getName());
   for (Element sharedPrefElement : sharedPrefElements) {
   	GeneratedClassHolder sharedPrefHolder = getEnvironment().getGeneratedClassHolder(sharedPrefElement);
   	String sharedPrefName = sharedPrefHolder.getGeneratedClass().name();
   
   	if (elementTypeName.equals(sharedPrefName)) {
   		prefClass = sharedPrefHolder.getGeneratedClass();
   		break;
   	}
   }

   This code assumes that all the @SharedPref annotated classes are being processed in the environment. This would be no that different that what we were talking on #1520. This should break with incremental compilations, since there is no guarantee that the @SharedPref annotated classes would be processed when using incremental compilation.
3. WonderCsabo commented on Feb 20, 2019

   

   WonderCsabo

   on Feb 20, 2019

   MemberAuthor

   More actions

   We have to check it. The docs says we can access the elements in the annotated elements AST, but i am not sure we will reach it trought the validated elements, maybe we have to do otherwise.
4. ihorb10 commented on Oct 19, 2019

   

   ihorb10

   on Oct 19, 2019

   More actions

   Hi! Was wondering if you're planning to add support this?
5. WonderCsabo commented on Oct 21, 2019

   

   WonderCsabo

   on Oct 21, 2019

   MemberAuthor

   More actions

   We are planning, yes. ;) Contributions are very much welcome.

   👍React with 👍1Reacted by Manuel Schmitzberger
6. WonderCsabo

   closed this as completedon Mar 30, 2020