You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Feb 26, 2023. It is now read-only.
Repository navigation
This repository was archived by the owner on Feb 26, 2023. It is now read-only.
Logging broken when first argument is an element #2145
Instead of using the first (and in this case desired version) the compiler uses the second version of trace as the first parameter after the message is an Element adn so it is not usedas replacement for the {} the log message but the message (without a valuefor {}) is attached to the element.
I think we should review all places where we use these logs and possibly even refactor the logger to avoid similar issues. maybe move the element in front of the string parameter?
trace is only called twice. both times it is not intended to attach the message to the element. I'll remove that 3-arg version of trace at it imho makes no sense to have it (can we actually have trace messages on elements?!)
While working on #2143 I found that for some places the logging might be broken.
e.g.
androidannotations/AndroidAnnotations/androidannotations-core/androidannotations/src/main/java/org/androidannotations/internal/process/ModelProcessor.java
Line 203 in 074df63
results in the message:
This happens as the signatures of the trace methods are
Instead of using the first (and in this case desired version) the compiler uses the second version of
traceas the first parameter after the message is anElementadn so it is not usedas replacement for the{}the log message but the message (without a valuefor{}) is attached to the element.I think we should review all places where we use these logs and possibly even refactor the logger to avoid similar issues. maybe move the
elementin front of the string parameter?@WonderCsabo wdyt?