Repository navigation
Scopes for @Rest #207
Description
Activity
When would be the good time to configure a singleton scoped
@Restservice ?I'll explain a little bit more. :)
I think the current best "workaround" is to have an singleton scoped@EBeanthat wraps the@Restclass. The@EBeancan configure the RestTemplate once, when it's initialized.
If you have a Singleton scoped@Restclass, you don't know if it has been initialized or not when you come to use it. That's why I asked "when" to configure it.Hum. You're definitely right, I hadn't thought about this.
In general, you won't get to use it before all the beans have been injected. So you could configure it in one of the beans
@AfterInjectmethod. However, this isn't a really good solution. When looking at the interface, you will have hard times finding where it is configured. So I guess we'd need to specify a "Configurator" bean on the Rest interface ?Yep, that would be a lot better, I think we agree that the code which uses the
@Restservice shouldn't have to worry about the configuration anyway.Are we considering this for 2.7? I'm not sure of the complexity but I would like to give a hand to get this in as we are using it.
Still open if you want to give a hand :) . We're going to release 2.7 before Devoxx.
I'm not exactly sure how we will solve this though.
Singleton client would be indeed useful. It is very bad we have to set the common headers after each injection etc.
The
@Restgenerated implementation rely on a RestTemplate instance. Currently, each injection of an@Restannotated interface leads to the creation of a new instance of the class implementing this interface.Users can customize the RestTemplate instance, but they have to do it on a per implementation instance bases, which isn't great. This also leads to the creation of a lost of RestTemplate instance.
We could either :
@Restimplementations be singletons. But there might be cases where one need different configurations and thefore different instances@EBeanhas a default on prototype, maybe we should emphasize coherenceBy the way, this isn't totally related, but maybe we should create an interface with
setRestTemplate()andgetRestTemplate()methods, and let@Restclients implement it, rather then defining the methods in the interface ?