Skip to content
This repository was archived by the owner on Feb 26, 2023. It is now read-only.
This repository was archived by the owner on Feb 26, 2023. It is now read-only.

viewDestroyed_ should default to true #1942

Description

@tidbeck

I think it make more sens to default viewDestroyed_ to true. This avoids methods annotated with @IgnoreWhen(IgnoreWhen.State.VIEW_DESTROYED) to be called before the fragment has been created/recreated.

AndroidAnnotations version:
4.2.0

Android compile SDK version:
25

Annotated code:

@IgnoreWhen(IgnoreWhen.State.VIEW_DESTROYED)

Expected generated code:

private volatile boolean viewDestroyed_ = true;

Actual generated code:

private volatile boolean viewDestroyed_;

Activity

  1. dodgex commented on Jan 26, 2017

    @dodgex
    Member

    I think this is a valid request. @WonderCsabo wdyt?

  2. WonderCsabo commented on Jan 26, 2017

    @WonderCsabo
    Member

    I agree. @tidbeck want to contribute this fix?

  3. tidbeck commented on Jan 27, 2017

    @tidbeck
    Author

    @WonderCsabo sure I will give it a try.

  4. added this to the 4.3 milestone on Jan 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions