Repository navigation
@FocusChange and @EditorAction #1767
Description
Problem description
If @FocusChange annotation is used altogether with @EditorAction annotation on the same text view(or any TextView subclass), project fails to compile because of the code generated by Android Annotations.
Version of the AA: 4.0.0
Example & Explanation
Annotate methods like this:
@FocusChange(R.id.edit_text)
protected void onFocusChange() {
...
}
@EditorAction(R.id.edit_text)
protected void onEditorAction() {
...
}
...and the compilation fails because of the generated code which looks like this:
@Override
public void onViewChanged(HasViews hasViews) {
View view_edit_text = hasViews.findViewById(R.id.edit_text);
if (view_edit_text!= null) {
view_edit_text.setOnFocusChangeListener(new OnFocusChangeListener() {
@Override
public void onFocusChange(View view, boolean hasFocus) {
MainActivity_.this.onFocusChange();
}
}
);
view_edit_text.setOnEditorActionListener(new OnEditorActionListener() {
@Override
public boolean onEditorAction(TextView textView, int actionId, KeyEvent event) {
MainActivity_.this.onEditorAction();
return true;
}
}
);
}
}
As you can see view_edit_text variable is typed as an instance of View class, which of course does not have the setOnEditorActionListener method and therefore the generated code could not be compiled.
Workaround
I found a workaround how to get a compilable piece of code: inject the EditText using @ViewById(R.id.edit_text) annotation and the generated code is now compilable because in the generated code, there's the injected field used to call methods on, which has a correct type.
Inject EditText(or any TextView or it's subclass):
@ViewById(R.id.edit_text)
protected EditText mEditText;
Now the generated code looks like this:
@Override
public void onViewChanged(HasViews hasViews) {
this.mEditText = ((EditText) hasViews.findViewById(R.id.edit_text));
if (this.mEditText!= null) {
this.mEditText.setOnFocusChangeListener(new OnFocusChangeListener() {
@Override
public void onFocusChange(View view, boolean hasFocus) {
MainActivity_.this.onFocusChange();
}
}
);
this.mEditText.setOnEditorActionListener(new OnEditorActionListener() {
@Override
public boolean onEditorAction(TextView textView, int actionId, KeyEvent event) {
MainActivity_.this.onEditorAction();
return true;
}
}
);
}
}
Expected solution
Generate compilable code:
- Either make the
view_edit_texthave a correct type
TextView view_edit_text = (TextView) hasViews.findViewById(R.id.edit_text);
- Or cast it to correct type when calling the
setOnEditorActionListenermethod
((TextView)view_edit_text).setOnEditorActionListener(...);
Activity
WonderCsabo commentedon May 11, 2016
Nice bug report. Wanna contribute this fix?
dodgex commentedon May 12, 2016
@WonderCsabo shouldn't it be enough to put the
@EditorActionhandler before the@FocusChangehandler? i bet the@EditorActionone retrives the view asTextViewso it should work?WonderCsabo commentedon May 12, 2016
That may fix this specific issue. However i guess the ultimate fix would be casting to the target type of the listener if needed.
branoh commentedon May 12, 2016
I think that moving
@EditorActionhandler before@FocusChangehandler would be good enough. I like that it would make the code look a little bit cleaner by having the right type directly from the variable declaration.I also agree that ultimate fix would be to always cast it to a correct type. However, if a cast would happen on every method call, there might be a number of unnecessary casting(and downcasting as well e.g. from
TextViewtoView), which makes the code look a little bit ugly.If a cast would happen only when necessary that would be fine, although I still like the idea of having correct type directly from the variable declaration.
WonderCsabo commentedon May 12, 2016
@branoh wanna contribute either of these fixes?
branoh commentedon May 12, 2016
@WonderCsabo I can try but I'm not very familiar with AA code structure, so it'll probably take me some time to fix it.