Skip to content
This repository was archived by the owner on Feb 26, 2023. It is now read-only.
This repository was archived by the owner on Feb 26, 2023. It is now read-only.

AA generates call to ContextCompat.getColor even if it does not exist #1665

Description

@WonderCsabo

If the support-v4 is on the classpath, but an older version of the library is used and the ContextCompat.getColor() method is not available, AA still generates a call to it, hence creating a compilation error.

Activity

  1. dodgex commented on Dec 20, 2015

    @dodgex
    Member

    iirc we decided to assume that the user should have the latest support-v4 dependency?

  2. WonderCsabo commented on Dec 20, 2015

    @WonderCsabo
    MemberAuthor

    I do not remember. :S

  3. dodgex commented on Dec 20, 2015

    @dodgex
    Member

    looks like i'm wrong? #1424

  4. WonderCsabo commented on Dec 20, 2015

    @WonderCsabo
    MemberAuthor

    But i remember that in some point, we handled that the user can have an older version of support library. At least we handle that in the Activity options.

  5. dodgex commented on Dec 20, 2015

    @dodgex
    Member

    also, have you tried AA 4.0? there we have a ContextAwareResHandler that is used for ColorRes

  6. WonderCsabo commented on Dec 20, 2015

    @WonderCsabo
    MemberAuthor

    Yes, i tried AA 4.0.

  7. WonderCsabo commented on Dec 20, 2015

    @WonderCsabo
    MemberAuthor

    So the problem here that we handle that case if the whole ContextCompat class is missing, but we do not handle the case when ContextCompat is present but lacks the method we want to call.

  8. dodgex commented on Dec 20, 2015

    @dodgex
    Member

    ah, thats possible yeah

  9. self-assigned this
    on Dec 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions