HowItWorks and OnActivityResult Document Improvement

Hi~~
When I used startForResult method, I didn't know that exist OnActivityResult Annotation. So I implemented all override method.

I think that HowItWorks page will give this annotation info, many people will use this.

So I change documentation HowItWorks page like this link.

After

Also OnActivityResult page gave example like this.

@OnActivityResult(REQUEST_CODE)
void onResult(int resultCode, Intent data, @Extra String value) {
}

But it didn't work. So I change this @Extra -> @OnActivityResult.Extra

@OnActivityResult(REQUEST_CODE)
void onResult(int resultCode, Intent data, @OnActivityResult.Extra String value) {
}

And I found @Extrain javadoc. And I update OnActivityResult.Extra in javadoc.
Could i ask you may i create new pull request?

In the wiki, I would use this: Note that you can use the @OnActivityResult annotation...

Sure, submit the pull request, please. I would change the commit message though, because you are not adding, but refining the JavaDoc.

Oh i'm sorry...
I know that .. but i copied and pasted your commit message.. i missed it

And I modified wiki page like this :
Note that you can use the @OnActivityResult annotation to get result code and extra value.

I squashed two of your commits, so you may have to hard reset your wiki repo instead of merging:

git fetch upstream
git reset upstream/master --hard

But if you have changes do not do that, commit them and rebase your branch to upstream/master.

Thanks for these fixes to our doc, it really needs concern. Keep it up! :)

Navigation Menu