Skip to content
This repository was archived by the owner on Feb 26, 2023. It is now read-only.
This repository was archived by the owner on Feb 26, 2023. It is now read-only.

Use better algorith to find AndroidManifest.xml #1478

Description

@WonderCsabo

AndroidManifestFinder tries to find the file, but it still only knows the old Eclipse project structure, where the xml was in the project root. Now, most projects use a different structure.

Gradle:
Dummy file: ./build/generated/source/apt{/flavor}{/buildtype}/**
Manifest: ./src/main/AndroidManifest.xml or *./build/manifests/full{/flavor}{/buildtype}/AndroidManifest.xml or ./build/bundles{/flavor}{/buildtype}/AndroidManifest.xml*

Maven:
Dummy file: ./target/generated-sources/**
Manifest: ./src/main/AndroidManifest.xml (better would be the merged manifest in target, but that is not always present at the time of processing)

Eclipse:
Dummy file: ./apt_generated/**
Manifest: ./AndroidManifest.xml

Instead of the current behavior, we should try to match regex patterns according to the paths above. Then we can easily calculate the manifest path after we know the project root folder found by the regex.
If this algorithm fails to find the manifest, users can still explicitly specify it via the androidManifestFile processing option.

Activity

  1. self-assigned this
    on Jun 24, 2015
  2. changed the title [-]Use better algorith to file AndroidManifest.xml[/-] [+]Use better algorith to find AndroidManifest.xml[/+] on Sep 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions