Remove view annotation support from EBean #1477

Activity

1. WonderCsabo

   added

   Task

   on Jun 23, 2015
2. LouisCAD commented on Sep 9, 2015

   

   LouisCAD

   on Sep 9, 2015

   More actions

   Only if You add it for RecyclerView ViewHolders.

   How I use @ViewById for my RecyclerViews now

   @EBean
   public static class MyViewHolder extends RecyclerView.ViewHolder implements HasViews {
   
       @ViewById
       TextView titleTV, descTV;
   
       @ViewById
       ImageView icon;
   
       private static ViewGroup tmpParent;
   
       public static MyViewHolder newInstance(ViewGroup parent) {
           tmpParent = parent;
           MyViewHolder newHolder = MyViewHolder_.getInstance_(parent.getContext());
           tmpParent = null;
           return newHolder;
       }
   
       protected MyViewHolder(Context context) {
           super(LayoutInflater.from(context).inflate(R.layout.my_list_item, tmpParent, false));
           ((OnViewChangedListener) this).onViewChanged(this);
       }
   
       @Override
       public View findViewById(int id) {
           return itemView.findViewById(id);
       }
   }

   It's a little ugly, but it's less boilerplate than standard implementation, so please, don't remove EBan view annotations if you don't provide a @EViewHolder annotation, with the ability to tell AA when to findViewsById on itemView
3. dodgex commented on Sep 9, 2015

   

   dodgex

   on Sep 9, 2015

   Member

   More actions

   @LouisCO you should either refactor your code to this approach or you can use my slightly improved version where in my case the TrackView is a @EViewGroup that can use @ViewById for its childs.
4. LouisCAD commented on Sep 9, 2015

   

   LouisCAD

   on Sep 9, 2015

   More actions

   @dodgex your version isn't very straighforward for thos wanting to add @ViewById and implies boilerplate for each project anyway... Why don't you provide a modified RecyclerViewAdapterBase with abstract getItem(int position) in place of the ArrayList, and your ViewVrapper in AA? Also, I think a usage example of using @EViewGroup in the doc would help developers to use the good approach
5. WonderCsabo

   modified the milestone: 4.0 on Oct 28, 2015
6. gauravsak commented on Dec 30, 2016

   

   gauravsak

   on Dec 30, 2016

   More actions

   @WonderCsabo If this issue is resolved, could you please mark it closed? Thanks!
7. WonderCsabo

   closed this as completedon Dec 30, 2016