Skip to content
This repository was archived by the owner on Feb 26, 2023. It is now read-only.
This repository was archived by the owner on Feb 26, 2023. It is now read-only.

@WindowFeature and support library #1464

Description

@camillebeaumont

The @WindowFeature annotation create requestWindowFeature(x) in the init_() function even if the activity use the support library (instead of using supportRequestWindowFeature(x))

Activity

  1. WonderCsabo commented on Jun 10, 2015

    @WonderCsabo
    Member

    Good catch! Wanna contribute?

  2. camillebeaumont commented on Jun 10, 2015

    @camillebeaumont
    Author

    Ok why not. I Find out how to do it.
    However, I have an issue. supportRequestWindowFeature is from ActionBarActivity and not from FragmentActivity and unfortunately there is no appcompat-v7 library on Maven central, only the v4 support library. So I can't make a
    Any clues ?

  3. WonderCsabo commented on Jun 10, 2015

    @WonderCsabo
    Member

    This is not a problem at all. It means we cannot test it in the functional test, but we can in the compile-time test (by adding a fake ActionBarActivity). You can generate arbitrary code. :) Check out this test, which adds Fragment to the classpath. The added classes must be in src/test/resources, like this.

    If you have further questions, do not hesitate to ask..

  4. WonderCsabo commented on Jun 10, 2015

    @WonderCsabo
    Member

    BTW, you also have to check AppCompatActivity, since ActionBarActivity is deprecated, and the former took it's place.

  5. camillebeaumont commented on Jun 10, 2015

    @camillebeaumont
    Author

    Yes, of course ! I think of this minute ;)

  6. WonderCsabo commented on Jun 15, 2015

    @WonderCsabo
    Member

    @camillebeaumont did you manage to make progress on this one?

  7. WonderCsabo commented on Sep 12, 2015

    @WonderCsabo
    Member

    Implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions