This repository was archived by the owner on Feb 26, 2023. It is now read-only.
Repository navigation
This repository was archived by the owner on Feb 26, 2023. It is now read-only.
Allow subclasses as parameters #1285
Description
Activity
I don't understand the comment and how it can help. Could you write an example ?
Of course:
// old way @Click void myButtonClicked(View view) { Button myButton = (Button) view; // do sg with myButton } // new way @Click void myButtonClicked(Button view) { // do sg with view }
So it removes the need of casting as
@ViewByIddoes.OK. How do we validate that the given view(s) have the right class ? And do we do when it is not the case ?
What do you mean the right class? We cannot know what is the actual type of the object, this is the responsibility of the client. Just like with
@ViewById.You're right, it will just fail at runtime. I'm totally ok with that so.
This is blocked by #1284.
- added a commit that references this issue
on May 5, 2015 No longer blocked.
This is now implemented for the most event binding annotations. If you need it for the rest, please open a new issue.
Here #1162 (comment) @dodgex suggested to allow the subclass as a parameter. I think it would be very convenient to allow this for other listener annotations and other parameters.
@yDelouis WDTY? If it is a good idea we should review all params of all listener annotations and decide where it makes sense to allow subclass as param type.