@ReceiverAction should allow for multiple values #1232

Activity

1. WonderCsabo commented on Nov 11, 2014

   

   WonderCsabo

   on Nov 11, 2014

   Member

   More actions

   Yep, @Receiver already supports multiple actions, @ReceiverAction should do the same.

   @dodgex WDYT?
2. WonderCsabo

   added

   Enhancement

   ContributionWelcome

   on Nov 11, 2014
3. dodgex commented on Nov 11, 2014

   

   dodgex

   on Nov 11, 2014

   Member

   More actions

   yeah, makes sense.

   i wonder if there is a good reason why the generated class is like

   public final class MusicIntentReceiver_
       extends MusicIntentReceiver
   {
   
       private Context context_;
       public final static String ACTION_ON_MEDIA_BUTTON = "android.intent.action.MEDIA_BUTTON";
       public final static String ANDROID_INTENT_EXTRA_KEYEVENT_EXTRA = "android.intent.extra.KEY_EVENT";
       @Override
       public void onReceive(Context context, Intent intent) {
           context_ = context;
           super.onReceive(context, intent);
           String action = intent.getAction();
           String dataScheme = intent.getScheme();
           if (ACTION_ON_MEDIA_BUTTON.equals(action)) {
               Bundle extras_ = ((intent.getExtras()!= null)?intent.getExtras():new Bundle());
               KeyEvent keyEvent = extras_.getParcelable(ANDROID_INTENT_EXTRA_KEYEVENT_EXTRA);
               MusicIntentReceiver_.this.onMediaButton(context, keyEvent);
               return ;
           }
       }
   }

   instead of

   public final class MusicIntentReceiver_
       extends MusicIntentReceiver
   {
   
       private Context context_;
   
       @Override
       public void onReceive(Context context, Intent intent) {
           context_ = context;
           super.onReceive(context, intent);
           String action = intent.getAction();
           String dataScheme = intent.getScheme();
           if ("android.intent.action.MEDIA_BUTTON".equals(action)) {
               Bundle extras_ = ((intent.getExtras()!= null)?intent.getExtras():new Bundle());
               KeyEvent keyEvent = extras_.getParcelable("android.intent.extra.KEY_EVENT");
               MusicIntentReceiver_.this.onMediaButton(context, keyEvent);
               return ;
           }
       }
   }

   i mean: why add public final static fields if the string could be used directly?
4. WonderCsabo commented on Nov 11, 2014

   

   WonderCsabo

   on Nov 11, 2014

   Member

   More actions

   Because it is a good coding practice? We also do this in other places, for example @Extra.
5. dodgex commented on Nov 11, 2014

   

   dodgex

   on Nov 11, 2014

   Member

   More actions

   okay. i think we can implement the action the same way i did for dataSchemes...

   there we get

   public final static String ACTION_ON_MEDIA_BUTTONX =  "android.intent.action.MEDIA_BUTTON";
   public final static List<String> DATA_SCHEMES_ON_MEDIA_BUTTONX = Arrays.asList("x");
   
   if (ACTION_ON_MEDIA_BUTTONX.equals(action)&&DATA_SCHEMES_ON_MEDIA_BUTTONX.contains(dataScheme)) {
     // stuff
   }

   the new code would be like

   public final static List<String>ACTION_ON_MEDIA_BUTTONX = Arrays.asList("android.intent.action.MEDIA_BUTTON");
   public final static List<String> DATA_SCHEMES_ON_MEDIA_BUTTONX = Arrays.asList("x");
   
   if (ACTION_ON_MEDIA_BUTTONX.contains(action)&&DATA_SCHEMES_ON_MEDIA_BUTTONX.contains(dataScheme)) {
     // stuff
   }
6. WonderCsabo commented on Nov 11, 2014

   

   WonderCsabo

   on Nov 11, 2014

   Member

   More actions

   Yeah, that can work. @yDelouis do you agree?
7. yDelouis commented on Nov 11, 2014

   

   yDelouis

   on Nov 11, 2014

   Contributor

   More actions

   Sure.
8. WonderCsabo commented on Nov 11, 2014

   

   WonderCsabo

   on Nov 11, 2014

   Member

   More actions

   Guys, feel free to contribute the feature.
9. dodgex commented on Nov 11, 2014

   

   dodgex

   on Nov 11, 2014

   Member

   More actions

   @yDelouis ok. already working on it. and i'll add a little optimization to not create a list for only 1 item.
10. WonderCsabo

    closed this as completedon Nov 20, 2014
11. WonderCsabo

    removed

    ContributionWelcome

    on Nov 20, 2014