Repository navigation
None-AA Annotations with parameters referencing AA-generated classes are not copied correctly #1211
Description
Activity
BTW, can you provide a reduced test-case project to reproduce this defect?
I'll try
I don't get it. I try to create a test case using AA 3.1 . But may test annotation is not copied to generated class at all. Are there any extra preconditions for annotation-copy to take place?
P.S.
Oh sry, I'm an idiot. I took org.androidannotations as base package for test case, that's why :)Here is a test case https://www.dropbox.com/s/evt13rk6s7f60pg/test_case.tar.gz
Great test project! However i prefer pushing these test projects to GitHub, so they can be easily browsed without downloading etc. (this is just for the future).
OK, unfortunately i cannot debug this in eclipse, because eclipse can actually build the test project... But made some debug logs and built with terminal. Unfortunately there is no remedy, we cannot read the .class argument if it is not present in the classpath (not generated, yet).
#402 could help us with this.
@chpasha did you manage to work on this?
not yet, sry. I'm not sure that I'm up to this task anyway, my knowledge of the AA-codebase is almost non-existent.
@chpasha no worries, i created a PR. Can you test it?
I am closing this one for now, since we implemented the workaround. The real solution would be much harder to do, since it needs an architectural change.
I have a custom annotation with parameters , one of them refers to another AA-Generated class. This parameter is not copied to generated class correctly (maybe since the AA-class is generated before the referred AA-class). In the end the Annotation looks like
@MyAnnotation(param = "error")which obviously breaks the codeas discussed in #982, the ideal solution would be to copy such annotations correctly. If it is not possible, maybe the fall-back solution could be used which consists in skipping annotations marked with
@Inheritedsince they are still discoverable in runtime when using generated class.