Repository navigation
Compilation fails for methods annotated with @ServiceAction that have the same name as one of their parameters #1070
Description
Activity
- changed the title
[-]Compilation fails for methods annotated with @ServiceAction that have the same name as one of their parameter[/-][+]Compilation fails for methods annotated with @ServiceAction that have the same name as one of their parameters[/+]on Jul 17, 2014 Actually naming a method as the same as the parameter is not a really good practice. I do not think we should make our code more complex by preparing it for this edge case.
@WonderCsabo, I disagree with you. My problem here is not what's best practice, but the fact that the current implementation pollutes
IntentBuilders namespace with names of the parameters to the methods. This example fails compilation with the same message as well:@ServiceAction public void foo(int bar) { /* Do something... */ } /* other actions... */ @ServiceAction public void bar(int foo) { /* Do completely unrelated thing... */ }
The error is misleading. In my code, I only defined one
foo(...)and onebar(...), not two of them. The fact that each self-contained method's parameter naming scheme leaking into the generated class is my real problem here. You're imposing a method and parameter naming scheme in my project for me.OK, sorry, i see your point now. @yDelouis you contributed this feature, what do you think?
I agree with @kutsal. We shouldn't add the parameter as an extra to the
IntentBuilder. (Even if it is added as an extra in theIntentunderneath).
Generally, I think an annotation should do one thing and only one. If the developer wants to pass an extra without the action, he still can with@Extra.Agreed. Can you post a PR to remove the extra methods so the service action method calls
super.extra()directly?I will I soon as I have enough time.
I think it is rather a defect than a task. :(
@yDelouis can you resolve this?
Fixed.
Given an
@EIntentServicelike so:Compilation fails annotation processing with the following error, which is misleading:
error: method foo(Object) is already defined in class IntentBuilder_This is because the generated code in
FooIntentService_.javahas this bit (see comments in code block):And when the parameter name is changed, the
Extrais properly passed.Since the
@EIntentServiceusage is defined as:I think having public accessors for the
Extras generated from the parameters of the annotated methods is unnecessary. They only pollute theIntentBuilder_s namespace since they'll never be used directly.I think a better way to do this would be, in this case, to make those
Extras private, and use a different naming scheme while generating them so they won't collide with the annotated methods...Or, maybe changing the usage to something like the following is better?
so those
Extramethods handling the parameters would make sense.Either of those, or
@ServiceActionannotation's processor might warn users when it's placed on a method that has a parameter name the same as its name.