Skip to content
This repository was archived by the owner on Feb 26, 2023. It is now read-only.
This repository was archived by the owner on Feb 26, 2023. It is now read-only.

extend @HttpsClient to support resName (library project) #1028

Description

@toshe

related: #20, #306

We tried creating a custom HttpClient in our library project. BTW today is 5th June - check out https://www.resetthenet.org/ - makes you want to secure all your apps :)

@HttpsClient(trustStore=R.raw.mycacerts,
        trustStorePwd="changeit2")
    HttpClient httpsClient;

Using the latest 3.1 SNAPSHOT we cannot compile because the Resource is in a library project and since resources in library projects are not final static we cannot specify our truststore directly as a resource (in this case R.raw.mycacerts).

https://github.com/excilys/androidannotations/wiki/Library-projects#referencing-ids-by-name suggests referencing the resources by resName, however that is mostly possible for layouts but not for Annotations such as @HttpsClient. Can we please add a support for resName as well? resName would reference the truststore and/or the keystore resources.

Activity

  1. DayS commented on Jun 8, 2014

    @DayS
    Contributor

    You're right. This have to be fixed quickly. Thanks for noticing it

  2. added this to the 3.1 milestone on Jun 8, 2014
  3. DayS commented on Jun 8, 2014

    @DayS
    Contributor

    I'm on it

  4. self-assigned this
    on Jun 8, 2014
  5. DayS commented on Jun 8, 2014

    @DayS
    Contributor

    Merged. You can use this by using the snapshot in your project

  6. toshe commented on Jun 15, 2014

    @toshe
    ContributorAuthor

    Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions