Skip to content
This repository was archived by the owner on Feb 26, 2023. It is now read-only.

Commit 466b9fe

Browse files
yDelouisyDelouis
committed
Merge pull request #1544 from WonderCsabo/1501_fixSeekBarDoubledFindViewByIdCalls
Remove duplicated findViewById() calls with @SeekBarXXX
2 parents 877a31d + cf5ae3c commit 466b9fe

1 file changed

Lines changed: 2 additions & 4 deletions

File tree

‎AndroidAnnotations/androidannotations-core/androidannotations/src/main/java/org/androidannotations/holder/EComponentWithViewSupportHolder.java‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -278,10 +278,8 @@ private OnSeekBarChangeListenerHolder createOnSeekBarChangeListenerHolder(JField
278278
JDefinedClass onSeekbarChangeListenerClass = getCodeModel().anonymousClass(getClasses().ON_SEEKBAR_CHANGE_LISTENER);
279279
JClass viewClass = getClasses().SEEKBAR;
280280

281-
JBlock onViewChangedBody = getOnViewChangedBody().block();
282-
JVar viewVariable = onViewChangedBody.decl(FINAL, viewClass, "view", cast(viewClass, findViewById(idRef)));
283-
onViewChangedBody._if(viewVariable.ne(JExpr._null()))._then() //
284-
.invoke(viewVariable, "setOnSeekBarChangeListener").arg(_new(onSeekbarChangeListenerClass));
281+
FoundViewHolder foundViewHolder = getFoundViewHolder(idRef, viewClass);
282+
foundViewHolder.getIfNotNullBlock().invoke(foundViewHolder.getRef(), "setOnSeekBarChangeListener").arg(_new(onSeekbarChangeListenerClass));
285283

286284
return new OnSeekBarChangeListenerHolder(this, onSeekbarChangeListenerClass);
287285
}

0 commit comments

Comments
 (0)