unable to write HTML report in Node.JS 14.x #16

Activity

1. PixnBits commented on May 14, 2020

   

   PixnBits

   on May 14, 2020

   ContributorAuthor

   More actions

   fixing this is as easy as adding .toString() to htmlOutput
   https://github.com/americanexpress/amex-jest-preset/blob/master/html-report-creator.js#L95

   writeFile(process.env.JEST_TEST_REPORT_PATH || path.join(process.cwd(), 'test-results/test-report.html'), htmlOutput.toString());

   but I wonder if, especialy for large test suites, memory could be conserved by streaming instead
   https://github.com/oozcitak/xmlbuilder-js/wiki#xml-writers
   Is there any reason fs.writeFileSync was used? (Does jest require synchronous behavior?)
   

   amex-jest-preset/html-report-creator.js

   Lines 24 to 27 in 64d7d93

   	const writeFile = (filePath, content) => {
   	mkdirp.sync(path.dirname(filePath));
   	fs.writeFileSync(filePath, content);
   	};

   👍React with 👍1Reacted by Anish Kumar Singh
2. anescobar1991 commented on May 15, 2020

   

   anescobar1991

   on May 15, 2020

   Member

   More actions

   Yes https://jestjs.io/docs/en/configuration.html#testresultsprocessor-string must be synchronous unfortunately.

   @PixnBits would you mind opening a PR to fix this?

   👍React with 👍1Reacted by Nick Oliver
3. JamesSingleton

   closed this as completedin #17on May 22, 2020
4. JamesSingleton

   added a commit that references this issue on May 22, 2020

   feat(node): update to work with node 14 (#17)

   ...

   This issue will close once commit ad8663a is merged into the 'main' branch.

   ad8663a
5. oneamexbot

   added a commit that references this issue on May 26, 2020

   chore(release): 6.1.0 [skip ci]

   ...

   eb7c44e
6. oneamexbot commented on May 26, 2020

   

   oneamexbot

   on May 26, 2020

   Contributor

   More actions

   🎉 This issue has been resolved in version 6.1.0 🎉

   The release is available on:

   • npm package (@latest dist-tag)
   • GitHub release

   Your semantic-release bot 📦🚀
7. oneamexbot

   added

   released

   on May 26, 2020