Skip to content

Commit 5a1afc9

Browse files
WonderCsaboWonderCsabo
committed
Fix valid types of @PreferenceChange newValue param
Set<String> is supported instead of Set.
1 parent dc8302b commit 5a1afc9

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

‎AndroidAnnotations/androidannotations-api/src/main/java/org/androidannotations/annotations/PreferenceChange.java‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,9 +41,9 @@
4141
* <ul>
4242
* <li>A {@link android.preference.Preference Preference} parameter to know
4343
* which preference was targeted by this event</li>
44-
* <li>An {@link Object} or {@link java.util.Set Set of strings} or
45-
* {@link Boolean} or {@link String} to obtain the new value of the
46-
* {@link android.preference.Preference Preference}</li>
44+
* <li>An {@link Object}, {@link String}, {@link java.util.Set Set of strings}
45+
* and also a {@link Boolean} or <code>boolean</code> to obtain the new value of
46+
* the {@link android.preference.Preference Preference}</li>
4747
* </ul>
4848
* <blockquote>
4949
*

‎AndroidAnnotations/androidannotations/src/main/java/org/androidannotations/helper/ValidatorParameterHelper.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ public class ValidatorParameterHelper {
3636

3737
private static final List<String> ANDROID_SHERLOCK_MENU_ITEM_QUALIFIED_NAMES = asList(CanonicalNameConstants.MENU_ITEM, CanonicalNameConstants.SHERLOCK_MENU_ITEM);
3838
private static final List<String> EDITOR_ACTION_ALLOWED_PARAMETER_TYPES = asList(CanonicalNameConstants.TEXT_VIEW, CanonicalNameConstants.INTEGER, "int", CanonicalNameConstants.KEY_EVENT);
39-
private static final List<String> PREFERENCE_CHANGE_ALLOWED_NEWVALUE_PARAM = asList(CanonicalNameConstants.OBJECT, CanonicalNameConstants.SET, CanonicalNameConstants.STRING, CanonicalNameConstants.BOOLEAN);
39+
private static final List<String> PREFERENCE_CHANGE_ALLOWED_NEWVALUE_PARAM = asList(CanonicalNameConstants.OBJECT, CanonicalNameConstants.STRING_SET, CanonicalNameConstants.STRING, CanonicalNameConstants.BOOLEAN);
4040

4141
protected final TargetAnnotationHelper annotationHelper;
4242

0 commit comments

Comments
 (0)