Skip to content

Commit 13c7897

Browse files
author
Mark Pollack
committed
interop-python-server: reconnect-then-load now passes (client falls back to the connection on a 404 session stream)
1 parent e9f0b24 commit 13c7897

1 file changed

Lines changed: 3 additions & 19 deletions

File tree

‎integration-testing/configs/interop-python-server.json‎

Lines changed: 3 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -64,29 +64,13 @@
6464
]
6565
},
6666
"checks": [
67-
"client RESULT pass == 10",
68-
"client RESULT fail == 2",
67+
"client RESULT pass == 12",
68+
"client RESULT fail == 0",
6969
"client RESULT prompt1_updates >= 2",
7070
"client RESULT prompt2_updates >= 2",
7171
"client RESULT prompt3_permission_updates >= 2",
7272
"client RESULT prompt_after_load_updates >= 2"
73-
],
74-
"expectedFailures": [
75-
{
76-
"process": "client",
77-
"step": "reconnect-session/load",
78-
"contains": "404",
79-
"reason": "RFD contradiction, not a Java bug: the Java client follows the reconnect diagram and pre-opens the session GET before session/load on the new connection; the Python server follows the rule that an Acp-Session-Id unknown to the connection is a 404",
80-
"see": "RFD streamable-http-websocket-transport: the reconnect sequence opens the session GET before session/load, while the server rules say an unknown Acp-Session-Id returns 404; the Python server follows the latter"
81-
},
82-
{
83-
"process": "client",
84-
"step": "reconnect-prompt",
85-
"contains": "404",
86-
"reason": "follows from reconnect-session/load: the session was never attached to the new connection",
87-
"see": "RFD streamable-http-websocket-transport: the reconnect sequence opens the session GET before session/load, while the server rules say an unknown Acp-Session-Id returns 404; the Python server follows the latter"
88-
}
8973
]
9074
},
91-
"comment": "Reconnect-then-load is an EXPECTED failure (RFD contradiction, not a Java bug); if the Python server starts accepting it the scenario fails so the expectation gets updated."
75+
"comment": "Reconnect-then-load passes against the Python server since fe7567a: when a server answers the session-stream GET with 404 (as Python does for a session unknown to the connection), the Java client posts session/load on the connection without Acp-Session-Id. The RFD still contradicts itself here (reconnect diagram vs the unknown-session 404 rule)."
9276
}

0 commit comments

Comments
 (0)