Skip to content

Remove script-generated measurements. #680

Closed

Description

@joedolson

Describe the bug

Able Player currently does a lot of internal math to know it's own sizing and set various widths and heights in pixels. For the most part, with modern CSS, these shouldn't be necessary. They can also cause some problems, such as cited in #675.

It may take a while, but I should remove as many of these as possible - preferably all of them.

Activity

  1. added this to the 4.8 milestone on Sep 5, 2025
  2. added theissue type on Sep 5, 2025
  3. joedolson commented on Dec 31, 2025

    @joedolson
    MemberAuthor

    Removed some additional JS sizing in 3b5ef73

  4. joedolson commented on Jan 7, 2026

    @joedolson
    MemberAuthor

    I think that the only remaining JS sizing is functionally necessary. There isn't a lot left. I'm going to close this issue; any additional follow-ups can be handled as independent issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions