You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Italics/Bold tags cause unwanted transcript line breaks in data-lyrics-mode #591
This definitely isn't intentional.
Probably it was missed because the demos don't use data-lyrics-mode, e.g. this one where bolding is just fine with that mode off.
For this little WebVTT excerpt: data-lyrics-mode produces this:
With that mode off things are fine:
I'll issue a PR which I've tested in my development environment with said sample.
It fixes the problem in data-lyrics-mode:
...and seems to not cause issues with that mode off, either:
The preceding line break was caused by a lack of conditional on the addition of the trailing line break here.
The following line break was caused by the space element added to the array here. This doesn't seem to do anything?
Activity
Fix unwanted lines in lyrics mode
joedolson commentedon Jul 24, 2025
Fixed by @conorom, added by eb3ae78