Skip to content

Commit f704b3c

Browse files
mathieubonifacemathieuboniface
committed
My last 2 cents
1 parent 701da52 commit f704b3c

3 files changed

Lines changed: 3 additions & 7 deletions

File tree

‎AndroidAnnotations/androidannotations-api/src/main/java/com/googlecode/androidannotations/annotations/OnActivityResult.java‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,6 @@
4949
* <pre>
5050
* &#064;OnActivityResult(<b>REQUEST_CODE</b>)
5151
* void onResult(int resultCode, Intent data) {
52-
* // Something Here
5352
* }
5453
* </pre>
5554
*
@@ -58,7 +57,6 @@
5857
* <pre>
5958
* &#064;OnActivityResult(<b>REQUEST_CODE</b>)
6059
* void onResult(int resultCode) {
61-
* // Something Here
6260
* }
6361
* </pre>
6462
*
@@ -67,7 +65,6 @@
6765
* <pre>
6866
* &#064;OnActivityResult(<b>ANOTHER_REQUEST_CODE</b>)
6967
* void onResult(Intent data) {
70-
* // Something Here
7168
* }
7269
* </pre>
7370
*
@@ -76,7 +73,6 @@
7673
* <pre>
7774
* &#064;OnActivityResult(<b>ANOTHER_REQUEST_CODE</b>)
7875
* void onResult() {
79-
* // Something Here
8076
* }
8177
* </pre>
8278
*

‎AndroidAnnotations/androidannotations/src/main/java/com/googlecode/androidannotations/processing/EBeanHolder.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ public class EBeanHolder {
9191
/**
9292
* OnActivityResult byResultCode
9393
*/
94-
public HashMap<Integer, JCase> onActivityResultCases = new HashMap<Integer, JCase>();
94+
public final HashMap<Integer, JCase> onActivityResultCases = new HashMap<Integer, JCase>();
9595

9696
public JSwitch onActivityResultSwitch;
9797
public JMethod onActivityResultMethod;

‎AndroidAnnotations/androidannotations/src/main/java/com/googlecode/androidannotations/validation/OnActivityResultValidator.java‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,12 +68,12 @@ public boolean validate(Element element, AnnotationElements validatedElements) {
6868
ExecutableElement executableElement = (ExecutableElement) element;
6969
validatorHelper.returnTypeIsVoid(executableElement, valid);
7070

71-
haveOnResultMethodParameters(executableElement, valid);
71+
hasOnResultMethodParameters(executableElement, valid);
7272

7373
return valid.isValid();
7474
}
7575

76-
private void haveOnResultMethodParameters(ExecutableElement executableElement, IsValid valid) {
76+
private void hasOnResultMethodParameters(ExecutableElement executableElement, IsValid valid) {
7777
List<? extends VariableElement> parameters = executableElement.getParameters();
7878
boolean resultCodeParameterFound = false;
7979
boolean intentParameterFound = false;

0 commit comments

Comments
 (0)