Error when used with VSCode and Teroshdl #24

Activity

1. whitequark

   added

   bug

   on Oct 5, 2021
2. whitequark commented on Oct 5, 2021

   

   whitequark

   on Oct 5, 2021

   Last edited by whitequark

   Member

   More actions

   Okay, there are several separate issues here:

   • First, absolute paths currently don't work on Windows. I haven't used TerosHDL but check if you can get it to pass relative paths to YoWASP. (This is still a bug in YoWASP, just one that might not be trivial to address.)
   • Second, there's infinite recursion in shutil.rmtree (called from tempfile.TemporaryDirectory destructor) that happens only when the first issue is triggered. This is Python bug #35144, fixed in bpo-29982: Add "ignore_cleanup_errors" param to tempfile.TemporaryDirectory() python/cpython#24793 (not in a release yet).
3. BharathS11 commented on Oct 7, 2021

   

   BharathS11

   on Oct 7, 2021

   Author

   More actions

   Hi, Thanks for responding. TerosHDL developers updated the tool to use relative path
   The following commands work

   yowasp-yosys -p "read_verilog -sv dsp\rtl\dsp_xcc_v2.v; proc; opt; write_json .teroshdl_yosys_output.json; stat"
   yowasp-yosys -p "read_verilog -sv .\dsp\rtl\dsp_xcc_v2.v; proc; opt; write_json .teroshdl_yosys_output.json; stat" 
   

   but this is what TerosHDL calls and doesn't work
   yowasp-yosys -p "read_verilog -sv ..\..\..\Documents\Projects\test\frontend\dsp\rtl\dsp_xcc_v2.v; proc; opt; write_json C:\Users\bhara\.teroshdl_yosys_output.json; stat"

   I think the doubles quotes cause the issue.
4. whitequark commented on Oct 7, 2021

   

   whitequark

   on Oct 7, 2021

   Member

   More actions

   Can you ask TerosHDL developers to contact me directly regarding this issue? (In this GitHub issue, by email, whichever is more convenient.) Then we can work something out.
5. whitequark commented on Oct 7, 2021

   

   whitequark

   on Oct 7, 2021

   Member

   More actions

   In commit 4ae03d9 I've changed the path handling so that on Windows, absolute and relative paths with any components would work. (It also improves relative path handling on *nix.) Note that on Windows, paths must be delimited by forward slashes, /, rather than backward slashes, \\; this is due to the way WASI implements path handling.

   You can install YoWASP Yosys built from this commit with:

   pip install -i https://test.pypi.org/simple/ yowasp-yosys==0.9.post5623.dev232
   
6. whitequark commented on Oct 31, 2021

   

   whitequark

   on Oct 31, 2021

   Member

   More actions

   @BharathS11 Can you please confirm whether you were able to get the updated package to work?
7. whitequark commented on Feb 6, 2023

   

   whitequark

   on Feb 6, 2023

   Member

   More actions

   yowasp-yosys -p "read_verilog -sv ..\..\..\Documents\Projects\test\frontend\dsp\rtl\dsp_xcc_v2.v; proc; opt; write_json C:\Users\bhara\.teroshdl_yosys_output.json; stat"

   Both of these paths should work since commit 4ae03d9, closing. Please comment if there are still any issues.
8. whitequark

   closed this as completedon Feb 6, 2023
9. qarlosalberto commented on May 20, 2024

   

   qarlosalberto

   on May 20, 2024

   More actions

   I'm improving the support for yowasp-yosys in TerosHDL. Currently, is it possible to use absolute paths in Windows and Linux? Thanks.
10. whitequark commented on May 20, 2024

    

    whitequark

    on May 20, 2024

    Member

    More actions

    Sure. You have to use / instead of \ though.
11. qarlosalberto commented on May 20, 2024

    

    qarlosalberto

    on May 20, 2024

    Last edited by qarlosalberto

    More actions

    Great!!

    I'm doing some tests. This command works fine:

    yowasp-yosys -p 'read_verilog -sv /home/carlos/repo/vscode-terosHDL/packages/colibri/tests/yosys/helpers/verilog/mylib/counter_logic.v; read_verilog -sv /home/carlos/repo/vscode-terosHDL/packages/colibri/tests/yosys/helpers/verilog/counter_top.v; ; hierarchy -top counter_top; proc; ; write_json /home/carlos/hola.json; stat'
    

    But not this command:

    yowasp-yosys -p 'read_verilog -sv /home/carlos/repo/vscode-terosHDL/packages/colibri/tests/yosys/helpers/verilog/mylib/counter_logic.v; read_verilog -sv /home/carlos/repo/vscode-terosHDL/packages/colibri/tests/yosys/helpers/verilog/counter_top.v; ; hierarchy -top counter_top; proc; ; write_json /tmp/hola.json; stat'
    

    There aren't errors. But in the second command yowasp-yosys doesn't create the file /tmp/hola.json. I am doing something wrong?
12. whitequark commented on May 20, 2024

    

    whitequark

    on May 20, 2024

    Member

    More actions

    The /tmp subtree is internally mounted to a temporary directory created just for this purpose, as it is unconditionally used by Yosys for e.g. running abc. The /tmp directory is hardcoded in wasi-libc sources so you'll need to pick a different temporary location.

    The same is true of /share, for different reasons.
13. qarlosalberto commented on May 20, 2024

    

    qarlosalberto

    on May 20, 2024

    More actions

    Ahh okok, thanks!! I will choose other path.