Skip to content

Commit d4169aa

Browse files
cdumezcdumez
committed
Reduce use of const char*
https://bugs.webkit.org/show_bug.cgi?id=273024 Reviewed by Geoffrey Garen. Reduce use of `const char*` by leveraging ASCIILiteral and std::span. * Source/JavaScriptCore/API/tests/CompareAndSwapTest.cpp: (testCompareAndSwap): * Source/JavaScriptCore/API/tests/ExecutionTimeLimitTest.cpp: (testExecutionTimeLimit): * Source/JavaScriptCore/API/tests/testapi.cpp: (testCAPIViaCpp): * Source/JavaScriptCore/API/tests/testapi.mm: (parallelPromiseResolveTest): * Source/JavaScriptCore/assembler/testmasm.cpp: * Source/JavaScriptCore/b3/B3CanonicalizePrePostIncrements.cpp: (JSC::B3::canonicalizePrePostIncrements): * Source/JavaScriptCore/b3/B3Compile.cpp: (JSC::B3::compile): * Source/JavaScriptCore/b3/B3DuplicateTails.cpp: (JSC::B3::duplicateTails): * Source/JavaScriptCore/b3/B3EliminateCommonSubexpressions.cpp: (JSC::B3::eliminateCommonSubexpressions): * Source/JavaScriptCore/b3/B3EliminateDeadCode.cpp: (JSC::B3::eliminateDeadCode): * Source/JavaScriptCore/b3/B3FixSSA.cpp: (JSC::B3::fixSSA): * Source/JavaScriptCore/b3/B3FoldPathConstants.cpp: (JSC::B3::foldPathConstants): * Source/JavaScriptCore/b3/B3Generate.cpp: (JSC::B3::prepareForGeneration): (JSC::B3::generateToAir): * Source/JavaScriptCore/b3/B3HoistLoopInvariantValues.cpp: (JSC::B3::hoistLoopInvariantValues): * Source/JavaScriptCore/b3/B3InferSwitches.cpp: (JSC::B3::inferSwitches): * Source/JavaScriptCore/b3/B3LegalizeMemoryOffsets.cpp: (JSC::B3::legalizeMemoryOffsets): * Source/JavaScriptCore/b3/B3LowerMacros.cpp: (JSC::B3::lowerMacros): * Source/JavaScriptCore/b3/B3LowerMacrosAfterOptimizations.cpp: (JSC::B3::lowerMacrosAfterOptimizations): * Source/JavaScriptCore/b3/B3LowerToAir.cpp: (JSC::B3::lowerToAir): * Source/JavaScriptCore/b3/B3MoveConstants.cpp: (JSC::B3::moveConstants): * Source/JavaScriptCore/b3/B3OptimizeAssociativeExpressionTrees.cpp: (JSC::B3::optimizeAssociativeExpressionTrees): * Source/JavaScriptCore/b3/B3PhaseScope.cpp: (JSC::B3::PhaseScope::PhaseScope): * Source/JavaScriptCore/b3/B3PhaseScope.h: * Source/JavaScriptCore/b3/B3PureCSE.cpp: (JSC::B3::pureCSE): * Source/JavaScriptCore/b3/B3ReduceDoubleToFloat.cpp: (JSC::B3::reduceDoubleToFloat): * Source/JavaScriptCore/b3/B3ReduceStrength.cpp: (JSC::B3::reduceStrength): * Source/JavaScriptCore/b3/B3VariableLiveness.cpp: (JSC::B3::VariableLiveness::VariableLiveness): * Source/JavaScriptCore/b3/air/AirAllocateRegistersAndStackAndGenerateCode.cpp: (JSC::B3::Air::GenerateAndAllocateRegisters::generate): * Source/JavaScriptCore/b3/air/AirAllocateRegistersAndStackByLinearScan.cpp: (JSC::B3::Air::allocateRegistersAndStackByLinearScan): * Source/JavaScriptCore/b3/air/AirAllocateRegistersByGraphColoring.cpp: (JSC::B3::Air::allocateRegistersByGraphColoring): * Source/JavaScriptCore/b3/air/AirAllocateStackByGraphColoring.cpp: (JSC::B3::Air::allocateStackByGraphColoring): * Source/JavaScriptCore/b3/air/AirEliminateDeadCode.cpp: (JSC::B3::Air::eliminateDeadCode): * Source/JavaScriptCore/b3/air/AirFixObviousSpills.cpp: (JSC::B3::Air::fixObviousSpills): * Source/JavaScriptCore/b3/air/AirFixPartialRegisterStalls.cpp: (JSC::B3::Air::fixPartialRegisterStalls): * Source/JavaScriptCore/b3/air/AirGenerate.cpp: (JSC::B3::Air::prepareForGeneration): (JSC::B3::Air::generateWithAlreadyAllocatedRegisters): * Source/JavaScriptCore/b3/air/AirLiveness.h: (JSC::B3::Air::Liveness::Liveness): * Source/JavaScriptCore/b3/air/AirLowerAfterRegAlloc.cpp: (JSC::B3::Air::lowerAfterRegAlloc): * Source/JavaScriptCore/b3/air/AirLowerEntrySwitch.cpp: (JSC::B3::Air::lowerEntrySwitch): * Source/JavaScriptCore/b3/air/AirLowerMacros.cpp: (JSC::B3::Air::lowerMacros): * Source/JavaScriptCore/b3/air/AirLowerStackArgs.cpp: (JSC::B3::Air::lowerStackArgs): * Source/JavaScriptCore/b3/air/AirOptimizeBlockOrder.cpp: (JSC::B3::Air::optimizeBlockOrder): * Source/JavaScriptCore/b3/air/AirOptimizePairedLoadStore.cpp: (JSC::B3::Air::optimizePairedLoadStore): * Source/JavaScriptCore/b3/air/AirPhaseScope.cpp: (JSC::B3::Air::PhaseScope::PhaseScope): * Source/JavaScriptCore/b3/air/AirPhaseScope.h: * Source/JavaScriptCore/b3/air/AirReportUsedRegisters.cpp: (JSC::B3::Air::reportUsedRegisters): * Source/JavaScriptCore/b3/air/AirSimplifyCFG.cpp: (JSC::B3::Air::simplifyCFG): * Source/JavaScriptCore/b3/air/testair.cpp: * Source/JavaScriptCore/b3/testb3_1.cpp: (run): * Source/JavaScriptCore/bytecode/CodeBlockHash.cpp: (JSC::CodeBlockHash::CodeBlockHash): (JSC::CodeBlockHash::dump const): * Source/JavaScriptCore/bytecode/CodeBlockHash.h: * Source/JavaScriptCore/bytecode/SuperSampler.cpp: (JSC::initializeSuperSampler): * Source/JavaScriptCore/dfg/DFGArgumentsEliminationPhase.cpp: * Source/JavaScriptCore/dfg/DFGBackwardsPropagationPhase.cpp: (JSC::DFG::BackwardsPropagationPhase::BackwardsPropagationPhase): * Source/JavaScriptCore/dfg/DFGCFAPhase.cpp: (JSC::DFG::CFAPhase::CFAPhase): * Source/JavaScriptCore/dfg/DFGCFGSimplificationPhase.cpp: (JSC::DFG::CFGSimplificationPhase::CFGSimplificationPhase): * Source/JavaScriptCore/dfg/DFGCPSRethreadingPhase.cpp: (JSC::DFG::CPSRethreadingPhase::CPSRethreadingPhase): * Source/JavaScriptCore/dfg/DFGCSEPhase.cpp: * Source/JavaScriptCore/dfg/DFGCleanUpPhase.cpp: (JSC::DFG::CleanUpPhase::CleanUpPhase): * Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp: (JSC::DFG::ConstantFoldingPhase::ConstantFoldingPhase): * Source/JavaScriptCore/dfg/DFGConstantHoistingPhase.cpp: * Source/JavaScriptCore/dfg/DFGCriticalEdgeBreakingPhase.cpp: (JSC::DFG::CriticalEdgeBreakingPhase::CriticalEdgeBreakingPhase): * Source/JavaScriptCore/dfg/DFGDCEPhase.cpp: (JSC::DFG::DCEPhase::DCEPhase): * Source/JavaScriptCore/dfg/DFGFixupPhase.cpp: (JSC::DFG::FixupPhase::FixupPhase): * Source/JavaScriptCore/dfg/DFGIntegerCheckCombiningPhase.cpp: (JSC::DFG::IntegerCheckCombiningPhase::IntegerCheckCombiningPhase): * Source/JavaScriptCore/dfg/DFGIntegerRangeOptimizationPhase.cpp: * Source/JavaScriptCore/dfg/DFGInvalidationPointInjectionPhase.cpp: (JSC::DFG::InvalidationPointInjectionPhase::InvalidationPointInjectionPhase): * Source/JavaScriptCore/dfg/DFGLICMPhase.cpp: (JSC::DFG::LICMPhase::LICMPhase): * Source/JavaScriptCore/dfg/DFGLivenessAnalysisPhase.cpp: * Source/JavaScriptCore/dfg/DFGLoopPreHeaderCreationPhase.cpp: (JSC::DFG::LoopPreHeaderCreationPhase::LoopPreHeaderCreationPhase): * Source/JavaScriptCore/dfg/DFGMovHintRemovalPhase.cpp: * Source/JavaScriptCore/dfg/DFGOSRAvailabilityAnalysisPhase.cpp: (JSC::DFG::OSRAvailabilityAnalysisPhase::OSRAvailabilityAnalysisPhase): * Source/JavaScriptCore/dfg/DFGOSREntrypointCreationPhase.cpp: (JSC::DFG::OSREntrypointCreationPhase::OSREntrypointCreationPhase): * Source/JavaScriptCore/dfg/DFGObjectAllocationSinkingPhase.cpp: * Source/JavaScriptCore/dfg/DFGPhantomInsertionPhase.cpp: * Source/JavaScriptCore/dfg/DFGPhase.h: (JSC::DFG::Phase::Phase): (JSC::DFG::Phase::name const): (JSC::DFG::runAndLog): * Source/JavaScriptCore/dfg/DFGPlan.cpp: (JSC::DFG::Plan::compileInThreadImpl): * Source/JavaScriptCore/dfg/DFGPredictionInjectionPhase.cpp: (JSC::DFG::PredictionInjectionPhase::PredictionInjectionPhase): * Source/JavaScriptCore/dfg/DFGPredictionPropagationPhase.cpp: * Source/JavaScriptCore/dfg/DFGPutStackSinkingPhase.cpp: * Source/JavaScriptCore/dfg/DFGSSAConversionPhase.cpp: (JSC::DFG::SSAConversionPhase::SSAConversionPhase): * Source/JavaScriptCore/dfg/DFGSSALoweringPhase.cpp: (JSC::DFG::SSALoweringPhase::SSALoweringPhase): * Source/JavaScriptCore/dfg/DFGStackLayoutPhase.cpp: (JSC::DFG::StackLayoutPhase::StackLayoutPhase): * Source/JavaScriptCore/dfg/DFGStaticExecutionCountEstimationPhase.cpp: (JSC::DFG::StaticExecutionCountEstimationPhase::StaticExecutionCountEstimationPhase): * Source/JavaScriptCore/dfg/DFGStoreBarrierClusteringPhase.cpp: * Source/JavaScriptCore/dfg/DFGStoreBarrierInsertionPhase.cpp: * Source/JavaScriptCore/dfg/DFGStrengthReductionPhase.cpp: (JSC::DFG::StrengthReductionPhase::StrengthReductionPhase): * Source/JavaScriptCore/dfg/DFGTierUpCheckInjectionPhase.cpp: (JSC::DFG::TierUpCheckInjectionPhase::TierUpCheckInjectionPhase): * Source/JavaScriptCore/dfg/DFGTypeCheckHoistingPhase.cpp: (JSC::DFG::TypeCheckHoistingPhase::TypeCheckHoistingPhase): * Source/JavaScriptCore/dfg/DFGUnificationPhase.cpp: (JSC::DFG::UnificationPhase::UnificationPhase): * Source/JavaScriptCore/dfg/DFGValidateUnlinked.cpp: * Source/JavaScriptCore/dfg/DFGValueRepReductionPhase.cpp: (JSC::DFG::ValueRepReductionPhase::ValueRepReductionPhase): * Source/JavaScriptCore/dfg/DFGVarargsForwardingPhase.cpp: * Source/JavaScriptCore/dfg/DFGVirtualRegisterAllocationPhase.cpp: (JSC::DFG::VirtualRegisterAllocationPhase::VirtualRegisterAllocationPhase): * Source/JavaScriptCore/disassembler/Disassembler.cpp: * Source/JavaScriptCore/heap/Heap.cpp: (JSC::Heap::beginMarking): (JSC::Heap::snapshotUnswept): (JSC::Heap::addCoreConstraints): (JSC::Heap::notifyIsSafeToCollect): * Source/JavaScriptCore/inspector/remote/socket/RemoteInspectorSocketEndpoint.cpp: (Inspector::RemoteInspectorSocketEndpoint::RemoteInspectorSocketEndpoint): * Source/JavaScriptCore/jit/ICStats.cpp: (JSC::ICStats::ICStats): * Source/JavaScriptCore/jsc.cpp: (JSC_DEFINE_HOST_FUNCTION): (startMemoryMonitoringThreadIfNeeded): (startTimeoutTimer): * Source/JavaScriptCore/runtime/SamplingProfiler.cpp: (JSC::SamplingProfiler::createThreadIfNecessary): * Source/JavaScriptCore/tools/CompilerTimingScope.cpp: (JSC::CompilerTimingScope::CompilerTimingScope): * Source/JavaScriptCore/tools/CompilerTimingScope.h: * Source/JavaScriptCore/wasm/WasmBBQJIT.cpp: (JSC::Wasm::parseAndCompileBBQ): * Source/JavaScriptCore/wasm/WasmOMGIRGenerator.cpp: (JSC::Wasm::parseAndCompileOMG): * Source/WTF/benchmarks/LockFairnessTest.cpp: * Source/WTF/benchmarks/LockSpeedTest.cpp: * Source/WTF/wtf/CrossThreadTaskHandler.cpp: (WTF::CrossThreadTaskHandler::CrossThreadTaskHandler): * Source/WTF/wtf/CrossThreadTaskHandler.h: * Source/WTF/wtf/JSONValues.cpp: * Source/WTF/wtf/ParallelJobsGeneric.cpp: (WTF::ParallelEnvironment::ThreadPrivate::tryLockFor): * Source/WTF/wtf/PrintStream.h: (WTF::printInternal): * Source/WTF/wtf/RunLoop.cpp: (WTF::RunLoop::create): * Source/WTF/wtf/RunLoop.h: * Source/WTF/wtf/SixCharacterHash.cpp: (WTF::sixCharacterHashStringToInteger): (WTF::integerToSixCharacterHashString): * Source/WTF/wtf/SixCharacterHash.h: * Source/WTF/wtf/StackShotProfiler.h: (WTF::StackShotProfiler::StackShotProfiler): * Source/WTF/wtf/StringHashDumpContext.h: (WTF::StringHashDumpContext::getID): * Source/WTF/wtf/Threading.cpp: (WTF::Thread::NewThreadContext::NewThreadContext): (WTF::Thread::create): * Source/WTF/wtf/Threading.h: * Source/WTF/wtf/TimingScope.cpp: (WTF::TimingScope::scopeDidEnd): * Source/WTF/wtf/TimingScope.h: (WTF::TimingScope::TimingScope): * Source/WTF/wtf/WorkQueue.cpp: (WTF::ConcurrentWorkQueue::apply): * Source/WTF/wtf/glib/RunLoopGLib.cpp: (WTF::RunLoop::TimerBase::setName): * Source/WebCore/Modules/webaudio/AsyncAudioDecoder.cpp: (WebCore::AsyncAudioDecoder::AsyncAudioDecoder): * Source/WebCore/Modules/webaudio/AudioWorkletThread.cpp: (WebCore::AudioWorkletThread::createThread): * Source/WebCore/Modules/webaudio/OfflineAudioDestinationNode.cpp: (WebCore::OfflineAudioDestinationNode::startRendering): * Source/WebCore/Modules/webdatabase/DatabaseThread.cpp: (WebCore::DatabaseThread::start): * Source/WebCore/bindings/js/GCController.cpp: (WebCore::GCController::garbageCollectOnAlternateThreadForDebugging): * Source/WebCore/bindings/js/IDBBindingUtilities.cpp: (WebCore::callOnIDBSerializationThreadAndWait): * Source/WebCore/fileapi/AsyncFileStream.cpp: (WebCore::callOnFileThread): * Source/WebCore/page/ResourceUsageThread.cpp: (WebCore::ResourceUsageThread::createThreadIfNeeded): * Source/WebCore/platform/audio/HRTFDatabaseLoader.cpp: (WebCore::HRTFDatabaseLoader::loadAsynchronously): * Source/WebCore/platform/audio/ReverbConvolver.cpp: (WebCore::ReverbConvolver::ReverbConvolver): * Source/WebCore/platform/audio/gstreamer/AudioFileReaderGStreamer.cpp: (WebCore::createBusFromInMemoryAudioFile): * Source/WebCore/platform/mock/MockRealtimeVideoSource.cpp: (WebCore::takePhotoRunLoop): * Source/WebCore/platform/network/curl/CurlRequestScheduler.cpp: (WebCore::CurlRequestScheduler::startOrWakeUpThread): * Source/WebCore/platform/network/curl/CurlStreamScheduler.cpp: (WebCore::CurlStreamScheduler::startThreadIfNeeded): * Source/WebCore/testing/MockLibWebRTCPeerConnection.cpp: (WebCore::MockLibWebRTCPeerConnection::~MockLibWebRTCPeerConnection): * Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.cpp: (WebKit::remoteGraphicsContextGLStreamWorkQueue): * Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp: (WebKit::RemoteRenderingBackend::RemoteRenderingBackend): * Source/WebKit/GPUProcess/graphics/WebGPU/RemoteGPU.cpp: (WebKit::RemoteGPU::RemoteGPU): * Source/WebKit/NetworkProcess/cache/NetworkCacheIOChannelGLib.cpp: (WebKit::NetworkCache::IOChannel::read): (WebKit::NetworkCache::IOChannel::write): * Source/WebKit/Platform/IPC/StreamConnectionWorkQueue.cpp: (IPC::StreamConnectionWorkQueue::StreamConnectionWorkQueue): * Source/WebKit/Platform/IPC/StreamConnectionWorkQueue.h: * Source/WebKit/Platform/IPC/unix/ConnectionUnix.cpp: (IPC::Connection::platformOpen): * Source/WebKit/Shared/IPCStreamTester.cpp: (WebKit::IPCStreamTester::IPCStreamTester): * Source/WebKit/UIProcess/XR/ios/PlatformXRARKit.mm: (WebKit::ARKitCoordinator::startSession): * Source/WebKit/UIProcess/glib/DisplayVBlankMonitor.cpp: (WebKit::DisplayVBlankMonitor::startThreadIfNeeded): * Source/WebKit/UIProcess/linux/MemoryPressureMonitor.cpp: (WebKit::MemoryPressureMonitor::start): * Source/WebKit/WebProcess/GPU/media/RemoteAudioDestinationProxy.cpp: (WebKit::RemoteAudioDestinationProxy::startRenderingThread): * Source/WebKit/WebProcess/GPU/webrtc/AudioMediaStreamTrackRendererInternalUnitManager.cpp: (WebKit::AudioMediaStreamTrackRendererInternalUnitManager::Proxy::startThread): * Source/WebKit/WebProcess/Plugins/PDF/PDFIncrementalLoader.mm: (WebKit::PDFIncrementalLoader::PDFIncrementalLoader): * Source/WebKit/WebProcess/cocoa/RemoteCaptureSampleManager.cpp: (WebKit::RemoteCaptureSampleManager::RemoteAudio::startThread): * Source/WebKitLegacy/Storage/StorageThread.cpp: (WebCore::StorageThread::start): * Tools/DumpRenderTree/JavaScriptThreading.cpp: (runJavaScriptThread): (startJavaScriptThreads): * Tools/TestWebKitAPI/Tests/IPC/ConnectionTests.cpp: (TestWebKitAPI::ConnectionRunLoopTest::createRunLoop): * Tools/TestWebKitAPI/Tests/IPC/EventTests.cpp: (TestWebKitAPI::EventTestABBA::createRunLoop): * Tools/TestWebKitAPI/Tests/IPC/StreamConnectionTests.cpp: (TestWebKitAPI::StreamConnectionTestBase::setupBase): * Tools/TestWebKitAPI/Tests/IPC/StreamConnectionWorkQueueTests.cpp: (TestWebKitAPI::TEST_F): * Tools/TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp: (testsJSCVirtualMachine): * Tools/TestWebKitAPI/Tests/WTF/CheckedPtr.cpp: (TestWebKitAPI::TEST(WTF_CheckedPtr, CanMakeThreadSafeCheckedPtr)): * Tools/TestWebKitAPI/Tests/WTF/CompletionHandlerTests.cpp: (TestWebKitAPI::TEST_F): (TestWebKitAPI::TEST(CompletionHandlerDeathTest, MAYBE_ASSERT_ENABLED_DEATH_TEST(DefaultHandlerOnThreadAsserts)): (TestWebKitAPI::TEST(CompletionHandlerDeathTest, MAYBE_ASSERT_ENABLED_DEATH_TEST(MainThreadHandlerOnThreadAsserts)): (TestWebKitAPI::TEST(CompletionHandlerDeathTest, MAYBE_ASSERT_ENABLED_DEATH_TEST(ConstructionThreadHandlerOnThreadAsserts)): * Tools/TestWebKitAPI/Tests/WTF/Condition.cpp: * Tools/TestWebKitAPI/Tests/WTF/Lock.cpp: (TestWebKitAPI::runLockTest): * Tools/TestWebKitAPI/Tests/WTF/ParkingLot.cpp: * Tools/TestWebKitAPI/Tests/WTF/RefPtr.cpp: (TestWebKitAPI::TEST(WTF_RefPtr, ReleaseInNonMainThread)): (TestWebKitAPI::TEST(WTF_RefPtr, ReleaseInNonMainThreadDestroyInMainThread)): * Tools/TestWebKitAPI/Tests/WTF/RunLoop.cpp: (TestWebKitAPI::TEST(WTF_RunLoop, DispatchCrossThreadWhileNested)): (TestWebKitAPI::TEST(WTF_RunLoop, CallOnMainCrossThreadWhileNested)): (TestWebKitAPI::TEST(WTF_RunLoop, ManyTimes)): (TestWebKitAPI::TEST(WTF_RunLoop, ThreadTerminationSelfReferenceCleanup)): (TestWebKitAPI::TEST(WTF_RunLoopDeathTest, MAYBE_ASSERT_ENABLED_DEATH_TEST(CapabilityIsCurrentFailureAsserts)): * Tools/TestWebKitAPI/Tests/WTF/SequenceLockedTest.cpp: (TestWebKitAPI::TEST_F): * Tools/TestWebKitAPI/Tests/WTF/Signals.cpp: (TEST(Signals, SignalsWorkOnExit)): * Tools/TestWebKitAPI/Tests/WTF/ThreadGroup.cpp: (TestWebKitAPI::testThreadGroup): (TestWebKitAPI::TEST(WTF, ThreadGroupDoNotAddDeadThread)): (TestWebKitAPI::TEST(WTF, ThreadGroupAddDuplicateThreads)): (TestWebKitAPI::TEST(WTF, ThreadGroupRemove)): * Tools/TestWebKitAPI/Tests/WTF/ThreadMessages.cpp: (runThreadMessageTest): * Tools/TestWebKitAPI/Tests/WTF/Threading.cpp: (TestWebKitAPI::TEST(WTF, ThreadingThreadIdentity)): * Tools/TestWebKitAPI/Tests/WTF/bmalloc/IsoHeap.cpp: (TEST(bmalloc, IsoHeapMultipleThreads)): (TEST(bmalloc, IsoHeapIsoTLSLeak)): (TEST(bmalloc, IsoHeapMultipleThreadsWhileIterating)): * Tools/TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp: (TestWebKitAPI::TEST(AbortableTaskQueue, AsyncTasks)): (TestWebKitAPI::TEST(AbortableTaskQueue, SyncTasks)): (TestWebKitAPI::TEST(AbortableTaskQueue, Abort)): (TestWebKitAPI::TEST(AbortableTaskQueue, AbortBeforeSyncTaskRun)): (TestWebKitAPI::TEST(AbortableTaskQueue, AbortedBySyncTaskHandler)): * Tools/TestWebKitAPI/Tests/WebCore/CARingBufferTest.cpp: (TestWebKitAPI::TEST_F): * Tools/TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm: ((URLSchemeHandler, Threads)): * Tools/WebKitTestRunner/InjectedBundle/AccessibilityController.cpp: (WTR::AXThread::createThreadIfNeeded): Canonical link: https://commits.webkit.org/277785@main
1 parent fb52644 commit d4169aa

284 files changed

Lines changed: 417 additions & 408 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎Source/JavaScriptCore/API/tests/CompareAndSwapTest.cpp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ void testCompareAndSwap()
107107
data[i].bitmap = &bitmap;
108108
data[i].id = i;
109109
data[i].numThreads = numThreads;
110-
threads[i] = Thread::create("setBitThreadFunc", std::bind(setBitThreadFunc, &data[i]));
110+
threads[i] = Thread::create("setBitThreadFunc"_s, std::bind(setBitThreadFunc, &data[i]));
111111
}
112112

113113
printf("Waiting for %d threads to join\n", numThreads);

‎Source/JavaScriptCore/API/tests/ExecutionTimeLimitTest.cpp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,7 @@ int testExecutionTimeLimit()
194194
exception = nullptr;
195195
JSValueRef* exn = &exception;
196196
shouldTerminateCallbackWasCalled = false;
197-
auto thread = Thread::create("Rogue thread", [=] {
197+
auto thread = Thread::create("Rogue thread"_s, [=] {
198198
JSEvaluateScript(context, script, nullptr, nullptr, 1, exn);
199199
});
200200

‎Source/JavaScriptCore/API/tests/testapi.cpp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -798,7 +798,7 @@ int testCAPIViaCpp(const char* filter)
798798
Vector<Ref<Thread>> threads;
799799
for (unsigned i = filter ? 1 : WTF::numberOfProcessorCores(); i--;) {
800800
threads.append(Thread::create(
801-
"Testapi via C++ thread",
801+
"Testapi via C++ thread"_s,
802802
[&] () {
803803
TestAPI tester;
804804
for (;;) {

‎Source/JavaScriptCore/API/tests/testapi.mm‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1802,7 +1802,7 @@ static void parallelPromiseResolveTest()
18021802
auto* startedThreadPtr = &startedThread;
18031803

18041804
JSValue *promise = [JSValue valueWithNewPromiseInContext:context fromExecutor:^(JSValue *resolve, JSValue *) {
1805-
thread = Thread::create("async thread", ^() {
1805+
thread = Thread::create("async thread"_s, ^() {
18061806
startedThreadPtr->store(true);
18071807
while (!shouldResolveSoonPtr->load()) { }
18081808
[resolve callWithArguments:@[[NSNull null]]];

‎Source/JavaScriptCore/assembler/testmasm.cpp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6274,7 +6274,7 @@ void run(const char* filter) WTF_IGNORES_THREAD_SAFETY_ANALYSIS
62746274
for (unsigned i = filter ? 1 : WTF::numberOfProcessorCores(); i--;) {
62756275
threads.append(
62766276
Thread::create(
6277-
"testmasm thread",
6277+
"testmasm thread"_s,
62786278
[&] () {
62796279
for (;;) {
62806280
RefPtr<SharedTask<void()>> task;

‎Source/JavaScriptCore/b3/B3CanonicalizePrePostIncrements.cpp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ bool canonicalizePrePostIncrements(Procedure& proc)
4646
{
4747
if (!isARM64())
4848
return false;
49-
PhaseScope phaseScope(proc, "canonicalizePrePostIncrements");
49+
PhaseScope phaseScope(proc, "canonicalizePrePostIncrements"_s);
5050
using Arg = Air::Arg;
5151

5252
unsigned index { 0 };

‎Source/JavaScriptCore/b3/B3Compile.cpp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ namespace JSC { namespace B3 {
3838

3939
Compilation compile(Procedure& proc)
4040
{
41-
CompilerTimingScope timingScope("Total B3+Air", "compile");
41+
CompilerTimingScope timingScope("Total B3+Air"_s, "compile"_s);
4242

4343
prepareForGeneration(proc);
4444

‎Source/JavaScriptCore/b3/B3DuplicateTails.cpp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@ class DuplicateTails {
159159

160160
void duplicateTails(Procedure& proc)
161161
{
162-
PhaseScope phaseScope(proc, "duplicateTails");
162+
PhaseScope phaseScope(proc, "duplicateTails"_s);
163163
DuplicateTails duplicateTails(proc);
164164
duplicateTails.run();
165165
}

‎Source/JavaScriptCore/b3/B3EliminateCommonSubexpressions.cpp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -831,7 +831,7 @@ class CSE {
831831

832832
bool eliminateCommonSubexpressions(Procedure& proc)
833833
{
834-
PhaseScope phaseScope(proc, "eliminateCommonSubexpressions");
834+
PhaseScope phaseScope(proc, "eliminateCommonSubexpressions"_s);
835835

836836
CSE cse(proc);
837837
return cse.run();

‎Source/JavaScriptCore/b3/B3EliminateDeadCode.cpp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ bool eliminateDeadCodeImpl(Procedure& proc)
109109

110110
bool eliminateDeadCode(Procedure& proc)
111111
{
112-
PhaseScope phaseScope(proc, "eliminateDeadCode");
112+
PhaseScope phaseScope(proc, "eliminateDeadCode"_s);
113113
return eliminateDeadCodeImpl(proc);
114114
}
115115

0 commit comments

Comments
 (0)