Repository navigation
Commit a516249
committed
[JSC] Remove GCRequest's unused didFinishEndPhase callback
https://bugs.webkit.org/show_bug.cgi?id=325776
rdar://188787440
Reviewed by Marcus Plutowski and Tadeu Zagallo.
A Collector that marks more than one Heap will take collection requests from
each of them, and a request will likely need to say which Heap it comes from: to
decide the scope from that Heap's state, and to let a Heap that goes away drop
its own pending requests. Let's clean up an unused field first.
GCRequest carried a callback for Collector::runEndPhase() to run once the
request was served. Nothing has ever set it: it came with GCRequest in
188598@main (2017), for a WebCore change that never used it. It still shaped how
requests are deduplicated, since GCRequest::subsumedBy() never treated a request
with a callback as covered by a queued one, so any change to what a request
carries would have had to keep that rule. Removing it leaves a request that is
only a scope.
No change in behavior.
* Source/JavaScriptCore/heap/Collector.cpp:
(JSC::Collector::runEndPhase):
* Source/JavaScriptCore/heap/GCRequest.cpp:
(JSC::GCRequest::subsumedBy const):
(JSC::GCRequest::dump const):
* Source/JavaScriptCore/heap/GCRequest.h:
Canonical link: https://commits.webkit.org/322293@main1 parent c572e93 commit a516249
3 files changed
Lines changed: 1 addition & 11 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
591 | 591 | | |
592 | 592 | | |
593 | 593 | | |
594 | | - | |
595 | | - | |
596 | | - | |
597 | 594 | | |
598 | 595 | | |
599 | 596 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | 33 | | |
38 | 34 | | |
39 | 35 | | |
| |||
53 | 49 | | |
54 | 50 | | |
55 | 51 | | |
56 | | - | |
| 52 | + | |
57 | 53 | | |
58 | 54 | | |
59 | 55 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
30 | | - | |
31 | | - | |
32 | 30 | | |
33 | 31 | | |
34 | 32 | | |
| |||
54 | 52 | | |
55 | 53 | | |
56 | 54 | | |
57 | | - | |
58 | 55 | | |
59 | 56 | | |
60 | 57 | | |
| |||
0 commit comments