Skip to content

Commit 92c2fb0

Browse files
committed
Remove use of strcpy from JSC
https://bugs.webkit.org/show_bug.cgi?id=170646 Reviewed by Mark Lam. Replace the use of strcpy with memcpy as strcpy keeps on tripping various analyser warnings even though its trivially safe in this case. Essentially code hygiene, no change in behaviour, no perf impact. * dfg/DFGDisassembler.cpp: (JSC::DFG::Disassembler::dumpDisassembly): Canonical link: https://commits.webkit.org/187594@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@215168 268f45cc-cd09-0410-ab3c-d52691b4dbfc
1 parent d9119c4 commit 92c2fb0

2 files changed

Lines changed: 18 additions & 1 deletion

File tree

‎Source/JavaScriptCore/ChangeLog‎

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,20 @@
1+
2017-04-08 Oliver Hunt <oliver@apple.com>
2+
3+
Remove use of strcpy from JSC
4+
https://bugs.webkit.org/show_bug.cgi?id=170646
5+
6+
Reviewed by Mark Lam.
7+
8+
Replace the use of strcpy with memcpy as strcpy keeps
9+
on tripping various analyser warnings even though its
10+
trivially safe in this case.
11+
12+
Essentially code hygiene, no change in behaviour, no
13+
perf impact.
14+
15+
* dfg/DFGDisassembler.cpp:
16+
(JSC::DFG::Disassembler::dumpDisassembly):
17+
118
2017-04-09 Joseph Pecoraro <pecoraro@apple.com>
219

320
test262: test262/test/annexB/language/expressions/object/__proto__-fn-name.js

‎Source/JavaScriptCore/dfg/DFGDisassembler.cpp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@ void Disassembler::dumpDisassembly(PrintStream& out, const char* prefix, LinkBuf
159159
else
160160
amountOfNodeWhiteSpace = Graph::amountOfNodeWhiteSpace(context);
161161
auto prefixBuffer = std::make_unique<char[]>(prefixLength + amountOfNodeWhiteSpace + 1);
162-
strcpy(prefixBuffer.get(), prefix);
162+
memcpy(prefixBuffer.get(), prefix, prefixLength);
163163
for (int i = 0; i < amountOfNodeWhiteSpace; ++i)
164164
prefixBuffer[i + prefixLength] = ' ';
165165
prefixBuffer[prefixLength + amountOfNodeWhiteSpace] = 0;

0 commit comments

Comments
 (0)