Skip to content

Commit 7025aef

Browse files
colelaoAndrew-Fryer
colelao
authored and
Andrew-Fryer
committed
surpress webkit.RefCntblBaseVirtualDtor warnings for ArrayBufferView
https://bugs.webkit.org/show_bug.cgi?id=296889 rdar://157492341 Reviewed by Yusuke Suzuki. This patch makes ArrayBufferView inherit from the NoVirtualDestructorBase class to surpress the Safer Cpp warnings. * Source/JavaScriptCore/runtime/ArrayBufferView.h: Canonical link: https://commits.webkit.org/298577@main
1 parent 105eb05 commit 7025aef

2 files changed

Lines changed: 2 additions & 3 deletions

File tree

‎Source/JavaScriptCore/SaferCPPExpectations/RefCntblBaseVirtualDtorExpectations‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,6 @@ bytecode/ProxyableAccessCase.h
55
domjit/DOMJITCallDOMGetterSnippet.h
66
jit/GCAwareJITStubRoutine.h
77
jit/PolymorphicCallStubRoutine.h
8-
runtime/DataView.h
9-
runtime/GenericTypedArrayView.h
108
runtime/InferredValue.h
119
wasm/WasmCallee.h
1210
wasm/WasmTable.h

‎Source/JavaScriptCore/runtime/ArrayBufferView.h‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
#include <algorithm>
3131
#include <limits.h>
3232
#include <wtf/CheckedArithmetic.h>
33+
#include <wtf/NoVirtualDestructorBase.h>
3334
#include <wtf/RefCounted.h>
3435
#include <wtf/RefPtr.h>
3536

@@ -41,7 +42,7 @@ class JSArrayBufferView;
4142
class JSGlobalObject;
4243
class CallFrame;
4344

44-
class ArrayBufferView : public RefCounted<ArrayBufferView> {
45+
class ArrayBufferView : public RefCounted<ArrayBufferView>, public NoVirtualDestructorBase {
4546
public:
4647
TypedArrayType getType() const { return m_type; }
4748

0 commit comments

Comments
 (0)