Skip to content

Commit 6830412

Browse files
committed
Builtin internal wrapper implementation files wrap static global initialization code with incorrect guards
https://bugs.webkit.org/show_bug.cgi?id=213792 Reviewed by Youenn Fablet. Streams API hadn't worked since r263700 for AppleWin and WinCairo ports. r263700 removed the unused ENABLE_STREAMS_API. Before r263700, the static global initialization code was wrapped by "ENABLE(WEB_RTC) || ENABLE(STREAMS_API)". After r263700, it was wrapped by "ENABLE(WEB_RTC)". AppleWin and WinCairo doesn't turn on ENABLE_WEB_RTC. So, builtins for Streams API weren't properly initialized for them. * Scripts/tests/builtins/expected/WebCoreJSBuiltins.h-result: Rebaselined. * Scripts/wkbuiltins/builtins_generate_internals_wrapper_implementation.py: (BuiltinsInternalsWrapperImplementationGenerator.generate_initialize_method): Removed calling wrap_with_guard for the value of _generate_initialize_static_globals(). Canonical link: https://commits.webkit.org/226713@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@263885 268f45cc-cd09-0410-ab3c-d52691b4dbfc
1 parent 515c7fe commit 6830412

3 files changed

Lines changed: 22 additions & 4 deletions

File tree

‎Source/JavaScriptCore/ChangeLog‎

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,24 @@
1+
2020-07-03 Fujii Hironori <Hironori.Fujii@sony.com>
2+
3+
Builtin internal wrapper implementation files wrap static global initialization code with incorrect guards
4+
https://bugs.webkit.org/show_bug.cgi?id=213792
5+
6+
Reviewed by Youenn Fablet.
7+
8+
Streams API hadn't worked since r263700 for AppleWin and WinCairo
9+
ports. r263700 removed the unused ENABLE_STREAMS_API.
10+
11+
Before r263700, the static global initialization code was wrapped
12+
by "ENABLE(WEB_RTC) || ENABLE(STREAMS_API)". After r263700, it was
13+
wrapped by "ENABLE(WEB_RTC)". AppleWin and WinCairo doesn't turn
14+
on ENABLE_WEB_RTC. So, builtins for Streams API weren't properly
15+
initialized for them.
16+
17+
* Scripts/tests/builtins/expected/WebCoreJSBuiltins.h-result: Rebaselined.
18+
* Scripts/wkbuiltins/builtins_generate_internals_wrapper_implementation.py:
19+
(BuiltinsInternalsWrapperImplementationGenerator.generate_initialize_method):
20+
Removed calling wrap_with_guard for the value of _generate_initialize_static_globals().
21+
122
2020-07-02 Alex Christensen <achristensen@webkit.org>
223

324
Update Mac CMake build

‎Source/JavaScriptCore/Scripts/tests/builtins/expected/WebCoreJSBuiltins.h-result‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -313,7 +313,6 @@ void JSBuiltinInternalFunctions::initialize(JSDOMGlobalObject& globalObject)
313313
m_xmlCasingTest.init(globalObject);
314314
#endif // ENABLE(TEST_XML_CASTING_TEST_SEPARATE)
315315

316-
#if ENABLE(TEST_GUARDED_INTERNAL_BUILTIN_SEPARATED_A) || ENABLE(TEST_GUARDED_INTERNAL_BUILTIN_SEPARATED_B) || ENABLE(FETCH_API) || ENABLE(TEST_XML_CASTING_TEST_SEPARATE)
317316
JSVMClientData& clientData = *static_cast<JSVMClientData*>(m_vm.clientData);
318317
JSDOMGlobalObject::GlobalPropertyInfo staticGlobals[] = {
319318
#if ENABLE(FETCH_API)
@@ -340,7 +339,6 @@ void JSBuiltinInternalFunctions::initialize(JSDOMGlobalObject& globalObject)
340339
};
341340
globalObject.addStaticGlobals(staticGlobals, WTF_ARRAY_LENGTH(staticGlobals));
342341
UNUSED_PARAM(clientData);
343-
#endif // ENABLE(TEST_GUARDED_INTERNAL_BUILTIN_SEPARATED_A) || ENABLE(TEST_GUARDED_INTERNAL_BUILTIN_SEPARATED_B) || ENABLE(FETCH_API) || ENABLE(TEST_XML_CASTING_TEST_SEPARATE)
344342
}
345343

346344
} // namespace WebCore

‎Source/JavaScriptCore/Scripts/wkbuiltins/builtins_generate_internals_wrapper_implementation.py‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -149,8 +149,7 @@ def generate_initialize_method(self):
149149
lines.append(BuiltinsGenerator.wrap_with_guard(object.annotations.get('conditional'), init))
150150
lines.append("")
151151

152-
guards = set([object.annotations.get('conditional') for object in self.internals if 'conditional' in object.annotations])
153-
lines.append(BuiltinsGenerator.wrap_with_guard(" || ".join(guards), self._generate_initialize_static_globals()))
152+
lines.append(self._generate_initialize_static_globals())
154153

155154
lines.append("}")
156155
return '\n'.join(lines)

0 commit comments

Comments
 (0)