Skip to content

Commit 38c90ef

Browse files
geoffreygarengeoffreygaren
committed
Removed a bunch of unnecessary smart pointers
https://bugs.webkit.org/show_bug.cgi?id=311825 rdar://174416007 Reviewed by Anne van Kesteren. As dicated by (reverse) SaferCPP. A smart pointer is not needed in a NODELETE scope. Canonical link: https://commits.webkit.org/310944@main
1 parent 097ac16 commit 38c90ef

209 files changed

Lines changed: 481 additions & 489 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3250,7 +3250,7 @@ void BytecodeGenerator::emitTDZCheckIfNecessary(const Variable& variable, Regist
32503250

32513251
void BytecodeGenerator::liftTDZCheckIfPossible(const Variable& variable)
32523252
{
3253-
RefPtr<UniquedStringImpl> identifier(variable.ident().impl());
3253+
UniquedStringImpl* identifier = variable.ident().impl();
32543254
for (unsigned i = m_TDZStack.size(); i--;) {
32553255
auto iter = m_TDZStack[i].first.find(identifier);
32563256
if (iter != m_TDZStack[i].first.end()) {

‎Source/JavaScriptCore/jit/JITCode.cpp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -197,7 +197,7 @@ unsigned JITCodeWithCodeRef::offsetOf(void* pointerIntoCode)
197197

198198
size_t JITCodeWithCodeRef::size()
199199
{
200-
if (RefPtr memory = m_executableMemory)
200+
if (auto* memory = m_executableMemory.get())
201201
return memory->sizeInBytes();
202202
return 0;
203203
}

‎Source/WebCore/Modules/async-clipboard/ClipboardItemBindingsDataSource.cpp‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -294,7 +294,7 @@ String ClipboardItemBindingsDataSource::ClipboardItemTypeLoader::dataAsString()
294294
void ClipboardItemBindingsDataSource::ClipboardItemTypeLoader::sanitizeDataIfNeeded()
295295
{
296296
if (m_type == textPlainContentTypeAtom() || m_type == "text/uri-list"_s) {
297-
RefPtr document = documentFromClipboard(RefPtr { m_writingDestination.get() }.get());
297+
RefPtr document = documentFromClipboard(m_writingDestination.get());
298298
if (!document)
299299
return;
300300

@@ -314,7 +314,7 @@ void ClipboardItemBindingsDataSource::ClipboardItemTypeLoader::sanitizeDataIfNee
314314
if (markupToSanitize.isEmpty())
315315
return;
316316

317-
RefPtr document = documentFromClipboard(RefPtr { m_writingDestination.get() }.get());
317+
RefPtr document = documentFromClipboard(m_writingDestination.get());
318318
m_data = { sanitizeMarkup(markupToSanitize, document.get()) };
319319
}
320320

‎Source/WebCore/Modules/indexeddb/IDBDatabase.cpp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -499,7 +499,7 @@ void IDBDatabase::didDeleteIndexInfo(const IDBIndexInfo& info)
499499

500500
std::optional<ScriptExecutionContextIdentifier> IDBDatabase::scriptExecutionContextIdentifier() const
501501
{
502-
if (RefPtr context = scriptExecutionContext())
502+
if (auto* context = scriptExecutionContext())
503503
return context->identifier();
504504

505505
return std::nullopt;

‎Source/WebCore/Modules/mediacontrols/MediaControlsHost.cpp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -347,7 +347,7 @@ bool MediaControlsHost::needsChromeMediaControlsPseudoElement() const
347347
bool MediaControlsHost::isMediaControlsMacInlineSizeSpecsEnabled() const
348348
{
349349
#if HAVE(MATERIAL_HOSTING)
350-
return protect(m_mediaElement)->document().settings().mediaControlsMacInlineSizeSpecsEnabled();
350+
return m_mediaElement->document().settings().mediaControlsMacInlineSizeSpecsEnabled();
351351
#else
352352
return false;
353353
#endif

‎Source/WebCore/Modules/mediasource/SourceBuffer.cpp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1081,7 +1081,7 @@ bool SourceBuffer::validateInitializationSegment(const SourceBufferPrivateClient
10811081
// * The number of audio, video, and text tracks match what was in the first initialization segment.
10821082
return segment.audioTracks.size() == audioTracksIfExists()->length()
10831083
&& segment.videoTracks.size() == videoTracksIfExists()->length()
1084-
&& segment.textTracks.size() == protect(textTracksIfExists())->length();
1084+
&& segment.textTracks.size() == textTracksIfExists()->length();
10851085
}
10861086

10871087
void SourceBuffer::appendError(bool decodeError)

‎Source/WebCore/Modules/mediastream/MediaStream.cpp‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ MediaStream::MediaStream(Document& document, Vector<Ref<MediaStreamTrack>>&& tra
9797
// This constructor preserves MediaStreamTrack instances and must be used by calls originating
9898
// from the JavaScript MediaStream constructor.
9999

100-
for (Ref track : m_tracks)
100+
for (auto& track : m_tracks)
101101
track->setMediaStreamId(id());
102102

103103
setIsActive(m_private->active());
@@ -381,7 +381,7 @@ void MediaStream::characteristicsChanged()
381381
void MediaStream::updateActiveState()
382382
{
383383
bool active = false;
384-
for (Ref track : m_tracks) {
384+
for (auto& track : m_tracks) {
385385
if (!track->ended()) {
386386
active = true;
387387
break;

‎Source/WebCore/Modules/mediastream/PeerConnectionBackend.cpp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,7 @@ PeerConnectionBackend::PeerConnectionBackend(RTCPeerConnection& peerConnection)
179179
#endif
180180
{
181181
#if USE(LIBWEBRTC)
182-
RefPtr document = peerConnection.document();
182+
auto* document = peerConnection.document();
183183
if (auto* page = document ? document->page() : nullptr)
184184
m_shouldFilterICECandidates = page->webRTCProvider().isSupportingMDNS();
185185
#endif

‎Source/WebCore/Modules/streams/ReadableStreamBYOBReader.cpp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,7 @@ void ReadableStreamBYOBReader::genericRelease(JSDOMGlobalObject& globalObject)
189189
m_closedPromise = WTF::move(promise);
190190
}
191191

192-
if (RefPtr controller = stream->controller())
192+
if (auto* controller = stream->controller())
193193
controller->runReleaseSteps();
194194

195195
stream->setByobReader(nullptr);

‎Source/WebCore/Modules/streams/ReadableStreamDefaultReader.cpp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -219,7 +219,7 @@ void ReadableStreamDefaultReader::genericRelease(JSDOMGlobalObject& globalObject
219219
m_closedPromise = WTF::move(promise);
220220
}
221221

222-
if (RefPtr controller = stream->controller())
222+
if (auto* controller = stream->controller())
223223
controller->runReleaseSteps();
224224

225225
stream->setDefaultReader(nullptr);

0 commit comments

Comments
 (0)