Commit 305c822

2016-10-04 Yusuke Suzuki <utatane.tea@gmail.com>

[DOMJIT] Introduce DOMJIT::GetterSetter to tell JIT information

https://bugs.webkit.org/show_bug.cgi?id=162916

Reviewed by Filip Pizlo.

In this patch, we introduce DOMJIT::GetterSetter.

This class maintains information required to emit JIT code in DFG and FTL.

DOMJIT::GetterSetter has 2 virtual functions: checkDOM and callDOM.

These functions can return a DOMJIT::Patchpoint that allows us to inject

appropriate machine code during DFG and FTL phases. DFG and FTL will invoke

these functions to get a patchpoint. And this patchpoint will be used to

emit code corresponding to CheckDOM and CallDOM DFG nodes, which will be added

in subsqeunt patch.

We propagate DOMJIT::GetterSetter through PropertySlot, AccessCase, GetByIdVariant,

and GetByIdStatus along with CustomGetter to teach DFG that this custom access

code has a chance to be inlined with this DOMJIT::GetterSetter information.

Instead of propagating CustomGetterSetter holding DOMJIT::GetterSetter and CustomGetter,

we propagate CustomGetter and DOMJIT::GetterSetter. This is because of the current

CustomGetterSetter design that we reify CustomGetterSetters only when we need to reify

all the properties. This design allows us to avoid frequent CustomGetterSetter allocations

and structure transitions.

Currently, domJIT field is always nullptr since there is no DOMJITAttribute user.

When we add this, we will add code handling this DOMJIT::GetterSetter in DFG::ByteCodeParser.

* CMakeLists.txt:

* JavaScriptCore.xcodeproj/project.pbxproj:

* bytecode/GetByIdStatus.cpp:

(JSC::GetByIdStatus::computeForStubInfoWithoutExitSiteFeedback):

* bytecode/GetByIdVariant.cpp:

(JSC::GetByIdVariant::GetByIdVariant):

(JSC::GetByIdVariant::operator=):

(JSC::GetByIdVariant::attemptToMerge):

(JSC::GetByIdVariant::dumpInContext):

* bytecode/GetByIdVariant.h:

(JSC::GetByIdVariant::domJIT):

(JSC::GetByIdVariant::intrinsic): Deleted.

* bytecode/PolymorphicAccess.cpp:

(JSC::AccessCase::get):

(JSC::AccessCase::clone):

* bytecode/PolymorphicAccess.h:

(JSC::AccessCase::domJIT):

(JSC::AccessCase::RareData::RareData):

* dfg/DFGNode.h:

* domjit/DOMJITGetterSetter.h: Added.

(JSC::DOMJIT::GetterSetter::GetterSetter):

(JSC::DOMJIT::GetterSetter::~GetterSetter):

(JSC::DOMJIT::GetterSetter::getter):

(JSC::DOMJIT::GetterSetter::setter):

(JSC::DOMJIT::GetterSetter::thisClassInfo):

* domjit/DOMJITPatchpoint.h: Added.

(JSC::DOMJIT::Patchpoint::create):

(JSC::DOMJIT::Patchpoint::setGenerator):

(JSC::DOMJIT::Patchpoint::generator):

* jit/Repatch.cpp:

(JSC::tryCacheGetByID):

* runtime/CustomGetterSetter.h:

* runtime/JSObject.h:

(JSC::JSObject::fillCustomGetterPropertySlot):

* runtime/Lookup.h:

(JSC::HashTableValue::domJIT):

(JSC::getStaticPropertySlotFromTable):

(JSC::putEntry):

(JSC::reifyStaticProperty):

* runtime/PropertySlot.h:

(JSC::PropertySlot::domJIT):

(JSC::PropertySlot::setCacheableCustom):

0F2E892D16D02BAF009E4FD2 /* DFGMinifiedID.h in Headers */ = {isa = PBXBuildFile; fileRef = 0FB4B51016B3A964003F696B /* DFGMinifiedID.h */; settings = {ATTRIBUTES = (Private, ); }; };

E328C6C71DA4304500D255FD /* MaxFrameExtentForSlowPathCall.h in Headers */ = {isa = PBXBuildFile; fileRef = 65860177185A8F5E00030EEE /* MaxFrameExtentForSlowPathCall.h */; settings = {ATTRIBUTES = (Private, ); }; };

E328C6C81DA4306100D255FD /* RegisterAtOffsetList.h in Headers */ = {isa = PBXBuildFile; fileRef = 6540C79D1B82D99D000F6B79 /* RegisterAtOffsetList.h */; settings = {ATTRIBUTES = (Private, ); }; };

E328C6C91DA432F900D255FD /* RegisterAtOffset.h in Headers */ = {isa = PBXBuildFile; fileRef = 6540C79F1B82D9CE000F6B79 /* RegisterAtOffset.h */; settings = {ATTRIBUTES = (Private, ); }; };

E3C08E3C1DA41B810039478F /* DOMJITPatchpoint.h in Headers */ = {isa = PBXBuildFile; fileRef = E3C08E3B1DA41B7B0039478F /* DOMJITPatchpoint.h */; settings = {ATTRIBUTES = (Private, ); }; };

E3FF75331D9CEA1800C7E16D /* DOMJITGetterSetter.h in Headers */ = {isa = PBXBuildFile; fileRef = E3FF752F1D9CEA1200C7E16D /* DOMJITGetterSetter.h */; settings = {ATTRIBUTES = (Private, ); }; };

E3C08E3B1DA41B7B0039478F /* DOMJITPatchpoint.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = DOMJITPatchpoint.h; sourceTree = "<group>"; };

E3FF752F1D9CEA1200C7E16D /* DOMJITGetterSetter.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = DOMJITGetterSetter.h; sourceTree = "<group>"; };

E3FF752D1D9CE9EA00C7E16D /* domjit */,

E3FF752D1D9CE9EA00C7E16D /* domjit */ = {

isa = PBXGroup;

children = (

E3FF752F1D9CEA1200C7E16D /* DOMJITGetterSetter.h */,

E3C08E3B1DA41B7B0039478F /* DOMJITPatchpoint.h */,

);

path = domjit;

sourceTree = "<group>";

};

E328C6C81DA4306100D255FD /* RegisterAtOffsetList.h in Headers */,

E3C08E3C1DA41B810039478F /* DOMJITPatchpoint.h in Headers */,

E3FF75331D9CEA1800C7E16D /* DOMJITGetterSetter.h in Headers */,

E328C6C71DA4304500D255FD /* MaxFrameExtentForSlowPathCall.h in Headers */,

E328C6C91DA432F900D255FD /* RegisterAtOffset.h in Headers */,

namespace DOMJIT {

class GetterSetter;

}

DOMJIT::GetterSetter* domJIT = nullptr;

case AccessCase::CustomAccessorGetter: {

domJIT = access.domJIT();

if (!domJIT)

return GetByIdStatus(slowPathState, true);

break;

}

intrinsicFunction,

domJIT);

JSFunction* intrinsicFunction,

DOMJIT::GetterSetter* domJIT)

, m_domJIT(domJIT)

m_domJIT = other.m_domJIT;

if (m_domJIT != other.m_domJIT)

return false;

if (m_domJIT)

out.print(", domjit = ", RawPointer(m_domJIT));

namespace DOMJIT {

class GetterSetter;

}

JSFunction* = nullptr,

DOMJIT::GetterSetter* = nullptr);

DOMJIT::GetterSetter* domJIT() const { return m_domJIT; }

DOMJIT::GetterSetter* m_domJIT;