Skip to content

Commit 2c0d56a

Browse files
cdumezcdumez
committed
Drop Vector::uncheckedAppend() alias
https://bugs.webkit.org/show_bug.cgi?id=263058 Reviewed by Brent Fulgham. Drop Vector::uncheckedAppend() alias and have call sites use Vector::append() directly instead. * Source/JavaScriptCore/API/glib/JSCClass.cpp: (jsc_class_add_constructor): (jsc_class_add_constructorv): (jsc_class_add_method): (jsc_class_add_methodv): * Source/JavaScriptCore/API/glib/JSCValue.cpp: (jsc_value_object_invoke_methodv): (jsc_value_new_function): (jsc_value_new_functionv): (jsc_value_function_callv): (jsc_value_constructor_callv): * Source/JavaScriptCore/b3/air/AirAllocateRegistersByGraphColoring.cpp: * Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::prepareLexicalScopeForNextForLoopIteration): * Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp: (JSC::ArrayPatternNode::emitDirectBinding): * Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp: (JSC::DFG::ByteCodeParser::parseBlock): * Source/JavaScriptCore/heap/MarkedBlockInlines.h: (JSC::MarkedBlock::Handle::specializedSweep): * Source/JavaScriptCore/heap/MarkedSpaceInlines.h: (JSC::MarkedSpace::forEachWeakInParallel): * Source/JavaScriptCore/inspector/agents/InspectorDebuggerAgent.cpp: (Inspector::parseBreakpointOptions): * Source/JavaScriptCore/inspector/remote/glib/RemoteInspectorServer.cpp: (Inspector::processSessionCapabilities): * Source/JavaScriptCore/interpreter/Interpreter.cpp: (JSC::GetStackTraceFunctor::operator() const): * Source/JavaScriptCore/runtime/IntlObject.cpp: (JSC::intlAvailableTimeZones): * Source/JavaScriptCore/runtime/JSObject.cpp: (JSC::JSObject::putOwnDataPropertyBatching): * Source/JavaScriptCore/runtime/MathObject.cpp: (JSC::JSC_DEFINE_HOST_FUNCTION): * Source/JavaScriptCore/runtime/SamplingProfiler.cpp: (JSC::SamplingProfiler::takeSample): * Source/JavaScriptCore/runtime/StringPrototype.cpp: (JSC::replaceUsingRegExpSearchWithCache): * Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp: (JSC::Wasm::B3IRGenerator::addLocal): * Source/JavaScriptCore/wasm/WasmBBQJIT.cpp: (JSC::Wasm::BBQJIT::addSwitch): * Source/JavaScriptCore/wasm/WasmEntryPlan.cpp: (JSC::Wasm::EntryPlan::prepare): * Source/JavaScriptCore/wasm/WasmFunctionParser.h: (JSC::Wasm::splitStack): (JSC::Wasm::FunctionParser<Context>::parse): (JSC::Wasm::FunctionParser<Context>::parseExpression): * Source/JavaScriptCore/wasm/WasmSectionParser.cpp: (JSC::Wasm::SectionParser::parseType): (JSC::Wasm::SectionParser::parseImport): (JSC::Wasm::SectionParser::parseFunction): (JSC::Wasm::SectionParser::parseGlobal): (JSC::Wasm::SectionParser::parseExport): (JSC::Wasm::SectionParser::parseElement): (JSC::Wasm::SectionParser::parseFunctionType): (JSC::Wasm::SectionParser::parseStructType): (JSC::Wasm::SectionParser::parseRecursionGroup): (JSC::Wasm::SectionParser::parseElementSegmentVectorOfExpressions): (JSC::Wasm::SectionParser::parseElementSegmentVectorOfIndexes): (JSC::Wasm::SectionParser::parseData): (JSC::Wasm::SectionParser::parseException): (JSC::Wasm::SectionParser::parseCustom): * Source/WTF/wtf/ThreadSafeWeakHashSet.h: * Source/WTF/wtf/TinyLRUCache.h: (WTF::TinyLRUCache::get): * Source/WTF/wtf/URL.cpp: (WTF::decodeEscapeSequencesFromParsedURL): * Source/WTF/wtf/URLParser.cpp: (WTF::URLParser::percentDecode): (WTF::URLParser::domainToASCII): * Source/WTF/wtf/Vector.h: (WTF::Vector::uncheckedAppend): Deleted. (WTF::Vector::uncheckedConstructAndAppend): Deleted. * Source/WTF/wtf/cf/VectorCF.h: (WTF::makeVector): * Source/WTF/wtf/cocoa/VectorCocoa.h: (WTF::makeVector): * Source/WTF/wtf/text/win/StringWin.cpp: (WTF::String::wideCharacters const): * Source/WebCore/Modules/ShapeDetection/Implementation/Cocoa/BarcodeDetectorImplementation.mm: (WebCore::ShapeDetection::BarcodeDetectorImpl::detect): * Source/WebCore/Modules/ShapeDetection/Implementation/Cocoa/FaceDetectorImplementation.mm: (WebCore::ShapeDetection::FaceDetectorImpl::detect): * Source/WebCore/Modules/ShapeDetection/Implementation/Cocoa/TextDetectorImplementation.mm: (WebCore::ShapeDetection::TextDetectorImpl::detect): * Source/WebCore/Modules/applepay/ApplePayRequestBase.cpp: (WebCore::convertAndValidate): * Source/WebCore/Modules/applepay/ApplePaySession.cpp: (WebCore::convertAndValidate): * Source/WebCore/Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp: (WebCore::convertAndValidate): (WebCore::ApplePayPaymentHandler::computeShippingMethods const): * Source/WebCore/Modules/async-clipboard/Clipboard.cpp: (WebCore::Clipboard::ItemWriter::didSetAllData): * Source/WebCore/Modules/cache/DOMCache.cpp: (WebCore::DOMCache::addAll): * Source/WebCore/Modules/fetch/FetchHeaders.cpp: (WebCore::FetchHeaders::Iterator::next): * Source/WebCore/Modules/indexeddb/server/IDBSerialization.cpp: (WebCore::decodeKey): * Source/WebCore/Modules/indexeddb/server/IndexValueStore.cpp: (WebCore::IDBServer::IndexValueStore::removeEntriesWithValueKey): * Source/WebCore/Modules/indexeddb/server/SQLiteIDBCursor.cpp: (WebCore::IDBServer::SQLiteIDBCursor::currentData): * Source/WebCore/Modules/mediasession/MediaMetadata.cpp: (WebCore::MediaMetadata::setArtwork): * Source/WebCore/Modules/mediasession/MediaSession.cpp: (WebCore::MediaSession::setPlaylist): * Source/WebCore/Modules/mediastream/MediaTrackCapabilities.cpp: (WebCore::capabilityBooleanVector): * Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp: (WebCore::RTCPeerConnection::iceServersFromConfiguration): (WebCore::RTCPeerConnection::certificatesFromConfiguration): * Source/WebCore/Modules/mediastream/SFrameUtils.cpp: (WebCore::fromRbsp): (WebCore::toRbsp): * Source/WebCore/Modules/paymentrequest/PaymentRequest.cpp: (WebCore::checkAndCanonicalizeDetails): (WebCore::PaymentRequest::create): * Source/WebCore/Modules/speech/cocoa/WebSpeechRecognizerTask.mm: (-[WebSpeechRecognizerTaskImpl callbackWithTranscriptions:isFinal:]): * Source/WebCore/Modules/webaudio/AudioBuffer.cpp: (WebCore::AudioBuffer::AudioBuffer): * Source/WebCore/Modules/webauthn/WebAuthenticationUtils.cpp: (WebCore::encodeRawPublicKey): * Source/WebCore/Modules/webcodecs/WebCodecsVideoFrameAlgorithms.cpp: (WebCore::computeLayoutAndAllocationSize): * Source/WebCore/Modules/webdatabase/DatabaseTracker.cpp: (WebCore::DatabaseTracker::deleteDatabasesModifiedSince): * Source/WebCore/PAL/pal/text/TextCodecCJK.cpp: (PAL::entityUnencodableHandler): * Source/WebCore/accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::notificationPostTimerFired): * Source/WebCore/accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::previousLineStartBoundaryPoints const): (WebCore::AccessibilityObject::supportsPressAction const): * Source/WebCore/accessibility/atspi/AccessibilityAtspi.cpp: (WebCore::AccessibilityAtspi::registerRoot): (WebCore::AccessibilityAtspi::registerObject): (WebCore::AccessibilityAtspi::registerHyperlink): * Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.cpp: (WebCore::AccessibilityObjectAtspi::wrapperVector const): * Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp: (WebCore::AXIsolatedObject::fillChildrenVectorForProperty const): * Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp: (WebCore::AXIsolatedTree::objectsForIDs): (WebCore::AXIsolatedTree::collectNodeChangesForChildrenMatching): (WebCore::AXIsolatedTree::collectNodeChangesForSubtree): * Source/WebCore/animation/CSSPropertyAnimation.cpp: (WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap): * Source/WebCore/bindings/js/JSDOMConvertSequences.h: (WebCore::Detail::NumericSequenceConverter::convertArray): (WebCore::Detail::SequenceConverter::convertArray): * Source/WebCore/bindings/js/SerializedScriptValue.cpp: (WebCore::CloneDeserializer::readRTCCertificate): * Source/WebCore/bindings/js/WebCoreJSClientData.cpp: (WebCore::JSVMClientData::getAllWorlds): * Source/WebCore/bridge/objc/objc_class.mm: (JSC::Bindings::convertJSMethodNameToObjc): * Source/WebCore/contentextensions/ContentExtensionActions.cpp: (WebCore::ContentExtensions::append): (WebCore::ContentExtensions::ModifyHeadersAction::parse): (WebCore::ContentExtensions::RedirectAction::RegexSubstitutionAction::serialize const): (WebCore::ContentExtensions::RedirectAction::URLTransformAction::serialize const): (WebCore::ContentExtensions::RedirectAction::URLTransformAction::QueryTransform::parse): (WebCore::ContentExtensions::RedirectAction::URLTransformAction::QueryTransform::QueryKeyValue::serialize const): (WebCore::ContentExtensions::uncheckedAppend): Deleted. * Source/WebCore/contentextensions/ContentExtensionParser.cpp: (WebCore::ContentExtensions::getStringList): (WebCore::ContentExtensions::getDomainList): (WebCore::ContentExtensions::loadEncodedRules): * Source/WebCore/contentextensions/ContentExtensionStringSerialization.cpp: (WebCore::ContentExtensions::serializeString): * Source/WebCore/contentextensions/ContentExtensionsBackend.cpp: (WebCore::ContentExtensions::ContentExtensionsBackend::processContentRuleListsForLoad): * Source/WebCore/contentextensions/DFAMinimizer.cpp: * Source/WebCore/crypto/gcrypt/CryptoAlgorithmECDSAGCrypt.cpp: (WebCore::extractECDSASignatureInteger): * Source/WebCore/crypto/gcrypt/CryptoAlgorithmEd25519GCrypt.cpp: (WebCore::extractEDDSASignatureInteger): * Source/WebCore/css/CSSFontSelector.cpp: (WebCore::m_version): * Source/WebCore/css/calc/CSSCalcOperationNode.cpp: (WebCore::CSSCalcOperationNode::combineChildren): (WebCore::CSSCalcOperationNode::createCalcExpression const): * Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp: (WebCore::CSSPropertyParserHelpers::consumeLinear): * Source/WebCore/css/typedom/CSSNumericValue.cpp: (WebCore::reifyMathExpressions): (WebCore::reifyMathExpression): (WebCore::CSSNumericValue::div): (WebCore::CSSNumericValue::toSum): * Source/WebCore/css/typedom/ComputedStylePropertyMapReadOnly.cpp: (WebCore::ComputedStylePropertyMapReadOnly::entries const): * Source/WebCore/css/typedom/StylePropertyMapReadOnly.cpp: (WebCore::StylePropertyMapReadOnly::reifyValueToVector): * Source/WebCore/css/typedom/numeric/CSSMathProduct.cpp: (WebCore::CSSMathProduct::toCalcExpressionNode const): * Source/WebCore/css/typedom/numeric/CSSMathSum.cpp: (WebCore::CSSMathSum::toCalcExpressionNode const): * Source/WebCore/dom/ComposedTreeIterator.cpp: (WebCore::ComposedTreeIterator::ComposedTreeIterator): * Source/WebCore/dom/ElementAndTextDescendantIterator.h: (WebCore::ElementAndTextDescendantIterator::ElementAndTextDescendantIterator): * Source/WebCore/dom/EventPath.cpp: (WebCore::EventPath::computePathUnclosedToTarget const): * Source/WebCore/dom/ImageOverlay.cpp: (WebCore::ImageOverlay::updateSubtree): * Source/WebCore/dom/SelectorQuery.cpp: (WebCore::SelectorDataList::SelectorDataList): * Source/WebCore/editing/Editor.cpp: (WebCore::editableTextListsAtPositionInDescendingOrder): * Source/WebCore/editing/cocoa/AttributedString.mm: (WebCore::extractArray): * Source/WebCore/html/DOMTokenList.cpp: (WebCore::DOMTokenList::addInternal): * Source/WebCore/html/FileInputType.cpp: (WebCore::FileInputType::filesFromFormControlState): (WebCore::FileInputType::saveFormControlState const): * Source/WebCore/html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::saveFormControlState const): * Source/WebCore/html/parser/HTMLFormattingElementList.cpp: (WebCore::HTMLFormattingElementList::ensureNoahsArkCondition): * Source/WebCore/inspector/agents/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::setInstruments): * Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp: (WebCore::Layout::buildBidiParagraph): * Source/WebCore/layout/formattingContexts/inline/InlineLineBuilder.cpp: (WebCore::Layout::computedVisualOrder): * Source/WebCore/loader/FrameLoader.cpp: (WebCore::FrameLoader::detachChildren): * Source/WebCore/loader/cache/MemoryCache.cpp: (WebCore::MemoryCache::lruListFor): * Source/WebCore/page/ShareDataReader.cpp: (WebCore::ShareDataReader::start): * Source/WebCore/platform/SharedBuffer.cpp: (WebCore::FragmentedSharedBuffer::copyData const): * Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp: (getGStreamerAudioCaps): * Source/WebCore/platform/cocoa/PlatformPasteboardCocoa.mm: (WebCore::PlatformPasteboard::allPasteboardItemInfo): * Source/WebCore/platform/graphics/ComplexTextController.cpp: (WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): * Source/WebCore/platform/graphics/PathUtilities.cpp: (WebCore::polygonsForRect): * Source/WebCore/platform/graphics/Region.cpp: (WebCore::Region::rects const): * Source/WebCore/platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm: (-[WebCoreFPSContentKeySessionDelegate contentKeySession:didProvideContentKeyRequests:forInitializationData:]): * Source/WebCore/platform/graphics/avfoundation/objc/MediaSampleAVFObjC.mm: (WebCore::MediaSampleAVFObjC::divideIntoHomogeneousSamples): * Source/WebCore/platform/graphics/cg/GradientRendererCG.cpp: (WebCore::alphaTransformStopsToEmulateAlphaPremultiplication): (WebCore::GradientRendererCG::makeGradient const): (WebCore::GradientRendererCG::makeShading const): * Source/WebCore/platform/graphics/coretext/DrawGlyphsRecorderCoreText.cpp: (WebCore::computeHorizontalAdvancesFromPositions): (WebCore::computeVerticalAdvancesFromPositions): * Source/WebCore/platform/graphics/filters/FilterEffect.cpp: (WebCore::FilterEffect::takeImageInputs const): * Source/WebCore/platform/graphics/gbm/DMABufEGLUtilities.h: (WebCore::DMABufEGLUtilities::constructEGLCreateImageAttributes): * Source/WebCore/platform/graphics/gstreamer/eme/CDMFactoryGStreamer.cpp: * Source/WebCore/platform/graphics/gstreamer/eme/GStreamerEMEUtilities.h: (WebCore::ProtectionSystemEvents::ProtectionSystemEvents): * Source/WebCore/platform/graphics/iso/ISOTrackEncryptionBox.cpp: (WebCore::ISOTrackEncryptionBox::parsePayload): * Source/WebCore/platform/graphics/iso/ISOVTTCue.cpp: * Source/WebCore/platform/graphics/mac/ComplexTextControllerCoreText.mm: (WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): * Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp: (WebCore::GraphicsLayerTextureMapper::commitLayerChanges): * Source/WebCore/platform/graphics/win/ComplexTextControllerUniscribe.cpp: (WebCore::ComplexTextController::collectComplexTextRunsForCharacters): * Source/WebCore/platform/graphics/win/FontCacheWin.cpp: (WebCore::FontCache::getFontSelectionCapabilitiesInFamily): * Source/WebCore/platform/gtk/RenderThemeGadget.cpp: (WebCore::RenderThemeBoxGadget::RenderThemeBoxGadget): * Source/WebCore/platform/ios/PlatformPasteboardIOS.mm: (WebCore::PlatformPasteboard::informationForItemAtIndex): (WebCore::PlatformPasteboard::allStringsForType const): * Source/WebCore/platform/mac/PlatformPasteboardMac.mm: (WebCore::urlStringsFromPasteboard): (WebCore::PlatformPasteboard::informationForItemAtIndex): * Source/WebCore/platform/mediastream/MediaStreamPrivate.cpp: (WebCore::MediaStreamPrivate::create): * Source/WebCore/platform/mediastream/ios/AVAudioSessionCaptureDeviceManager.mm: (WebCore::AVAudioSessionCaptureDeviceManager::retrieveAudioSessionCaptureDevices const): * Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm: (WebCore::supportedWhiteBalanceModes): * Source/WebCore/platform/network/ResourceRequestBase.cpp: (WebCore::ResourceRequestBase::setResponseContentDispositionEncodingFallbackArray): * Source/WebCore/platform/network/cocoa/NetworkStorageSessionCocoa.mm: * Source/WebCore/platform/network/cocoa/ResourceRequestCocoa.mm: (WebCore::ResourceRequest::doUpdateResourceRequest): * Source/WebCore/platform/text/LocaleICU.cpp: (WebCore::LocaleICU::createLabelVector): * Source/WebCore/rendering/MarkedText.cpp: (WebCore::MarkedText::subdivide): (WebCore::MarkedText::collectForDocumentMarkers): * Source/WebCore/rendering/RenderGrid.cpp: (WebCore::RenderGrid::trackSizesForComputedStyle const): * Source/WebCore/rendering/RenderText.cpp: (WebCore::RenderText::absoluteQuadsForRange const): * Source/WebCore/rendering/StyledMarkedText.cpp: (WebCore::StyledMarkedText::subdivideAndResolve): (WebCore::coalesceAdjacent): * Source/WebCore/svg/graphics/filters/SVGFilterGraph.h: (WebCore::SVGFilterGraph::getNamedNodes const): * Source/WebCore/testing/MockGamepadProvider.cpp: (WebCore::MockGamepadProvider::connectMockGamepad): * Source/WebCore/workers/WorkerGlobalScope.cpp: (WebCore::WorkerGlobalScope::importScripts): * Source/WebCore/workers/service/background-fetch/BackgroundFetch.cpp: (WebCore::BackgroundFetch::createFromStore): * Source/WebCore/workers/service/background-fetch/BackgroundFetchManager.cpp: (WebCore::buildBackgroundFetchRequests): * Source/WebDriver/Session.cpp: (WebDriver::Session::elementSendKeys): * Source/WebDriver/WebDriverService.cpp: (WebDriver::WebDriverService::processCapabilities const): * Source/WebDriver/glib/SessionHostGlib.cpp: (WebDriver::SessionHost::messageHandlers): * Source/WebDriver/gtk/WebDriverServiceGtk.cpp: (WebDriver::WebDriverService::platformParseCapabilities const): * Source/WebDriver/wpe/WebDriverServiceWPE.cpp: (WebDriver::WebDriverService::platformParseCapabilities const): * Source/WebGPU/WebGPU/RenderPipeline.mm: (WebGPU::Device::generatePipelineLayout): * Source/WebKit/GPUProcess/graphics/WebGPU/RemoteQueue.cpp: (WebKit::RemoteQueue::submit): * Source/WebKit/GPUProcess/graphics/WebGPU/RemoteRenderPassEncoder.cpp: (WebKit::RemoteRenderPassEncoder::executeBundles): * Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsStore.cpp: (WebKit::ResourceLoadStatisticsStore::ensurePrevalentResourcesForDebugMode): * Source/WebKit/NetworkProcess/cache/NetworkCacheSubresourcesEntry.cpp: (WebKit::NetworkCache::makeSubresourceInfoVector): * Source/WebKit/NetworkProcess/storage/CacheStorageCache.cpp: (WebKit::CacheStorageCache::retrieveRecords): * Source/WebKit/NetworkProcess/storage/CacheStorageManager.cpp: (WebKit::readCachesList): * Source/WebKit/NetworkProcess/webrtc/NetworkRTCTCPSocketCocoa.mm: (WebKit::NetworkRTCTCPSocketCocoa::createMessageBuffer): * Source/WebKit/Platform/IPC/ArgumentCoders.h: * Source/WebKit/Platform/cocoa/ImageAnalysisUtilities.mm: (WebKit::makeTextRecognitionResult): * Source/WebKit/Shared/API/APIArray.cpp: (API::Array::toStringVector): * Source/WebKit/Shared/ApplePay/ApplePayPaymentSetupFeatures.mm: (WebKit::PaymentSetupFeatures::operator Vector<Ref<WebCore::ApplePaySetupFeature>> const): * Source/WebKit/Shared/Cocoa/APIObject.mm: (API::Object::fromNSObject): * Source/WebKit/Shared/RemoteLayerTree/RemoteLayerWithRemoteRenderingBackingStoreCollection.mm: (WebKit::RemoteLayerWithRemoteRenderingBackingStoreCollection::prepareBackingStoresForDisplay): * Source/WebKit/Shared/SharedStringHashStore.cpp: (WebKit::SharedStringHashStore::processPendingOperations): * Source/WebKit/Shared/WebContextMenuItem.cpp: (WebKit::WebContextMenuItem::create): * Source/WebKit/Shared/WebCoreArgumentCoders.cpp: (IPC::ArgumentCoder<CSSFilter>::decode): * Source/WebKit/Shared/WebGPU/WebGPUBindGroupDescriptor.cpp: (WebKit::WebGPU::ConvertToBackingContext::convertToBacking): (WebKit::WebGPU::ConvertFromBackingContext::convertFromBacking): * Source/WebKit/Shared/WebGPU/WebGPUBindGroupLayoutDescriptor.cpp: (WebKit::WebGPU::ConvertToBackingContext::convertToBacking): (WebKit::WebGPU::ConvertFromBackingContext::convertFromBacking): * Source/WebKit/Shared/WebGPU/WebGPUFragmentState.cpp: (WebKit::WebGPU::ConvertToBackingContext::convertToBacking): (WebKit::WebGPU::ConvertFromBackingContext::convertFromBacking): * Source/WebKit/Shared/WebGPU/WebGPUPipelineLayoutDescriptor.cpp: (WebKit::WebGPU::ConvertToBackingContext::convertToBacking): (WebKit::WebGPU::ConvertFromBackingContext::convertFromBacking): * Source/WebKit/Shared/WebGPU/WebGPURenderPassDescriptor.cpp: (WebKit::WebGPU::ConvertToBackingContext::convertToBacking): (WebKit::WebGPU::ConvertFromBackingContext::convertFromBacking): * Source/WebKit/Shared/WebGPU/WebGPUShaderModuleDescriptor.cpp: (WebKit::WebGPU::ConvertToBackingContext::convertToBacking): (WebKit::WebGPU::ConvertFromBackingContext::convertFromBacking): * Source/WebKit/Shared/WebGPU/WebGPUVertexBufferLayout.cpp: (WebKit::WebGPU::ConvertToBackingContext::convertToBacking): (WebKit::WebGPU::ConvertFromBackingContext::convertFromBacking): * Source/WebKit/Shared/WebGPU/WebGPUVertexState.cpp: (WebKit::WebGPU::ConvertToBackingContext::convertToBacking): (WebKit::WebGPU::ConvertFromBackingContext::convertFromBacking): * Source/WebKit/Shared/libwpe/WebEventFactory.cpp: (WebKit::WebEventFactory::createWebTouchEvent): * Source/WebKit/UIProcess/API/APIWebAuthenticationPanel.cpp: (API::WebAuthenticationPanel::WebAuthenticationPanel): * Source/WebKit/UIProcess/API/C/WKContextMenuListener.cpp: (WKContextMenuListenerUseContextMenuItems): * Source/WebKit/UIProcess/API/C/WKOpenPanelResultListener.cpp: (filePathsFromFileURLs): * Source/WebKit/UIProcess/API/C/WKPage.cpp: (WKPageSetPageContextMenuClient): * Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm: (-[WKWebView _completeTextManipulationForItems:completion:]): * Source/WebKit/UIProcess/API/Cocoa/WKWebpagePreferences.mm: (-[WKWebpagePreferences _setActiveContentRuleListActionPatterns:]): * Source/WebKit/UIProcess/API/Cocoa/_WKCustomHeaderFields.mm: (-[_WKCustomHeaderFields setFields:]): * Source/WebKit/UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm: (-[_WKProcessPoolConfiguration setAdditionalReadAccessAllowedURLs:]): * Source/WebKit/UIProcess/API/glib/WebKitOptionMenu.cpp: (webkitOptionMenuCreate): * Source/WebKit/UIProcess/API/glib/WebKitWebViewSessionState.cpp: (decodeHTTPBody): (decodeFrameState): (decodeBackForwardListItemStateV1): (decodeBackForwardListItemState): * Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp: (appendTouchEvent): * Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp: (WebKit::WebAutomationSession::performKeyboardInteractions): (WebKit::WebAutomationSession::performInteractionSequence): * Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionWindowCocoa.mm: (WebKit::WebExtensionWindow::tabs const): * Source/WebKit/UIProcess/Inspector/glib/RemoteInspectorClient.cpp: (WebKit::RemoteInspectorClient::messageHandlers): * Source/WebKit/UIProcess/Notifications/WebNotificationManagerMessageHandler.cpp: (WebKit::WebNotificationManagerMessageHandler::clearNotifications): * Source/WebKit/UIProcess/UserMediaProcessManager.cpp: (WebKit::UserMediaProcessManager::willCreateMediaStream): * Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm: (WebKit::LocalAuthenticatorInternal::getExistingCredentials): * Source/WebKit/UIProcess/WebAuthentication/Cocoa/WebAuthenticatorCoordinatorProxy.mm: (WebKit::toAuthenticatorTransports): * Source/WebKit/UIProcess/WebAuthentication/fido/CtapAuthenticator.cpp: (WebKit::CtapAuthenticator::continueGetAssertionAfterResponseReceived): (WebKit::CtapAuthenticator::continueGetNextAssertionAfterResponseReceived): * Source/WebKit/UIProcess/WebBackForwardList.cpp: (WebKit::WebBackForwardList::addItem): (WebKit::WebBackForwardList::clear): * Source/WebKit/UIProcess/WebGrammarDetail.cpp: (WebKit::WebGrammarDetail::WebGrammarDetail): * Source/WebKit/UIProcess/gtk/WebPopupMenuProxyGtk.cpp: (WebKit::WebPopupMenuProxyGtk::createPopupMenu): * Source/WebKit/UIProcess/ios/TextCheckerIOS.mm: (WebKit::TextChecker::checkTextOfParagraph): * Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.mm: (-[WKFileUploadPanel _chooseFiles:displayString:iconImage:]): * Source/WebKit/UIProcess/mac/LegacySessionStateCoding.cpp: (WebKit::createDictionary): * Source/WebKit/UIProcess/mac/TextCheckerMac.mm: (WebKit::TextChecker::checkTextOfParagraph): * Source/WebKit/UIProcess/mac/WKTextFinderClient.mm: (-[WKTextFinderClient replaceMatches:withString:inSelectionOnly:resultCollector:]): * Source/WebKit/UIProcess/mac/WebViewImpl.mm: (WebKit::WebViewImpl::setCustomSwipeViews): (WebKit::compositionHighlights): * Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPITabsCocoa.mm: (WebKit::WebExtensionAPITabs::remove): * Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIWindowsCocoa.mm: (WebKit::WebExtensionAPIWindows::parseWindowCreateOptions): * Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp: (WKBundlePageReplaceStringMatches): (WKBundlePageSetComposition): * Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.cpp: * Source/WebKit/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.mm: (createWKArray): * Source/WebKit/WebProcess/WebPage/FindController.cpp: (WebKit::FindController::replaceMatches): * Source/WebKit/WebProcess/WebPage/MomentumEventDispatcher.cpp: (WebKit::MomentumEventDispatcher::equalizeTailGaps): * Source/WebKit/WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::frameTreeData const): (WebKit::WebFrame::childFrames): * Source/WebKitLegacy/Storage/StorageTracker.cpp: (WebKit::StorageTracker::origins): * Tools/TestWebKitAPI/Tests/IPC/ConnectionTests.cpp: (TestWebKitAPI::TEST_P): * Tools/TestWebKitAPI/Tests/WTF/CompactPtr.cpp: (TestWebKitAPI::TEST): * Tools/TestWebKitAPI/Tests/WTF/Packed.cpp: (TestWebKitAPI::TEST): * Tools/TestWebKitAPI/Tests/WTF/UniqueRefVector.cpp: (TestWebKitAPI::TEST): * Tools/TestWebKitAPI/Tests/WTF/Vector.cpp: (TestWebKitAPI::TEST): * Tools/TestWebKitAPI/Tests/WTF/WeakPtr.cpp: (TestWebKitAPI::TEST): * Tools/TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm: (TestWebKitAPI::PasteboardAccessChecker::PasteboardAccessChecker): * Tools/TestWebKitAPI/Tests/WebKitCocoa/WebSocket.mm: (TestWebKitAPI::TEST): * Tools/TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp: * Tools/TestWebKitAPI/cocoa/HTTPServer.mm: (TestWebKitAPI::H2::Connection::send const): * Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::didReceiveMessageToPage): * Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp: (WTR::elementsVector): * Tools/WebKitTestRunner/TestController.cpp: (WTR::loadedSubresourceDomainsCallback): * Tools/WebKitTestRunner/ios/PlatformWebViewIOS.mm: (WTR::PlatformWebView::windowSnapshotImage): * Tools/WebKitTestRunner/ios/TestControllerIOS.mm: (WTR::TestController::setKeyboardInputModeIdentifier): Canonical link: https://commits.webkit.org/269269@main
1 parent 6cd43ab commit 2c0d56a

219 files changed

Lines changed: 530 additions & 599 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎Source/JavaScriptCore/API/glib/JSCClass.cpp‎

Lines changed: 12 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -599,12 +599,9 @@ JSCValue* jsc_class_add_constructor(JSCClass* jscClass, const char* name, GCallb
599599

600600
va_list args;
601601
va_start(args, paramCount);
602-
Vector<GType> parameters;
603-
if (paramCount) {
604-
parameters.reserveInitialCapacity(paramCount);
605-
for (unsigned i = 0; i < paramCount; ++i)
606-
parameters.uncheckedAppend(va_arg(args, GType));
607-
}
602+
Vector<GType> parameters(paramCount, [&](size_t) -> GType {
603+
return va_arg(args, GType);
604+
});
608605
va_end(args);
609606

610607
return jscClassCreateConstructor(jscClass, name ? name : priv->name.data(), callback, userData, destroyNotify, returnType, WTFMove(parameters)).leakRef();
@@ -647,12 +644,9 @@ JSCValue* jsc_class_add_constructorv(JSCClass* jscClass, const char* name, GCall
647644
if (!name)
648645
name = priv->name.data();
649646

650-
Vector<GType> parameters;
651-
if (parametersCount) {
652-
parameters.reserveInitialCapacity(parametersCount);
653-
for (unsigned i = 0; i < parametersCount; ++i)
654-
parameters.uncheckedAppend(parameterTypes[i]);
655-
}
647+
Vector<GType> parameters(parametersCount, [&](size_t i) -> GType {
648+
return parameterTypes[i];
649+
});
656650

657651
return jscClassCreateConstructor(jscClass, name ? name : priv->name.data(), callback, userData, destroyNotify, returnType, WTFMove(parameters)).leakRef();
658652
}
@@ -739,12 +733,9 @@ void jsc_class_add_method(JSCClass* jscClass, const char* name, GCallback callba
739733

740734
va_list args;
741735
va_start(args, paramCount);
742-
Vector<GType> parameters;
743-
if (paramCount) {
744-
parameters.reserveInitialCapacity(paramCount);
745-
for (unsigned i = 0; i < paramCount; ++i)
746-
parameters.uncheckedAppend(va_arg(args, GType));
747-
}
736+
Vector<GType> parameters(paramCount, [&](size_t) -> GType {
737+
return va_arg(args, GType);
738+
});
748739
va_end(args);
749740

750741
jscClassAddMethod(jscClass, name, callback, userData, destroyNotify, returnType, WTFMove(parameters));
@@ -779,12 +770,9 @@ void jsc_class_add_methodv(JSCClass* jscClass, const char* name, GCallback callb
779770
g_return_if_fail(!parametersCount || parameterTypes);
780771
g_return_if_fail(jscClass->priv->context);
781772

782-
Vector<GType> parameters;
783-
if (parametersCount) {
784-
parameters.reserveInitialCapacity(parametersCount);
785-
for (unsigned i = 0; i < parametersCount; ++i)
786-
parameters.uncheckedAppend(parameterTypes[i]);
787-
}
773+
Vector<GType> parameters(parametersCount, [&](size_t i) -> GType {
774+
return parameterTypes[i];
775+
});
788776

789777
jscClassAddMethod(jscClass, name, callback, userData, destroyNotify, returnType, WTFMove(parameters));
790778
}

‎Source/JavaScriptCore/API/glib/JSCValue.cpp‎

Lines changed: 15 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -1001,12 +1001,9 @@ JSCValue* jsc_value_object_invoke_methodv(JSCValue* value, const char* name, uns
10011001
if (jscContextHandleExceptionIfNeeded(priv->context.get(), exception))
10021002
return jsc_value_new_undefined(priv->context.get());
10031003

1004-
Vector<JSValueRef> arguments;
1005-
if (parametersCount) {
1006-
arguments.reserveInitialCapacity(parametersCount);
1007-
for (unsigned i = 0; i < parametersCount; ++i)
1008-
arguments.uncheckedAppend(jscValueGetJSValue(parameters[i]));
1009-
}
1004+
Vector<JSValueRef> arguments(parametersCount, [&](size_t i) {
1005+
return jscValueGetJSValue(parameters[i]);
1006+
});
10101007

10111008
auto result = jsObjectCall(jsContext, function, JSC::JSCCallbackFunction::Type::Method, object, arguments, &exception);
10121009
if (jscContextHandleExceptionIfNeeded(priv->context.get(), exception))
@@ -1206,12 +1203,9 @@ JSCValue* jsc_value_new_function(JSCContext* context, const char* name, GCallbac
12061203

12071204
va_list args;
12081205
va_start(args, paramCount);
1209-
Vector<GType> parameters;
1210-
if (paramCount) {
1211-
parameters.reserveInitialCapacity(paramCount);
1212-
for (unsigned i = 0; i < paramCount; ++i)
1213-
parameters.uncheckedAppend(va_arg(args, GType));
1214-
}
1206+
Vector<GType> parameters(paramCount, [&](size_t) -> GType {
1207+
return va_arg(args, GType);
1208+
});
12151209
va_end(args);
12161210

12171211
return jscValueFunctionCreate(context, name, callback, userData, destroyNotify, returnType, WTFMove(parameters)).leakRef();
@@ -1246,12 +1240,9 @@ JSCValue* jsc_value_new_functionv(JSCContext* context, const char* name, GCallba
12461240
g_return_val_if_fail(callback, nullptr);
12471241
g_return_val_if_fail(!parametersCount || parameterTypes, nullptr);
12481242

1249-
Vector<GType> parameters;
1250-
if (parametersCount) {
1251-
parameters.reserveInitialCapacity(parametersCount);
1252-
for (unsigned i = 0; i < parametersCount; ++i)
1253-
parameters.uncheckedAppend(parameterTypes[i]);
1254-
}
1243+
Vector<GType> parameters(parametersCount, [&](size_t i) -> GType {
1244+
return parameterTypes[i];
1245+
});
12551246

12561247
return jscValueFunctionCreate(context, name, callback, userData, destroyNotify, returnType, WTFMove(parameters)).leakRef();
12571248
}
@@ -1363,12 +1354,9 @@ JSCValue* jsc_value_function_callv(JSCValue* value, unsigned parametersCount, JS
13631354
if (jscContextHandleExceptionIfNeeded(priv->context.get(), exception))
13641355
return jsc_value_new_undefined(priv->context.get());
13651356

1366-
Vector<JSValueRef> arguments;
1367-
if (parametersCount) {
1368-
arguments.reserveInitialCapacity(parametersCount);
1369-
for (unsigned i = 0; i < parametersCount; ++i)
1370-
arguments.uncheckedAppend(jscValueGetJSValue(parameters[i]));
1371-
}
1357+
Vector<JSValueRef> arguments(parametersCount, [&](size_t i) {
1358+
return jscValueGetJSValue(parameters[i]);
1359+
});
13721360

13731361
auto result = jsObjectCall(jsContext, function, JSC::JSCCallbackFunction::Type::Function, nullptr, arguments, &exception);
13741362
if (jscContextHandleExceptionIfNeeded(priv->context.get(), exception))
@@ -1449,12 +1437,9 @@ JSCValue* jsc_value_constructor_callv(JSCValue* value, unsigned parametersCount,
14491437
if (jscContextHandleExceptionIfNeeded(priv->context.get(), exception))
14501438
return jsc_value_new_undefined(priv->context.get());
14511439

1452-
Vector<JSValueRef> arguments;
1453-
if (parametersCount) {
1454-
arguments.reserveInitialCapacity(parametersCount);
1455-
for (unsigned i = 0; i < parametersCount; ++i)
1456-
arguments.uncheckedAppend(jscValueGetJSValue(parameters[i]));
1457-
}
1440+
Vector<JSValueRef> arguments(parametersCount, [&](size_t i) {
1441+
return jscValueGetJSValue(parameters[i]);
1442+
});
14581443

14591444
auto result = jsObjectCall(jsContext, function, JSC::JSCCallbackFunction::Type::Constructor, nullptr, arguments, &exception);
14601445
if (jscContextHandleExceptionIfNeeded(priv->context.get(), exception))

‎Source/JavaScriptCore/b3/air/AirAllocateRegistersByGraphColoring.cpp‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -229,7 +229,7 @@ class AbstractColoringAllocator {
229229
numCandidates--;
230230
if (!hasBeenSimplified(adjacentTmpIndex) && m_degrees[adjacentTmpIndex] >= registerCount()) {
231231
ASSERT(std::find(highOrderAdjacents.begin(), highOrderAdjacents.end(), adjacentTmpIndex) == highOrderAdjacents.end());
232-
highOrderAdjacents.uncheckedAppend(adjacentTmpIndex);
232+
highOrderAdjacents.append(adjacentTmpIndex);
233233
if (highOrderAdjacents.size() >= registerCount())
234234
return false;
235235
} else if (highOrderAdjacents.size() + numCandidates < registerCount())
@@ -246,7 +246,7 @@ class AbstractColoringAllocator {
246246
&& m_degrees[adjacentTmpIndex] >= registerCount()
247247
&& std::find(highOrderAdjacents.begin(), iteratorEndHighOrderAdjacentsOfU, adjacentTmpIndex) == iteratorEndHighOrderAdjacentsOfU) {
248248
ASSERT(std::find(iteratorEndHighOrderAdjacentsOfU, highOrderAdjacents.end(), adjacentTmpIndex) == highOrderAdjacents.end());
249-
highOrderAdjacents.uncheckedAppend(adjacentTmpIndex);
249+
highOrderAdjacents.append(adjacentTmpIndex);
250250
if (highOrderAdjacents.size() >= registerCount())
251251
return false;
252252
} else if (highOrderAdjacents.size() + numCandidates < registerCount())

‎Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2342,7 +2342,7 @@ void BytecodeGenerator::prepareLexicalScopeForNextForLoopIteration(VariableEnvir
23422342
RegisterID* transitionValue = newBlockScopeVariable();
23432343
transitionValue->ref();
23442344
emitGetFromScope(transitionValue, loopScope, variableForLocalEntry(identifier, ptr->value, loopSymbolTable->index(), true), DoNotThrowIfNotFound);
2345-
activationValuesToCopyOver.uncheckedAppend(std::make_pair(transitionValue, identifier));
2345+
activationValuesToCopyOver.append(std::make_pair(transitionValue, identifier));
23462346
}
23472347
}
23482348

‎Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5545,7 +5545,7 @@ RegisterID* ArrayPatternNode::emitDirectBinding(BytecodeGenerator& generator, Re
55455545
Vector<RefPtr<RegisterID>> registers;
55465546
registers.reserveInitialCapacity(m_targetPatterns.size());
55475547
for (size_t i = 0; i < m_targetPatterns.size(); i++) {
5548-
registers.uncheckedAppend(generator.newTemporary());
5548+
registers.append(generator.newTemporary());
55495549
generator.emitNode(registers.last().get(), elements[i]);
55505550
if (m_targetPatterns[i].defaultValue)
55515551
assignDefaultValueIfUndefined(generator, registers.last().get(), m_targetPatterns[i].defaultValue);

‎Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7792,7 +7792,7 @@ void ByteCodeParser::parseBlock(unsigned limit)
77927792
Node* value = addToGraph(ExtractCatchLocal, OpInfo(numberOfLocals), OpInfo(localPredictions[numberOfLocals]));
77937793
++numberOfLocals;
77947794
addToGraph(MovHint, OpInfo(operand), value);
7795-
localsToSet.uncheckedAppend(std::make_pair(operand, value));
7795+
localsToSet.append(std::make_pair(operand, value));
77967796
});
77977797
if (numberOfLocals)
77987798
addToGraph(ClearCatchLocals);

‎Source/JavaScriptCore/heap/MarkedBlockInlines.h‎

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -322,7 +322,6 @@ void MarkedBlock::Handle::specializedSweep(FreeList* freeList, MarkedBlock::Hand
322322
constexpr size_t maxDeadCellBufferBytes = 8 * KB; // Arbitrary limit of 8kB for stack buffer.
323323
constexpr size_t deadCellBufferBytes = std::min(atomsPerBlock * sizeof(AtomNumberType), maxDeadCellBufferBytes);
324324
static_assert(deadCellBufferBytes <= maxDeadCellBufferBytes);
325-
constexpr bool deadCellsAlwaysFitsOnStack = (deadCellBufferBytes / sizeof(AtomNumberType)) <= atomsPerBlock;
326325
Vector<AtomNumberType, deadCellBufferBytes / sizeof(AtomNumberType)> deadCells;
327326

328327
auto handleDeadCell = [&] (size_t i) {
@@ -374,12 +373,9 @@ void MarkedBlock::Handle::specializedSweep(FreeList* freeList, MarkedBlock::Hand
374373
continue;
375374
}
376375

377-
if (destructionMode == BlockHasDestructorsAndCollectorIsRunning) {
378-
if constexpr (deadCellsAlwaysFitsOnStack)
379-
deadCells.uncheckedAppend(i);
380-
else
381-
deadCells.append(i);
382-
} else
376+
if (destructionMode == BlockHasDestructorsAndCollectorIsRunning)
377+
deadCells.append(i);
378+
else
383379
handleDeadCell(i);
384380
}
385381
if (destructionMode != BlockHasDestructorsAndCollectorIsRunning)

‎Source/JavaScriptCore/heap/MarkedSpaceInlines.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ inline Ref<SharedTask<void(Visitor&)>> MarkedSpace::forEachWeakInParallel()
9898
m_current = m_current->next();
9999
if (block->isEmpty())
100100
continue;
101-
results.uncheckedAppend(block);
101+
results.append(block);
102102
if (results.size() == batchSize)
103103
return;
104104
continue;

‎Source/JavaScriptCore/inspector/agents/InspectorDebuggerAgent.cpp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ static T parseBreakpointOptions(Protocol::ErrorString& errorString, RefPtr<JSON:
143143

144144
action.emulateUserGesture = actionObject->getBoolean(Protocol::Debugger::BreakpointAction::emulateUserGestureKey).value_or(false);
145145

146-
actions.uncheckedAppend(WTFMove(action));
146+
actions.append(WTFMove(action));
147147
}
148148
}
149149

‎Source/JavaScriptCore/inspector/remote/glib/RemoteInspectorServer.cpp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ static RemoteInspector::Client::SessionCapabilities processSessionCapabilities(G
5757
const char* host;
5858
const char* certificateFile;
5959
while (g_variant_iter_loop(&iter, "(&s&s)", &host, &certificateFile))
60-
capabilities.certificates.uncheckedAppend({ String::fromUTF8(host), String::fromUTF8(certificateFile) });
60+
capabilities.certificates.append({ String::fromUTF8(host), String::fromUTF8(certificateFile) });
6161
}
6262

6363
if (GRefPtr<GVariant> proxy = g_variant_lookup_value(sessionCapabilities, "proxy", G_VARIANT_TYPE("a{sv}"))) {

0 commit comments

Comments
 (0)