@@ -1,3 +1,25 @@
+2022-03-10  Chris Dumez  <cdumez@apple.com>
+
+        Optimize further the passing of data across threads
+        https://bugs.webkit.org/show_bug.cgi?id=237695
+
+        Reviewed by Geoffrey Garen.
+
+        Optimize further the passing of data across threads by leveraging the optimized
+        version of isolatedCopy() on r-value references whenever possible.
+
+        * inspector/remote/RemoteConnectionToTarget.cpp:
+        (Inspector::RemoteConnectionToTarget::sendMessageToTarget):
+        * inspector/remote/RemoteConnectionToTarget.h:
+        * inspector/remote/RemoteControllableTarget.h:
+        * jsc.cpp:
+        (JSC_DEFINE_HOST_FUNCTION):
+        * runtime/JSGlobalObjectDebuggable.cpp:
+        (JSC::JSGlobalObjectDebuggable::dispatchMessageFromRemote):
+        * runtime/JSGlobalObjectDebuggable.h:
+        * tools/FunctionOverrides.cpp:
+        (JSC::FunctionOverrides::initializeOverrideFor):
+
 2022-03-08  Carlos Garcia Campos  <cgarcia@igalia.com>
 
         [GTK][WPE] Web Inspector: make it possible to use the remote inspector from other browsers
 
@@ -72,7 +72,7 @@ bool RemoteConnectionToTarget::setup(bool isAutomaticInspection, bool automatica
     return true;
 }
 
-void RemoteConnectionToTarget::sendMessageToTarget(const String& message)
+void RemoteConnectionToTarget::sendMessageToTarget(String&& message)
 {
     RemoteControllableTarget* class="pl-c1">nullptr;
     {
@@ -82,7 +82,7 @@ void RemoteConnectionToTarget::sendMessageToTarget(const String& message)
 >
     }
 
-    target->dispatchMessageFromRemote(message);
+    target->dispatchMessageFromRemote(WTFMove(message));
 }
 
 void RemoteConnectionToTarget::close()
 
@@ -61,7 +61,7 @@ class RemoteConnectionToTarget final : public ThreadSafeRefCounted<RemoteConnect
 #if PLATFORM(COCOA)
     void sendMessageToTarget(NSString *);
 #else
-    void sendMessageToTarget(const String&);
+    void sendMessageToTarget(String&&);
 #endif
     void close();
     void targetClosed();
 
@@ -64,7 +64,7 @@ class JS_EXPORT_PRIVATE RemoteControllableTarget {
     };
     virtual Type type() const = 0;
     virtual bool remoteControlAllowed() const = 0;
-    virtual void dispatchMessageFromRemote(const String& message) = 0;
+    virtual void dispatchMessageFromRemote(String&& message) = 0;
 
 #if USE(CF)
     // The dispatch block will be scheduled on a global run loop if null is returned.
 
@@ -345,7 +345,7 @@ void RemoteInspector::sendMessageToBackend(const Event& event)
             return;
     }
 
-    connectionToTarget->sendMessageToTarget(event.message.value());
+    connectionToTarget->sendMessageToTarget(String { event.message.value() });
 }
 
 void RemoteInspector::startAutomationSession(const Event& event)
 
@@ -2130,7 +2130,7 @@ JSC_DEFINE_HOST_FUNCTION(functionDollarAgentStart, (JSGlobalObject* globalObject
 
     Thread::create(
         "JSC Agent",
-        [sourceCode = sourceCode.isolatedCopy(), workerPath = workerPath.isolatedCopy(), &didStartLock, &didStartCondition, &didStart] () {
+        [sourceCode = WTFMove(sourceCode).isolatedCopy(), workerPath = WTFMove(workerPath).isolatedCopy(), &didStartLock, &didStartCondition, &didStart] () {
             CommandLine commandLine(CommandLine::CommandLineForWorkers);
             commandLine.m_interactive = false;
             runJSC(
 
@@ -64,11 +64,11 @@ void JSGlobalObjectDebuggable::disconnect(FrontendChannel& frontendChannel)
     m_globalObject.inspectorController().disconnectFrontend(frontendChannel);
 }
 
-void JSGlobalObjectDebuggable::dispatchMessageFromRemote(const String& message)
+void JSGlobalObjectDebuggable::dispatchMessageFromRemote(String&& message)
 {
     JSLockHolder locker(&m_globalObject.vm());
 
-    m_globalObject.inspectorController().dispatchMessageFromFrontend(message);
+    m_globalObject.inspectorController().dispatchMessageFromFrontend(WTFMove(message));
 }
 
 void JSGlobalObjectDebuggable::pauseWaitingForAutomaticInspection()
 
@@ -54,7 +54,7 @@ class JSGlobalObjectDebuggable final : public Inspector::RemoteInspectionTarget
 
     void connect(Inspector::FrontendChannel&, bool isAutomaticConnection = false, bool immediatelyPause = false) final;
     void disconnect(Inspector::FrontendChannel&) final;
-    void dispatchMessageFromRemote(const String& message) final;
+    void dispatchMessageFromRemote(String&& message) final;
 
     bool automaticInspectionAllowed() const final { return true; }
     void pauseWaitingForAutomaticInspection() final;
 
@@ -170,7 +170,7 @@ bool FunctionOverrides::initializeOverrideFor(const SourceCode& origCode, Functi
     String newBody;
     {
         Locker locker { overrides.m_lock };
-        auto it = overrides.m_entries.find(sourceBodyString.isolatedCopy());
+        auto it = overrides.m_entries.find(WTFMove(sourceBodyString).isolatedCopy());
         if (it == overrides.m_entries.end())
             return false;
         newBody = it->value.isolatedCopy();
 
@@ -1,3 +1,131 @@
+2022-03-10  Chris Dumez  <cdumez@apple.com>
+
+        Optimize further the passing of data across threads
+        https://bugs.webkit.org/show_bug.cgi?id=237695
+
+        Reviewed by Geoffrey Garen.
+
+        Optimize further the passing of data across threads by leveraging the optimized
+        version of isolatedCopy() on r-value references whenever possible.
+
+        * Modules/cache/CacheStorageConnection.h:
+        * Modules/cache/DOMCache.cpp:
+        (WebCore::DOMCache::queryCache):
+        * Modules/cache/WorkerCacheStorageConnection.cpp:
+        (WebCore::toCrossThreadRecordData):
+        (WebCore::recordsDataFromRecords):
+        (WebCore::recordsDataOrErrorFromRecords):
+        (WebCore::WorkerCacheStorageConnection::retrieveRecords):
+        (WebCore::WorkerCacheStorageConnection::batchPutOperation):
+        * Modules/cache/WorkerCacheStorageConnection.h:
+        * Modules/entriesapi/DOMFileSystem.cpp:
+        (WebCore::DOMFileSystem::listDirectory):
+        * Modules/mediastream/DetachedRTCDataChannel.h:
+        (WebCore::DetachedRTCDataChannel::DetachedRTCDataChannel):
+        (WebCore::DetachedRTCDataChannel::decode):
+        * Modules/mediastream/RTCDataChannel.cpp:
+        (WebCore::RTCDataChannel::detach):
+        * Modules/mediastream/RTCDataChannel.h:
+        * Modules/notifications/Notification.cpp:
+        (WebCore::Notification::create):
+        (WebCore::Notification::Notification):
+        * Modules/notifications/Notification.h:
+        * Modules/push-api/PushSubscriptionData.cpp:
+        (WebCore::PushSubscriptionData::isolatedCopy const):
+        (WebCore::PushSubscriptionData::isolatedCopy):
+        * Modules/push-api/PushSubscriptionData.h:
+        * Modules/storage/DummyStorageProvider.h:
+        * Modules/storage/StorageConnection.h:
+        * Modules/storage/StorageManager.cpp:
+        (WebCore::StorageManager::persisted):
+        (WebCore::StorageManager::fileSystemAccessGetDirectory):
+        * Modules/storage/WorkerStorageConnection.cpp:
+        (WebCore::WorkerStorageConnection::getPersisted):
+        (WebCore::WorkerStorageConnection::fileSystemGetDirectory):
+        * Modules/storage/WorkerStorageConnection.h:
+        * Modules/webdatabase/ChangeVersionWrapper.cpp:
+        (WebCore::ChangeVersionWrapper::ChangeVersionWrapper):
+        * Modules/webdatabase/ChangeVersionWrapper.h:
+        (WebCore::ChangeVersionWrapper::create):
+        * Modules/webdatabase/Database.cpp:
+        (WebCore::Database::changeVersion):
+        * Modules/webdatabase/Database.h:
+        * Modules/webdatabase/DatabaseTracker.cpp:
+        (WebCore::DatabaseTracker::addOpenDatabase):
+        * Modules/webdatabase/SQLError.h:
+        (WebCore::SQLError::create):
+        (WebCore::SQLError::SQLError):
+        * Modules/websockets/ThreadableWebSocketChannel.h:
+        * Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp:
+        (WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveMessage):
+        (WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveMessageError):
+        * Modules/websockets/ThreadableWebSocketChannelClientWrapper.h:
+        * Modules/websockets/WebSocket.cpp:
+        (WebCore::WebSocket::didReceiveMessage):
+        (WebCore::WebSocket::didReceiveMessageError):
+        * Modules/websockets/WebSocket.h:
+        * Modules/websockets/WebSocketChannel.cpp:
+        (WebCore::WebSocketChannel::fail):
+        (WebCore::WebSocketChannel::didFailSocketStream):
+        (WebCore::WebSocketChannel::processFrame):
+        * Modules/websockets/WebSocketChannel.h:
+        * Modules/websockets/WebSocketChannelClient.h:
+        * Modules/websockets/WebSocketHandshake.cpp:
+        (WebCore::WebSocketHandshake::setURL): Deleted.
+        * Modules/websockets/WorkerThreadableWebSocketChannel.cpp:
+        (WebCore::WorkerThreadableWebSocketChannel::fail):
+        (WebCore::WorkerThreadableWebSocketChannel::Peer::fail):
+        (WebCore::WorkerThreadableWebSocketChannel::Peer::didReceiveMessage):
+        (WebCore::WorkerThreadableWebSocketChannel::Peer::didReceiveMessageError):
+        (WebCore::WorkerThreadableWebSocketChannel::Bridge::connect):
+        (WebCore::WorkerThreadableWebSocketChannel::Bridge::fail):
+        * Modules/websockets/WorkerThreadableWebSocketChannel.h:
+        * dom/ExceptionData.h:
+        (WebCore::ExceptionData::toException const):
+        (WebCore::ExceptionData::toException):
+        * inspector/agents/InspectorWorkerAgent.cpp:
+        (WebCore::InspectorWorkerAgent::sendMessageFromWorkerToFrontend):
+        * inspector/agents/InspectorWorkerAgent.h:
+        * page/CacheStorageProvider.h:
+        * page/PageDebuggable.cpp:
+        (WebCore::PageDebuggable::dispatchMessageFromRemote):
+        * page/PageDebuggable.h:
+        * workers/WorkerInspectorProxy.cpp:
+        (WebCore::WorkerInspectorProxy::sendMessageFromWorkerToFrontend):
+        * workers/WorkerInspectorProxy.h:
+        * workers/WorkerMessagingProxy.cpp:
+        (WebCore::WorkerMessagingProxy::postMessageToDebugger):
+        * workers/service/SWClientConnection.cpp:
+        (WebCore::SWClientConnection::jobRejectedInServer):
+        (WebCore::SWClientConnection::registrationJobResolvedInServer):
+        * workers/service/SWClientConnection.h:
+        * workers/service/ServiceWorkerClientData.cpp:
+        (WebCore::ServiceWorkerClientData::isolatedCopy const):
+        (WebCore::ServiceWorkerClientData::isolatedCopy):
+        * workers/service/ServiceWorkerClientData.h:
+        * workers/service/ServiceWorkerContextData.h:
+        (WebCore::ServiceWorkerContextData::ImportedScript::isolatedCopy const):
+        (WebCore::ServiceWorkerContextData::ImportedScript::isolatedCopy):
+        * workers/service/ServiceWorkerRegistration.cpp:
+        (WebCore::ServiceWorkerRegistration::showNotification):
+        * workers/service/ServiceWorkerRegistration.h:
+        * workers/service/ServiceWorkerRegistrationOptions.cpp:
+        (WebCore::ServiceWorkerRegistrationOptions::isolatedCopy const):
+        (WebCore::ServiceWorkerRegistrationOptions::isolatedCopy):
+        * workers/service/ServiceWorkerRegistrationOptions.h:
+        * workers/service/context/ServiceWorkerDebuggable.cpp:
+        (WebCore::ServiceWorkerDebuggable::dispatchMessageFromRemote):
+        * workers/service/context/ServiceWorkerDebuggable.h:
+        * workers/service/context/ServiceWorkerInspectorProxy.cpp:
+        (WebCore::ServiceWorkerInspectorProxy::sendMessageToWorker):
+        (WebCore::ServiceWorkerInspectorProxy::sendMessageFromWorkerToFrontend):
+        * workers/service/context/ServiceWorkerInspectorProxy.h:
+        * workers/service/context/ServiceWorkerThreadProxy.cpp:
+        (WebCore::ServiceWorkerThreadProxy::postMessageToDebugger):
+        (WebCore::ServiceWorkerThreadProxy::startFetch):
+        * workers/service/server/RegistrationDatabase.cpp:
+        (WebCore::RegistrationDatabase::importRecords):
+
 2022-03-10  Antoine Quint  <graouts@webkit.org>
 
         [web-animations] grid-template-areas should support discrete animation
Original file line number	Diff line number	Diff line change
`@@ -72,7 +72,7 @@ bool RemoteConnectionToTarget::setup(bool isAutomaticInspection, bool automatica`
`72`	`72`	`return true;`
`73`	`73`	`}`
`74`	`74`
`75`		`-void RemoteConnectionToTarget::sendMessageToTarget(const String& message)`
	`75`	`+void RemoteConnectionToTarget::sendMessageToTarget(String&& message)`
`76`	`76`	`{`
`77`	`77`	`RemoteControllableTarget* class="pl-c1">nullptr;`
`78`	`78`	`{`
`@@ -82,7 +82,7 @@ void RemoteConnectionToTarget::sendMessageToTarget(const String& message)`
`82`	`82`	`>`
`83`	`83`	`}`
`84`	`84`
`85`		`- target->dispatchMessageFromRemote(message);`
	`85`	`+ target->dispatchMessageFromRemote(WTFMove(message));`
`86`	`86`	`}`
`87`	`87`
`88`	`88`	`void RemoteConnectionToTarget::close()`
Original file line number	Diff line number	Diff line change
`@@ -345,7 +345,7 @@ void RemoteInspector::sendMessageToBackend(const Event& event)`
`345`	`345`	`return;`
`346`	`346`	`}`
`347`	`347`
`348`		`- connectionToTarget->sendMessageToTarget(event.message.value());`
	`348`	`+ connectionToTarget->sendMessageToTarget(String { event.message.value() });`
`349`	`349`	`}`
`350`	`350`
`351`	`351`	`void RemoteInspector::startAutomationSession(const Event& event)`
Original file line number	Diff line number	Diff line change
`@@ -64,11 +64,11 @@ void JSGlobalObjectDebuggable::disconnect(FrontendChannel& frontendChannel)`
`64`	`64`	`m_globalObject.inspectorController().disconnectFrontend(frontendChannel);`
`65`	`65`	`}`
`66`	`66`
`67`		`-void JSGlobalObjectDebuggable::dispatchMessageFromRemote(const String& message)`
	`67`	`+void JSGlobalObjectDebuggable::dispatchMessageFromRemote(String&& message)`
`68`	`68`	`{`
`69`	`69`	`JSLockHolder locker(&m_globalObject.vm());`
`70`	`70`
`71`		`- m_globalObject.inspectorController().dispatchMessageFromFrontend(message);`
	`71`	`+ m_globalObject.inspectorController().dispatchMessageFromFrontend(WTFMove(message));`
`72`	`72`	`}`
`73`	`73`
`74`	`74`	`void JSGlobalObjectDebuggable::pauseWaitingForAutomaticInspection()`
Original file line number	Diff line number	Diff line change
`@@ -170,7 +170,7 @@ bool FunctionOverrides::initializeOverrideFor(const SourceCode& origCode, Functi`
`170`	`170`	`String newBody;`
`171`	`171`	`{`
`172`	`172`	`Locker locker { overrides.m_lock };`
`173`		`- auto it = overrides.m_entries.find(sourceBodyString.isolatedCopy());`
	`173`	`+ auto it = overrides.m_entries.find(WTFMove(sourceBodyString).isolatedCopy());`
`174`	`174`	`if (it == overrides.m_entries.end())`
`175`	`175`	`return false;`
`176`	`176`	`newBody = it->value.isolatedCopy();`