Skip to content

Commit 15d8d43

Browse files
dcroussodcrousso
committed
Web Inspector: rename queryObjects to queryInstances for clarity
https://bugs.webkit.org/show_bug.cgi?id=200520 Reviewed by Brian Burg. Source/JavaScriptCore: * inspector/InjectedScriptSource.js: (queryInstances): Added. (queryObjects): * inspector/JSInjectedScriptHost.h: * inspector/JSInjectedScriptHost.cpp: (Inspector::JSInjectedScriptHost::queryInstances): Added. (Inspector::JSInjectedScriptHost::queryObjects): Deleted. * inspector/JSInjectedScriptHostPrototype.cpp: (Inspector::JSInjectedScriptHostPrototype::finishCreation): (Inspector::jsInjectedScriptHostPrototypeFunctionQueryInstances): Added. (Inspector::jsInjectedScriptHostPrototypeFunctionQueryObjects): Deleted. Source/WebCore: Test: inspector/console/queryInstances.html * inspector/CommandLineAPIModuleSource.js: (CommandLineAPIImpl.prototype.queryInstances): Added. (CommandLineAPIImpl.prototype.queryObjects): Source/WebInspectorUI: * UserInterface/Controllers/JavaScriptRuntimeCompletionProvider.js: LayoutTests: * inspector/console/queryInstances.html: Renamed from LayoutTests/inspector/console/queryObjects.html. * inspector/console/queryInstances-expected.txt: Renamed from LayoutTests/inspector/console/queryObjects-expected.txt. * http/tests/inspector/console/cross-domain-inspected-node-access-expected.txt: Canonical link: https://commits.webkit.org/214317@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@248434 268f45cc-cd09-0410-ab3c-d52691b4dbfc
1 parent 21aada2 commit 15d8d43

14 files changed

Lines changed: 438 additions & 374 deletions

File tree

‎LayoutTests/ChangeLog‎

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,15 @@
1+
2019-08-08 Devin Rousso <drousso@apple.com>
2+
3+
Web Inspector: rename `queryObjects` to `queryInstances` for clarity
4+
https://bugs.webkit.org/show_bug.cgi?id=200520
5+
6+
Reviewed by Brian Burg.
7+
8+
* inspector/console/queryInstances.html: Renamed from LayoutTests/inspector/console/queryObjects.html.
9+
* inspector/console/queryInstances-expected.txt: Renamed from LayoutTests/inspector/console/queryObjects-expected.txt.
10+
11+
* http/tests/inspector/console/cross-domain-inspected-node-access-expected.txt:
12+
113
2019-08-08 Wenson Hsieh <wenson_hsieh@apple.com>
214

315
[iOS 13] Taps that interrupt momentum scrolling are recognized as clicks

‎LayoutTests/http/tests/inspector/dom/cross-domain-inspected-node-access-expected.txt‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
CONSOLE MESSAGE: line 49: Blocked a frame with origin "http://127.0.0.1:8000" from accessing a frame with origin "http://localhost:8000". Protocols, domains, and ports must match.
2-
CONSOLE MESSAGE: line 49: Blocked a frame with origin "http://localhost:8000" from accessing a frame with origin "http://127.0.0.1:8000". Protocols, domains, and ports must match.
1+
CONSOLE MESSAGE: line 50: Blocked a frame with origin "http://127.0.0.1:8000" from accessing a frame with origin "http://localhost:8000". Protocols, domains, and ports must match.
2+
CONSOLE MESSAGE: line 50: Blocked a frame with origin "http://localhost:8000" from accessing a frame with origin "http://127.0.0.1:8000". Protocols, domains, and ports must match.
33
Test that code evaluated in the main frame cannot access $0 that resolves to a node in a frame from a different domain. Bug 105423.
44

55

‎LayoutTests/inspector/console/queryInstances-expected.txt‎

Lines changed: 342 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,342 @@
1+
Tests for the `queryInstances` function in the Command Line API.
2+
3+
4+
== Running test suite: CommandLineAPI.queryInstances
5+
-- Running test case: CommandLineAPI.queryInstances.Instances.ClassA
6+
PASS: The result should be an object.
7+
PASS: The result should be an array object.
8+
PASS: The result should have 0 items.
9+
10+
-- Running test case: CommandLineAPI.queryInstances.ClassA
11+
PASS: The result should be an object.
12+
PASS: The result should be an array object.
13+
PASS: The result should have 5 items.
14+
[ClassA, ClassB, ClassB, ClassC, ClassC]
15+
16+
-- Running test case: CommandLineAPI.queryInstances.ClassA.prototype
17+
PASS: The result should be an object.
18+
PASS: The result should be an array object.
19+
PASS: The result should have 5 items.
20+
[ClassA, ClassB, ClassB, ClassC, ClassC]
21+
22+
-- Running test case: CommandLineAPI.queryInstances.Instances.ClassB
23+
PASS: The result should be an object.
24+
PASS: The result should be an array object.
25+
PASS: The result should have 0 items.
26+
27+
-- Running test case: CommandLineAPI.queryInstances.ClassB
28+
PASS: The result should be an object.
29+
PASS: The result should be an array object.
30+
PASS: The result should have 3 items.
31+
[ClassB, ClassC, ClassC]
32+
33+
-- Running test case: CommandLineAPI.queryInstances.ClassB.prototype
34+
PASS: The result should be an object.
35+
PASS: The result should be an array object.
36+
PASS: The result should have 3 items.
37+
[ClassB, ClassC, ClassC]
38+
39+
-- Running test case: CommandLineAPI.queryInstances.Instances.ClassC
40+
PASS: The result should be an object.
41+
PASS: The result should be an array object.
42+
PASS: The result should have 0 items.
43+
44+
-- Running test case: CommandLineAPI.queryInstances.ClassC
45+
PASS: The result should be an object.
46+
PASS: The result should be an array object.
47+
PASS: The result should have 1 items.
48+
[ClassC]
49+
50+
-- Running test case: CommandLineAPI.queryInstances.ClassC.prototype
51+
PASS: The result should be an object.
52+
PASS: The result should be an array object.
53+
PASS: The result should have 1 items.
54+
[ClassC]
55+
56+
-- Running test case: CommandLineAPI.queryInstances.HTMLDocument
57+
PASS: The result should be an object.
58+
PASS: The result should be an array object.
59+
PASS: The result should have 1 items.
60+
[#document]
61+
62+
-- Running test case: CommandLineAPI.queryInstances.HTMLBodyElement
63+
PASS: The result should be an object.
64+
PASS: The result should be an array object.
65+
PASS: The result should have 1 items.
66+
[<body>]
67+
68+
-- Running test case: CommandLineAPI.queryInstances.HTMLImageElement
69+
PASS: The result should be an object.
70+
PASS: The result should be an array object.
71+
PASS: The result should have 0 items.
72+
73+
-- Running test case: CommandLineAPI.queryInstances.objectWithDisallowedPrototypeGetter
74+
PASS: The result should be an object.
75+
PASS: The result should be an array object.
76+
PASS: The result should have 0 items.
77+
78+
-- Running test case: CommandLineAPI.queryInstances.objectWithErrorPrototypeGetter
79+
PASS: The result should be an object.
80+
PASS: The result should be an array object.
81+
PASS: The result should have 0 items.
82+
83+
-- Running test case: CommandLineAPI.queryInstances.undefined
84+
PASS: Calling "queryInstances" with "undefined" should throw an exception.
85+
TypeError: queryInstances first argument must be an object.
86+
87+
-- Running test case: CommandLineAPI.queryInstances.null
88+
PASS: Calling "queryInstances" with "null" should throw an exception.
89+
TypeError: queryInstances first argument must be an object.
90+
91+
-- Running test case: CommandLineAPI.queryInstances.Infinity
92+
PASS: Calling "queryInstances" with "Infinity" should throw an exception.
93+
TypeError: queryInstances first argument must be an object.
94+
95+
-- Running test case: CommandLineAPI.queryInstances.NaN
96+
PASS: Calling "queryInstances" with "NaN" should throw an exception.
97+
TypeError: queryInstances first argument must be an object.
98+
99+
-- Running test case: CommandLineAPI.queryInstances.1
100+
PASS: Calling "queryInstances" with "1" should throw an exception.
101+
TypeError: queryInstances first argument must be an object.
102+
103+
-- Running test case: CommandLineAPI.queryInstances.true
104+
PASS: Calling "queryInstances" with "true" should throw an exception.
105+
TypeError: queryInstances first argument must be an object.
106+
107+
-- Running test case: CommandLineAPI.queryInstances."test"
108+
PASS: Calling "queryInstances" with ""test"" should throw an exception.
109+
TypeError: queryInstances first argument must be an object.
110+
111+
-- Running test case: CommandLineAPI.queryInstances.Instances.Symbol
112+
PASS: Calling "queryInstances" with "Instances.Symbol" should throw an exception.
113+
TypeError: queryInstances first argument must be an object.
114+
115+
-- Running test case: CommandLineAPI.queryInstances.Symbol
116+
PASS: The result should be an object.
117+
PASS: The result should be an array object.
118+
PASS: The result should have 0 items.
119+
120+
-- Running test case: CommandLineAPI.queryInstances.Symbol.prototype
121+
PASS: The result should be an object.
122+
PASS: The result should be an array object.
123+
PASS: The result should have 0 items.
124+
125+
-- Running test case: CommandLineAPI.queryInstances.Proxies.constructor
126+
PASS: The result should be an object.
127+
PASS: The result should be an array object.
128+
PASS: The result should have 0 items.
129+
130+
-- Running test case: CommandLineAPI.queryInstances.Proxies.basic
131+
PASS: Calling "queryInstances" with "Proxies.basic" should throw an exception.
132+
TypeError: queryInstances cannot be called with a Proxy.
133+
134+
-- Running test case: CommandLineAPI.queryInstances.Proxies.object
135+
PASS: Calling "queryInstances" with "Proxies.object" should throw an exception.
136+
TypeError: queryInstances cannot be called with a Proxy.
137+
138+
-- Running test case: CommandLineAPI.queryInstances.Proxies.tricky
139+
PASS: Calling "queryInstances" with "Proxies.tricky" should throw an exception.
140+
TypeError: queryInstances cannot be called with a Proxy.
141+
142+
-- Running test case: CommandLineAPI.queryInstances.Instances.Object
143+
PASS: The result should be an object.
144+
PASS: The result should be an array object.
145+
PASS: The result should have 0 items.
146+
147+
-- Running test case: CommandLineAPI.queryInstances.Object
148+
PASS: Calling "queryInstances" with "Object" should throw an exception.
149+
TypeError: queryInstances cannot be called with Object.
150+
151+
-- Running test case: CommandLineAPI.queryInstances.Object.prototype
152+
PASS: Calling "queryInstances" with "Object.prototype" should throw an exception.
153+
TypeError: queryInstances cannot be called with Object.
154+
155+
-- Running test case: CommandLineAPI.queryInstances.Instances.Function
156+
PASS: The result should be an object.
157+
PASS: The result should be an array object.
158+
PASS: The result should have 0 items.
159+
160+
-- Running test case: CommandLineAPI.queryInstances.Function
161+
PASS: Calling "queryInstances" with "Function" should throw an exception.
162+
TypeError: queryInstances cannot be called with Function.
163+
164+
-- Running test case: CommandLineAPI.queryInstances.Function.prototype
165+
PASS: Calling "queryInstances" with "Function.prototype" should throw an exception.
166+
TypeError: queryInstances cannot be called with Function.
167+
168+
-- Running test case: CommandLineAPI.queryInstances.Instances.Array
169+
PASS: The result should be an object.
170+
PASS: The result should be an array object.
171+
PASS: The result should have 0 items.
172+
173+
-- Running test case: CommandLineAPI.queryInstances.Array
174+
PASS: Calling "queryInstances" with "Array" should throw an exception.
175+
TypeError: queryInstances cannot be called with Array.
176+
177+
-- Running test case: CommandLineAPI.queryInstances.Array.prototype
178+
PASS: Calling "queryInstances" with "Array.prototype" should throw an exception.
179+
TypeError: queryInstances cannot be called with Array.
180+
181+
-- Running test case: CommandLineAPI.queryInstances.Instances.Map
182+
PASS: The result should be an object.
183+
PASS: The result should be an array object.
184+
PASS: The result should have 0 items.
185+
186+
-- Running test case: CommandLineAPI.queryInstances.Map
187+
PASS: Calling "queryInstances" with "Map" should throw an exception.
188+
TypeError: queryInstances cannot be called with Map.
189+
190+
-- Running test case: CommandLineAPI.queryInstances.Map.prototype
191+
PASS: Calling "queryInstances" with "Map.prototype" should throw an exception.
192+
TypeError: queryInstances cannot be called with Map.
193+
194+
-- Running test case: CommandLineAPI.queryInstances.Instances.Set
195+
PASS: The result should be an object.
196+
PASS: The result should be an array object.
197+
PASS: The result should have 0 items.
198+
199+
-- Running test case: CommandLineAPI.queryInstances.Set
200+
PASS: Calling "queryInstances" with "Set" should throw an exception.
201+
TypeError: queryInstances cannot be called with Set.
202+
203+
-- Running test case: CommandLineAPI.queryInstances.Set.prototype
204+
PASS: Calling "queryInstances" with "Set.prototype" should throw an exception.
205+
TypeError: queryInstances cannot be called with Set.
206+
207+
-- Running test case: CommandLineAPI.queryInstances.Instances.Promise
208+
PASS: The result should be an object.
209+
PASS: The result should be an array object.
210+
PASS: The result should have 0 items.
211+
212+
-- Running test case: CommandLineAPI.queryInstances.Promise
213+
PASS: Calling "queryInstances" with "Promise" should throw an exception.
214+
TypeError: queryInstances cannot be called with Promise.
215+
216+
-- Running test case: CommandLineAPI.queryInstances.Promise.prototype
217+
PASS: Calling "queryInstances" with "Promise.prototype" should throw an exception.
218+
TypeError: queryInstances cannot be called with Promise.
219+
220+
-- Running test case: CommandLineAPI.queryInstances.FunctionPrototypeReplacement
221+
PASS: Calling "queryInstances" with "FunctionPrototypeReplacement" should throw an exception.
222+
TypeError: queryInstances cannot be called with Function.
223+
224+
-- Running test case: CommandLineAPI.queryInstances.FunctionPrototypeReplacement.prototype
225+
PASS: Calling "queryInstances" with "FunctionPrototypeReplacement.prototype" should throw an exception.
226+
TypeError: queryInstances cannot be called with Function.
227+
228+
-- Running test case: CommandLineAPI.queryInstances.ArrayPrototypeReplacement
229+
PASS: Calling "queryInstances" with "ArrayPrototypeReplacement" should throw an exception.
230+
TypeError: queryInstances cannot be called with Array.
231+
232+
-- Running test case: CommandLineAPI.queryInstances.ArrayPrototypeReplacement.prototype
233+
PASS: Calling "queryInstances" with "ArrayPrototypeReplacement.prototype" should throw an exception.
234+
TypeError: queryInstances cannot be called with Array.
235+
236+
-- Running test case: CommandLineAPI.queryInstances.MapPrototypeReplacement
237+
PASS: Calling "queryInstances" with "MapPrototypeReplacement" should throw an exception.
238+
TypeError: queryInstances cannot be called with Map.
239+
240+
-- Running test case: CommandLineAPI.queryInstances.MapPrototypeReplacement.prototype
241+
PASS: Calling "queryInstances" with "MapPrototypeReplacement.prototype" should throw an exception.
242+
TypeError: queryInstances cannot be called with Map.
243+
244+
-- Running test case: CommandLineAPI.queryInstances.SetPrototypeReplacement
245+
PASS: Calling "queryInstances" with "SetPrototypeReplacement" should throw an exception.
246+
TypeError: queryInstances cannot be called with Set.
247+
248+
-- Running test case: CommandLineAPI.queryInstances.SetPrototypeReplacement.prototype
249+
PASS: Calling "queryInstances" with "SetPrototypeReplacement.prototype" should throw an exception.
250+
TypeError: queryInstances cannot be called with Set.
251+
252+
-- Running test case: CommandLineAPI.queryInstances.PromisePrototypeReplacement
253+
PASS: Calling "queryInstances" with "PromisePrototypeReplacement" should throw an exception.
254+
TypeError: queryInstances cannot be called with Promise.
255+
256+
-- Running test case: CommandLineAPI.queryInstances.PromisePrototypeReplacement.prototype
257+
PASS: Calling "queryInstances" with "PromisePrototypeReplacement.prototype" should throw an exception.
258+
TypeError: queryInstances cannot be called with Promise.
259+
260+
-- Running test case: CommandLineAPI.queryInstances.Instances.Boolean
261+
PASS: The result should be an object.
262+
PASS: The result should be an array object.
263+
PASS: The result should have 0 items.
264+
265+
-- Running test case: CommandLineAPI.queryInstances.Boolean
266+
PASS: The result should be an object.
267+
PASS: The result should be an array object.
268+
PASS: The result should have at least 1 item.
269+
270+
-- Running test case: CommandLineAPI.queryInstances.Boolean.prototype
271+
PASS: The result should be an object.
272+
PASS: The result should be an array object.
273+
PASS: The result should have at least 1 item.
274+
275+
-- Running test case: CommandLineAPI.queryInstances.Instances.String
276+
PASS: The result should be an object.
277+
PASS: The result should be an array object.
278+
PASS: The result should have 0 items.
279+
280+
-- Running test case: CommandLineAPI.queryInstances.String
281+
PASS: The result should be an object.
282+
PASS: The result should be an array object.
283+
PASS: The result should have at least 1 item.
284+
285+
-- Running test case: CommandLineAPI.queryInstances.String.prototype
286+
PASS: The result should be an object.
287+
PASS: The result should be an array object.
288+
PASS: The result should have at least 1 item.
289+
290+
-- Running test case: CommandLineAPI.queryInstances.Instances.Number
291+
PASS: The result should be an object.
292+
PASS: The result should be an array object.
293+
PASS: The result should have 0 items.
294+
295+
-- Running test case: CommandLineAPI.queryInstances.Number
296+
PASS: The result should be an object.
297+
PASS: The result should be an array object.
298+
PASS: The result should have at least 1 item.
299+
300+
-- Running test case: CommandLineAPI.queryInstances.Number.prototype
301+
PASS: The result should be an object.
302+
PASS: The result should be an array object.
303+
PASS: The result should have at least 1 item.
304+
305+
-- Running test case: CommandLineAPI.queryInstances.Instances.Date
306+
PASS: The result should be an object.
307+
PASS: The result should be an array object.
308+
PASS: The result should have 0 items.
309+
310+
-- Running test case: CommandLineAPI.queryInstances.Date
311+
PASS: The result should be an object.
312+
PASS: The result should be an array object.
313+
PASS: The result should have at least 1 item.
314+
315+
-- Running test case: CommandLineAPI.queryInstances.Date.prototype
316+
PASS: The result should be an object.
317+
PASS: The result should be an array object.
318+
PASS: The result should have at least 1 item.
319+
320+
-- Running test case: CommandLineAPI.queryInstances.Instances.RegExp
321+
PASS: The result should be an object.
322+
PASS: The result should be an array object.
323+
PASS: The result should have 0 items.
324+
325+
-- Running test case: CommandLineAPI.queryInstances.RegExp
326+
PASS: The result should be an object.
327+
PASS: The result should be an array object.
328+
PASS: The result should have at least 1 item.
329+
330+
-- Running test case: CommandLineAPI.queryInstances.RegExp.prototype
331+
PASS: The result should be an object.
332+
PASS: The result should be an array object.
333+
PASS: The result should have at least 1 item.
334+
335+
-- Running test case: CommandLineAPI.queryInstances.GC
336+
PASS: Should be 1 ClassC instance.
337+
Clearing instances...
338+
PASS: Should now be 0 ClassC instances.
339+
340+
-- Running test case: CommandLineAPI.queryInstances.NoParameter
341+
PASS: The result should be undefined.
342+

0 commit comments

Comments
 (0)