Skip to content

fix(cli): include displayName in session ls --json - #6114

Open
haynoikonike wants to merge 1 commit into
OrchestratorInc:mainfrom
haynoikonike:fix/session-ls-json-display-name
Open

haynoikonike wants to merge 1 commit into
OrchestratorInc:mainfrom
haynoikonike:fix/session-ls-json-display-name

Conversation

@haynoikonike

Copy link
Copy Markdown

Code changes: +2 -0

Tests: +4 -0

Others: +0 -0

What

ao session ls --json now includes each session's displayName (omitted when empty), matching ao session get --json.

Why

Fixes #6113. sessionListEntry had no DisplayName field, so the name set with ao spawn --name (and shown in the sidebar) was dropped from the list JSON even though the session DTO the CLI receives already carries it. Tools supervising many sessions from outside AO had to call get per session to tell them apart.

How

  • Add DisplayName string \json:"displayName,omitempty"`tosessionListEntryand copy it from the session DTO when building list entries. Additive,omitempty`, so existing consumers are unaffected.
  • No change to the table (non-JSON) output.

Testing

  • TestSessionList_JSONOutputDecodes now asserts the fixture's displayName comes through; without the fix the test does not compile (field missing).
  • go vet ./... — pass
  • go test -race -count=1 ./internal/cli/... — pass
  • go test -tags e2e -count=1 ./internal/cli/... — pass
  • Not run locally: the full go test -race ./... suite (~20 min); relying on CI for it.

Checklist

  • Branched from main
  • One focused change; links the related issue
  • Follows AGENTS.md conventions and PR hygiene
  • Tests added/updated for user-visible behavior
  • Relevant CI checks pass for the area touched (full Go suite left to CI, see Testing)

@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

🏆 Review leaderboard

Sep 24, 2026–Oct 1, 2026 · UTC

Rank Reviewer PRs reviewed Review rounds PR comments
🥇 @illegalcall @illegalcall 27 49 8
🥈 @nikhilachale @nikhilachale 25 52 8
🥉 @ronishrohan @ronishrohan 23 33 9
4 @Prasad-D-Ware @Prasad-D-Ware 15 33 3
5 @codebanditssss @codebanditssss 11 15 1
6 @mohakchakraborty2004 @mohakchakraborty2004 7 7 4
7 @Annieeeee11 @Annieeeee11 6 14 5
8 @neversettle17-101 @neversettle17-101 6 7 5
9 @harshitsinghbhandari @harshitsinghbhandari 5 7 0
10 @Vaibhaav-Tiwari @Vaibhaav-Tiwari 4 4 2

Ranked by distinct external PRs reviewed, then review rounds, then PR comments. Self-activity and bot activity are excluded.

Show 8 more reviewers
Rank Reviewer PRs reviewed Review rounds PR comments
11 @Rishet11 @Rishet11 2 2 9
12 @Pritom14 @Pritom14 2 2 2
13 @Pulkit7070 @Pulkit7070 2 2 1
14 @somewherelostt @somewherelostt 1 3 2
15 @AgentWrapper @AgentWrapper 1 1 0
16 @aprv10 @aprv10 1 1 0
17 @Ayash-Bera @Ayash-Bera 1 1 0
18 @LaibaFirdouse @LaibaFirdouse 1 1 0

@i-trytoohard i-trytoohard added bug Something isn't working comp/cli Cobra CLI and daemon-client behavior. labels Oct 1, 2026
@i-trytoohard i-trytoohard added this to the Agents & orchestration milestone Oct 1, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working comp/cli Cobra CLI and daemon-client behavior.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ao session ls --json omits displayName (session get --json includes it)

2 participants