fix(cli): include displayName in session ls --json - #6114
Open
haynoikonike wants to merge 1 commit into
Open
haynoikonike wants to merge 1 commit into
haynoikonike wants to merge 1 commit into
Conversation
Contributor
🏆 Review leaderboardSep 24, 2026–Oct 1, 2026 · UTC
Ranked by distinct external PRs reviewed, then review rounds, then PR comments. Self-activity and bot activity are excluded. Show 8 more reviewers
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code changes: +2 -0
Tests: +4 -0
Others: +0 -0
What
ao session ls --jsonnow includes each session'sdisplayName(omitted when empty), matchingao session get --json.Why
Fixes #6113.
sessionListEntryhad noDisplayNamefield, so the name set withao spawn --name(and shown in the sidebar) was dropped from the list JSON even though the session DTO the CLI receives already carries it. Tools supervising many sessions from outside AO had to callgetper session to tell them apart.How
DisplayName string \json:"displayName,omitempty"`tosessionListEntryand copy it from the session DTO when building list entries. Additive,omitempty`, so existing consumers are unaffected.Testing
TestSessionList_JSONOutputDecodesnow asserts the fixture'sdisplayNamecomes through; without the fix the test does not compile (field missing).go vet ./...— passgo test -race -count=1 ./internal/cli/...— passgo test -tags e2e -count=1 ./internal/cli/...— passgo test -race ./...suite (~20 min); relying on CI for it.Checklist
main