Skip to content

Commit bebb956

Browse files
committed
Update all headers for 73.1.13, fix issues.
1 parent 98e770e commit bebb956

128 files changed

Lines changed: 24921 additions & 1948 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎src/cefpython.pyx‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -588,8 +588,6 @@ def Initialize(applicationSettings=None, commandLineSwitches=None, **kwargs):
588588
else:
589589
# multi_threaded_message_loop_windows overrides multi_threaded_message_loop
590590
application_settings["multi_threaded_message_loop"] = application_settings["multi_threaded_message_loop_windows"]
591-
if not "single_process" in application_settings:
592-
application_settings["single_process"] = False
593591
# ------------------------------------------------------------------------
594592

595593
# ------------------------------------------------------------------------

‎src/client_handler/render_handler.cpp‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,11 @@ bool RenderHandler::GetRootScreenRect(CefRefPtr<CefBrowser> browser,
1313
}
1414

1515

16-
bool RenderHandler::GetViewRect(CefRefPtr<CefBrowser> browser,
16+
void RenderHandler::GetViewRect(CefRefPtr<CefBrowser> browser,
1717
CefRect& rect)
1818
{
1919
REQUIRE_UI_THREAD();
20-
return RenderHandler_GetViewRect(browser, rect);
20+
RenderHandler_GetViewRect(browser, rect);
2121
}
2222

2323

‎src/client_handler/render_handler.h‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ class RenderHandler : public CefRenderHandler,
2222
bool GetRootScreenRect(CefRefPtr<CefBrowser> browser,
2323
CefRect& rect) override;
2424

25-
bool GetViewRect(CefRefPtr<CefBrowser> browser,
25+
void GetViewRect(CefRefPtr<CefBrowser> browser,
2626
CefRect& rect) override;
2727

2828
bool GetScreenPoint(CefRefPtr<CefBrowser> browser,

‎src/extern/cef/cef_types.pxd‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ cdef extern from "include/internal/cef_types.h":
3434

3535
ctypedef struct CefSettings:
3636
cef_string_t accept_language_list
37-
int single_process
3837
cef_string_t browser_subprocess_path
3938
int command_line_args_disabled
4039
cef_string_t cache_path

‎src/handlers/render_handler.pyx‎

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ cdef public cpp_bool RenderHandler_GetRootScreenRect(
5151
(exc_type, exc_value, exc_trace) = sys.exc_info()
5252
sys.excepthook(exc_type, exc_value, exc_trace)
5353

54-
cdef public cpp_bool RenderHandler_GetViewRect(
54+
cdef public void RenderHandler_GetViewRect(
5555
CefRefPtr[CefBrowser] cefBrowser,
5656
CefRect& cefRect
5757
) except * with gil:
@@ -69,11 +69,6 @@ cdef public cpp_bool RenderHandler_GetViewRect(
6969
cefRect.y = pyRect[1]
7070
cefRect.width = pyRect[2]
7171
cefRect.height = pyRect[3]
72-
return True
73-
else:
74-
return False
75-
else:
76-
return False
7772
except:
7873
(exc_type, exc_value, exc_trace) = sys.exc_info()
7974
sys.excepthook(exc_type, exc_value, exc_trace)

‎src/include/base/cef_build.h‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -162,6 +162,16 @@
162162
#define ALLOW_UNUSED_LOCAL(x) false ? (void)x : (void)0
163163
#endif
164164

165+
// Sanitizers annotations.
166+
#if defined(__has_attribute)
167+
#if __has_attribute(no_sanitize)
168+
#define NO_SANITIZE(what) __attribute__((no_sanitize(what)))
169+
#endif
170+
#endif
171+
#if !defined(NO_SANITIZE)
172+
#define NO_SANITIZE(what)
173+
#endif
174+
165175
#endif // !USING_CHROMIUM_INCLUDES
166176

167177
// Annotate a virtual method indicating it must be overriding a virtual method

‎src/include/base/cef_ref_counted.h‎

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@
5151
#include "include/base/cef_atomic_ref_count.h"
5252
#include "include/base/cef_build.h"
5353
#include "include/base/cef_logging.h"
54-
#include "include/base/cef_thread_collision_warner.h"
54+
#include "include/base/cef_macros.h"
5555

5656
namespace base {
5757

@@ -60,6 +60,7 @@ namespace cef_subtle {
6060
class RefCountedBase {
6161
public:
6262
bool HasOneRef() const { return ref_count_ == 1; }
63+
bool HasAtLeastOneRef() const { return ref_count_ >= 1; }
6364

6465
protected:
6566
RefCountedBase()
@@ -78,10 +79,6 @@ class RefCountedBase {
7879
}
7980

8081
void AddRef() const {
81-
// TODO(maruel): Add back once it doesn't assert 500 times/sec.
82-
// Current thread books the critical section "AddRelease"
83-
// without release it.
84-
// DFAKE_SCOPED_LOCK_THREAD_LOCKED(add_release_);
8582
#if DCHECK_IS_ON()
8683
DCHECK(!in_dtor_);
8784
#endif
@@ -90,10 +87,6 @@ class RefCountedBase {
9087

9188
// Returns true if the object should self-delete.
9289
bool Release() const {
93-
// TODO(maruel): Add back once it doesn't assert 500 times/sec.
94-
// Current thread books the critical section "AddRelease"
95-
// without release it.
96-
// DFAKE_SCOPED_LOCK_THREAD_LOCKED(add_release_);
9790
#if DCHECK_IS_ON()
9891
DCHECK(!in_dtor_);
9992
#endif
@@ -112,14 +105,13 @@ class RefCountedBase {
112105
mutable bool in_dtor_;
113106
#endif
114107

115-
DFAKE_MUTEX(add_release_);
116-
117108
DISALLOW_COPY_AND_ASSIGN(RefCountedBase);
118109
};
119110

120111
class RefCountedThreadSafeBase {
121112
public:
122113
bool HasOneRef() const;
114+
bool HasAtLeastOneRef() const;
123115

124116
protected:
125117
RefCountedThreadSafeBase();

‎src/include/base/cef_string16.h‎

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,7 @@ typedef std::char_traits<wchar_t> string16_char_traits;
8686

8787
#include "include/base/cef_macros.h"
8888

89+
namespace cef {
8990
namespace base {
9091

9192
typedef uint16_t char16;
@@ -156,7 +157,15 @@ struct string16_char_traits {
156157
static int_type eof() { return static_cast<int_type>(EOF); }
157158
};
158159

159-
typedef std::basic_string<char16, base::string16_char_traits> string16;
160+
typedef std::basic_string<char16, string16_char_traits> string16;
161+
162+
} // namespace base
163+
} // namespace cef
164+
165+
namespace base {
166+
167+
typedef cef::base::char16 char16;
168+
typedef cef::base::string16 string16;
160169

161170
extern std::ostream& operator<<(std::ostream& out, const string16& str);
162171

@@ -204,8 +213,8 @@ extern void PrintTo(const string16& str, std::ostream* out);
204213
//
205214
// TODO(mark): File this bug with Apple and update this note with a bug number.
206215

207-
extern template class std::basic_string<base::char16,
208-
base::string16_char_traits>;
216+
extern template class std::basic_string<cef::base::char16,
217+
cef::base::string16_char_traits>;
209218

210219
#endif // WCHAR_T_IS_UTF32
211220

0 commit comments

Comments
 (0)