Skip to content

Commit cecf1a7

Browse files
committed
Network use enable/disable vs admin state up/down
Use --enable and --disable vs --admin-state-up/--admin-state-down Change-Id: I90040b925cb537a8ba13d1dd609c51bb669cf149
1 parent 19b8605 commit cecf1a7

2 files changed

Lines changed: 21 additions & 16 deletions

File tree

‎openstackclient/network/v2/network.py‎

Lines changed: 17 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -43,13 +43,16 @@ def get_parser(self, prog_name):
4343
help='Name of network to create')
4444
admin_group = parser.add_mutually_exclusive_group()
4545
admin_group.add_argument(
46-
'--admin-state-up',
47-
dest='admin_state', action='store_true',
48-
default=True, help='Set Admin State Up')
46+
'--enable',
47+
dest='admin_state',
48+
default=True,
49+
action='store_true',
50+
help='Set administrative state up')
4951
admin_group.add_argument(
50-
'--admin-state-down',
51-
dest='admin_state', action='store_false',
52-
help='Set Admin State Down')
52+
'--disable',
53+
dest='admin_state',
54+
action='store_false',
55+
help='Set administrative state down')
5356
share_group = parser.add_mutually_exclusive_group()
5457
share_group.add_argument(
5558
'--share',
@@ -171,14 +174,16 @@ def get_parser(self, prog_name):
171174
)
172175
admin_group = parser.add_mutually_exclusive_group()
173176
admin_group.add_argument(
174-
'--admin-state-up',
175-
dest='admin_state', action='store_true',
177+
'--enable',
178+
dest='admin_state',
176179
default=None,
177-
help='Set Admin State Up')
180+
action='store_true',
181+
help='Set administrative state up')
178182
admin_group.add_argument(
179-
'--admin-state-down',
180-
dest='admin_state', action='store_false',
181-
help='Set Admin State Down')
183+
'--disable',
184+
dest='admin_state',
185+
action='store_false',
186+
help='Set administrative state down')
182187
parser.add_argument(
183188
'--name',
184189
metavar='<network_name>',

‎openstackclient/tests/network/v2/test_network.py‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ def test_create_no_options(self):
6161

6262
def test_create_all_options(self):
6363
arglist = [
64-
"--admin-state-down",
64+
"--disable",
6565
"--share",
6666
FAKE_NAME,
6767
] + self.given_show_options
@@ -88,7 +88,7 @@ def test_create_all_options(self):
8888

8989
def test_create_other_options(self):
9090
arglist = [
91-
"--admin-state-up",
91+
"--enable",
9292
"--no-share",
9393
FAKE_NAME,
9494
]
@@ -220,7 +220,7 @@ class TestSetNetwork(common.TestNetworkBase):
220220
def test_set_this(self):
221221
arglist = [
222222
FAKE_NAME,
223-
'--admin-state-up',
223+
'--enable',
224224
'--name', 'noob',
225225
'--share',
226226
]
@@ -247,7 +247,7 @@ def test_set_this(self):
247247
def test_set_that(self):
248248
arglist = [
249249
FAKE_NAME,
250-
'--admin-state-down',
250+
'--disable',
251251
'--no-share',
252252
]
253253
verifylist = [

0 commit comments

Comments
 (0)